From cffe3dc49fd9258e1558e9a1cdabb33e924f36be Mon Sep 17 00:00:00 2001 From: Asias He Date: Thu, 24 Oct 2024 10:17:15 +0800 Subject: [PATCH] repair: Fix finished ranges metrics for removenode The skipped ranges should be multiplied by the number of tables. Otherwise the finished ranges ratio will not reach 100%. Fixes #21174 --- repair/repair.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/repair/repair.cc b/repair/repair.cc index 3c62e06e07..8fc762a0fe 100644 --- a/repair/repair.cc +++ b/repair/repair.cc @@ -1912,12 +1912,12 @@ future<> repair_service::do_decommission_removenode_with_repair(locator::token_m } temp.clear_gently().get(); if (reason == streaming::stream_reason::decommission) { - container().invoke_on_all([nr_ranges_skipped] (repair_service& rs) { - rs.get_metrics().decommission_finished_ranges += nr_ranges_skipped; + container().invoke_on_all([nr_ranges_skipped, nr_tables] (repair_service& rs) { + rs.get_metrics().decommission_finished_ranges += nr_ranges_skipped * nr_tables; }).get(); } else if (reason == streaming::stream_reason::removenode) { - container().invoke_on_all([nr_ranges_skipped] (repair_service& rs) { - rs.get_metrics().removenode_finished_ranges += nr_ranges_skipped; + container().invoke_on_all([nr_ranges_skipped, nr_tables] (repair_service& rs) { + rs.get_metrics().removenode_finished_ranges += nr_ranges_skipped * nr_tables; }).get(); } if (is_removenode) {