From d73a0b72e8a304a05b067ddd7c5869e48b496ee8 Mon Sep 17 00:00:00 2001 From: Yaniv Michael Kaul Date: Sun, 31 May 2026 09:13:59 +0300 Subject: [PATCH] readers: remove dead _next_range member from mutation_reader::impl The `std::optional _next_range` member of `mutation_reader::impl` is never read or written anywhere in the tree (verified across the entire codebase); only its declaration exists. Its comment claims it is "set by fill buffer for segregating output by partition range", but no such code remains. Remove the dead member. `std::optional` is 96 bytes, so this shrinks `mutation_reader::impl` -- the base class of every reader implementation -- by 96 bytes per instance, with no behavioural change. Tested: build/dev/test/boost/combined_tests --run_test=mutation_reader_test (smp=2) passes ("No errors detected"). Signed-off-by: Yaniv Kaul AI-assisted: Yes Backport: no, improvement --- readers/mutation_reader.hh | 3 --- 1 file changed, 3 deletions(-) diff --git a/readers/mutation_reader.hh b/readers/mutation_reader.hh index ba5094aa36..848a1d1b0d 100644 --- a/readers/mutation_reader.hh +++ b/readers/mutation_reader.hh @@ -137,9 +137,6 @@ public: // unless the reader is fast-forwarded to a new range. bool _end_of_stream = false; - // Set by fill buffer for segregating output by partition range. - std::optional _next_range; - schema_ptr _schema; reader_permit _permit; friend class mutation_reader;