From daf00a7f24eb085d41101fccd201e862d0df4a97 Mon Sep 17 00:00:00 2001 From: Marcin Maliszkiewicz Date: Tue, 9 Dec 2025 18:11:15 +0100 Subject: [PATCH] alternator: change type from string to string_view in should_add_capacity It avoids allocation. --- alternator/consumed_capacity.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/alternator/consumed_capacity.cc b/alternator/consumed_capacity.cc index 16a4ba34e7..3097e442bf 100644 --- a/alternator/consumed_capacity.cc +++ b/alternator/consumed_capacity.cc @@ -9,6 +9,7 @@ #include "consumed_capacity.hh" #include "error.hh" #include "utils/rjson.hh" +#include namespace alternator { @@ -33,12 +34,12 @@ bool consumed_capacity_counter::should_add_capacity(const rjson::value& request) if (!return_consumed->IsString()) { throw api_error::validation("Non-string ReturnConsumedCapacity field in request"); } - std::string consumed = rjson::to_string(*return_consumed); + std::string_view consumed = rjson::to_string_view(*return_consumed); if (consumed == "INDEXES") { throw api_error::validation("INDEXES consumed capacity is not supported"); } if (consumed != "TOTAL") { - throw api_error::validation("Unknown consumed capacity "+ consumed); + throw api_error::validation(fmt::format("Unknown consumed capacity {}", consumed)); } return true; }