mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

migration manager: assert that if schema pull is disabled the group0 is not in use_pre_raft_procedures state

Browse Source 
If schema pull are disabled group0 is used to bring up to date schema
by calling start_group0_operation() which executes raft read barrier
internally, but if the group0 is still in use_pre_raft_procedures
start_group0_operation() silently does nothing. Later the code that
assumes that schema is already up-to-date will fail and print warnings
into the log. But since getting queries in the state when a node is in
raft enabled mode but group0 is still not configured is illegal it is
better to make those errors more visible buy asserting them during
testing.

Closes scylladb/scylladb#25112
This commit is contained in:
Gleb Natapov
2025-07-21 17:36:50 +03:00
committed by Tomasz Grabiec
parent b65a2e2303
commit ddc3b6dcf5
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
service/migration_manager.cc
View File

@@ -18,6 +18,7 @@
#include "locator/host_id.hh"
#include "schema/schema_registry.hh"
#include "service/migration_manager.hh"
#include "seastar/core/on_internal_error.hh"
#include "service/storage_proxy.hh"
#include "service/raft/group0_state_machine.hh"
@@ -1112,6 +1113,9 @@ future<schema_ptr> migration_manager::get_schema_for_write(table_schema_version
// `_enable_schema_pulls` may change concurrently with this function (but only from `true` to `false`).
bool use_raft = !_enable_schema_pulls;
if ((!s || !s->is_synced()) && use_raft) {
if ((co_await _group0_client.get_group0_upgrade_state()).second == group0_upgrade_state::use_pre_raft_procedures) {
on_internal_error(mlogger, "Trying to pull schema over raft while in pre raft procedures");
}
// Schema is synchronized through Raft, so perform a group 0 read barrier.
// Batch the barriers so we don't invoke them redundantly.
mlogger.trace("Performing raft read barrier because schema is not synced, version: {}", v);