mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gms: remove unused feature bits

Browse Source 
Checks for features introduced over 2 years ago were removed
in previous commits, so all that is left is removing the feature
bits itself. Note that the feature strings are still sent
to other nodes just to be double sure, but the new code assumes
that all these features are implicitly enabled.
This commit is contained in:
Piotr Sarna
2020-09-14 12:35:28 +02:00
parent f7a7931377
commit defe6f49df
2 changed files with 0 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
gms/feature_service.cc
View File

@@ -65,20 +65,7 @@ feature_config::feature_config() {
}
feature_service::feature_service(feature_config cfg) : _config(cfg)
, _range_tombstones_feature(*this, features::RANGE_TOMBSTONES)
, _large_partitions_feature(*this, features::LARGE_PARTITIONS)
, _materialized_views_feature(*this, features::MATERIALIZED_VIEWS)
, _counters_feature(*this, features::COUNTERS)
, _indexes_feature(*this, features::INDEXES)
, _digest_multipartition_read_feature(*this, features::DIGEST_MULTIPARTITION_READ)
, _correct_counter_order_feature(*this, features::CORRECT_COUNTER_ORDER)
, _schema_tables_v3(*this, features::SCHEMA_TABLES_V3)
, _correct_non_compound_range_tombstones(*this, features::CORRECT_NON_COMPOUND_RANGE_TOMBSTONES)
, _write_failure_reply_feature(*this, features::WRITE_FAILURE_REPLY)
, _xxhash_feature(*this, features::XXHASH)
, _udf_feature(*this, features::UDF)
, _roles_feature(*this, features::ROLES)
, _stream_with_rpc_stream_feature(*this, features::STREAM_WITH_RPC_STREAM)
, _mc_sstable_feature(*this, features::MC_SSTABLE)
, _md_sstable_feature(*this, features::MD_SSTABLE)
, _row_level_repair_feature(*this, features::ROW_LEVEL_REPAIR)
@@ -255,20 +242,7 @@ db::schema_features feature_service::cluster_schema_features() const {
void feature_service::enable(const std::set<std::string_view>& list) {
for (gms::feature& f : {
std::ref(_range_tombstones_feature),
std::ref(_large_partitions_feature),
std::ref(_materialized_views_feature),
std::ref(_counters_feature),
std::ref(_indexes_feature),
std::ref(_digest_multipartition_read_feature),
std::ref(_correct_counter_order_feature),
std::ref(_schema_tables_v3),
std::ref(_correct_non_compound_range_tombstones),
std::ref(_write_failure_reply_feature),
std::ref(_xxhash_feature),
std::ref(_udf_feature),
std::ref(_roles_feature),
std::ref(_stream_with_rpc_stream_feature),
std::ref(_mc_sstable_feature),
std::ref(_md_sstable_feature),
std::ref(_row_level_repair_feature),

65
gms/feature_service.hh
View File

@@ -75,20 +75,7 @@ public:
std::set<std::string_view> supported_feature_set();
private:
gms::feature _range_tombstones_feature;
gms::feature _large_partitions_feature;
gms::feature _materialized_views_feature;
gms::feature _counters_feature;
gms::feature _indexes_feature;
gms::feature _digest_multipartition_read_feature;
gms::feature _correct_counter_order_feature;
gms::feature _schema_tables_v3;
gms::feature _correct_non_compound_range_tombstones;
gms::feature _write_failure_reply_feature;
gms::feature _xxhash_feature;
gms::feature _udf_feature;
gms::feature _roles_feature;
gms::feature _stream_with_rpc_stream_feature;
gms::feature _mc_sstable_feature;
gms::feature _md_sstable_feature;
gms::feature _row_level_repair_feature;
@@ -107,62 +94,10 @@ private:
gms::feature _digest_for_null_values_feature;
public:
bool cluster_supports_range_tombstones() const {
return bool(_range_tombstones_feature);
}
bool cluster_supports_large_partitions() const {
return bool(_large_partitions_feature);
}
bool cluster_supports_materialized_views() const {
return bool(_materialized_views_feature);
}
bool cluster_supports_counters() const {
return bool(_counters_feature);
}
bool cluster_supports_indexes() const {
return bool(_indexes_feature);
}
bool cluster_supports_digest_multipartition_reads() const {
return bool(_digest_multipartition_read_feature);
}
bool cluster_supports_correct_counter_order() const {
return bool(_correct_counter_order_feature);
}
const gms::feature& cluster_supports_schema_tables_v3() const {
return _schema_tables_v3;
}
bool cluster_supports_reading_correctly_serialized_range_tombstones() const {
return bool(_correct_non_compound_range_tombstones);
}
bool cluster_supports_write_failure_reply() const {
return bool(_write_failure_reply_feature);
}
bool cluster_supports_xxhash_digest_algorithm() const {
return bool(_xxhash_feature);
}
bool cluster_supports_user_defined_functions() const {
return bool(_udf_feature);
}
bool cluster_supports_roles() const {
return bool(_roles_feature);
}
bool cluster_supports_stream_with_rpc_stream() const {
return bool(_stream_with_rpc_stream_feature);
}
const feature& cluster_supports_mc_sstable() const {
return _mc_sstable_feature;
}