From e242ae7ee8f4e60b308e4a42fe1bd2c361220f40 Mon Sep 17 00:00:00 2001
From: Marcin Maliszkiewicz <marcinmal@scylladb.com>
Date: Mon, 11 Nov 2024 16:39:11 +0100
Subject: [PATCH] db: don't perform move on tablet_hint reference

This lambda is called several times so there should be no move.
Currently the bug likely doesn't manifest as code does work
only on shard 0.
---
 db/schema_applier.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/db/schema_applier.cc b/db/schema_applier.cc
index 70e75489ed..22d869e045 100644
--- a/db/schema_applier.cc
+++ b/db/schema_applier.cc
@@ -671,7 +671,7 @@ static future<affected_tables_and_views> merge_tables_and_views(distributed<serv
         // and so that compaction groups are not destroyed altogether.
         // We must also do it before tables are created so that new tables see the tablet map.
         co_await db.invoke_on_all([&] (replica::database& db) -> future<> {
-            co_await db.get_notifier().update_tablet_metadata(std::move(tablet_hint));
+            co_await db.get_notifier().update_tablet_metadata(tablet_hint);
         });
     }