From e26d983453ce73d4b4b72aede116cb8cf3292abe Mon Sep 17 00:00:00 2001 From: Avi Kivity Date: Sat, 23 May 2026 18:03:25 +0300 Subject: [PATCH] mutation_fragment_v1_stream: make consume() methods public The MutationFragmentConsumerV2 concept checks that these methods exist. Clang 23 tightened [1] the rules to verify that the methods are publicly accessible. Make them public so we don't fail the build. [1] https://github.com/llvm/llvm-project/commit/ac3c588739a09ebb0f80a22ee10282592d858b47 --- readers/mutation_fragment_v1_stream.hh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readers/mutation_fragment_v1_stream.hh b/readers/mutation_fragment_v1_stream.hh index 44d429d188..e9efe59569 100644 --- a/readers/mutation_fragment_v1_stream.hh +++ b/readers/mutation_fragment_v1_stream.hh @@ -14,7 +14,7 @@ class mutation_fragment_v1_stream final { range_tombstone_assembler _rt_assembler; std::optional _row; - friend class mutation_fragment_v2; // so it sees our consumer methods +public: // consume() methods need to be visible to concepts like MutationFragmentConsumerV2 mutation_fragment_opt consume(static_row mf) { return wrap(std::move(mf)); } @@ -41,7 +41,7 @@ class mutation_fragment_v1_stream final { _rt_assembler.on_end_of_stream(); return wrap(std::move(mf)); } - +private: future read_from_underlying() { auto mfp = co_await _reader(); if (!mfp) [[unlikely]] {