From f3297824e397b2a3ecd0652a976d90d8024c556b Mon Sep 17 00:00:00 2001 From: Avi Kivity Date: Wed, 4 Jun 2025 14:18:35 +0300 Subject: [PATCH] Revert "config: decrease default large allocation warning threshold to 128k" This reverts commit 04fb2c026d7d3dfd9489480aae105d9de5f283ea. 2025.3 got the reduced threshold, but won't get many of the fixes the warning will generate, leaving it very noisy. Better to avoid the noise for this release. Fixes #24384. --- db/config.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/config.cc b/db/config.cc index 72d62c3eca..48de30381d 100644 --- a/db/config.cc +++ b/db/config.cc @@ -1230,7 +1230,7 @@ db::config::config(std::shared_ptr exts) , sstable_summary_ratio(this, "sstable_summary_ratio", value_status::Used, 0.0005, "Enforces that 1 byte of summary is written for every N (2000 by default)" "bytes written to data file. Value must be between 0 and 1.") , components_memory_reclaim_threshold(this, "components_memory_reclaim_threshold", liveness::LiveUpdate, value_status::Used, .2, "Ratio of available memory for all in-memory components of SSTables in a shard beyond which the memory will be reclaimed from components until it falls back under the threshold. Currently, this limit is only enforced for bloom filters.") - , large_memory_allocation_warning_threshold(this, "large_memory_allocation_warning_threshold", value_status::Used, (size_t(128) << 10) + 1, "Warn about memory allocations above this size; set to zero to disable.") + , large_memory_allocation_warning_threshold(this, "large_memory_allocation_warning_threshold", value_status::Used, size_t(1) << 20, "Warn about memory allocations above this size; set to zero to disable.") , enable_deprecated_partitioners(this, "enable_deprecated_partitioners", value_status::Used, false, "Enable the byteordered and random partitioners. These partitioners are deprecated and will be removed in a future version.") , enable_keyspace_column_family_metrics(this, "enable_keyspace_column_family_metrics", value_status::Used, false, "Enable per keyspace and per column family metrics reporting.") , enable_node_aggregated_table_metrics(this, "enable_node_aggregated_table_metrics", value_status::Used, true, "Enable aggregated per node, per keyspace and per table metrics reporting, applicable if enable_keyspace_column_family_metrics is false.")