mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

treewide: silence discarded future warnings for legit discards

Browse Source 
This patch silences those future discard warnings where it is clear that
discarding the future was actually the intent of the original author,
*and* they did the necessary precautions (handling errors). The patch
also adds some trivial error handling (logging the error) in some
places, which were lacking this, but otherwise look ok. No functional
changes.
This commit is contained in:
Botond Dénes
2019-08-05 17:07:54 +03:00
parent cff4c4932d
commit fddd9a88dd
30 changed files with 142 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
db/commitlog/commitlog.cc
View File

@@ -1447,7 +1447,7 @@ void db::commitlog::segment_manager::discard_unused_segments() {
// segments on deletion queue could be non-empty, and we don't want
// those accidentally left around for replay.
if (!_shutdown) {
with_gate(_gate, [this] {
(void)with_gate(_gate, [this] {
return do_pending_deletes();
});
}
@@ -1598,7 +1598,7 @@ future<> db::commitlog::segment_manager::clear() {
*/
void db::commitlog::segment_manager::sync() {
for (auto s : _segments) {
s->sync(); // we do not care about waiting...
(void)s->sync(); // we do not care about waiting...
}
}
@@ -1606,7 +1606,7 @@ void db::commitlog::segment_manager::on_timer() {
// Gate, because we are starting potentially blocking ops
// without waiting for them, so segement_manager could be shut down
// while they are running.
seastar::with_gate(_gate, [this] {
(void)seastar::with_gate(_gate, [this] {
if (cfg.mode != sync_mode::BATCH) {
sync();
}