mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-22 01:20:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
14,460 Commits 235 Branches 539 Tags
3e8cfbf2a09ce044f739dfd4f405ef7d32eb0599
Commit Graph

148 Commits

Author SHA1 Message Date
Tomasz Grabiec
c1b82e60e3 tests: row_cache: Add test for memtable readers surviving flush and eviction 
Reproduces https://github.com/scylladb/scylla/issues/3186
 2018-02-06 14:24:19 +01:00
Piotr Jastrzebski
7729bc5e7b Remove unused mutation_reader_assertions 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:56:48 +01:00
Piotr Jastrzebski
39ec13133f row_cache: rename make_flat_reader to make_reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
0d76091a28 test_mvcc: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
425c1624cd test_cache_population_and_clear_race: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
dc97acb778 test_cache_population_and_update_race: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
1bead9747a test_continuity_flag_and_invalidate_race: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
4266b9759e test_update_failure: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
d5366026b1 row_cache_test: use flat reader in verify_has 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
56b0157831 row_cache_test: use flat reader in has_key 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
06bca9f4d5 test_sliced_read_row_presence: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
6c3d9cdb9f test_lru: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
a979869a15 test_update_invalidating: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
781d9a324d test_scan_with_partial_partitions: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
f199aab1ad test_cache_populates_partition_tombstone: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
9755f7677c test_tombstone_merging_in_partial_partition: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
2e1b12b6ce consume_all,populate_range: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
d08f4a40b2 test_readers_get_all_data_after_eviction: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
f99992261f test_tombstones_are_not_missed_when_range_is_invalidated: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
50fb2a57b6 test_exception_safety_of_reads: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
f0af5a1321 test_exception_safety_of_transitioning_from_underlying_read_to_read_from_cache: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
98b97be19a test_exception_safety_of_partition_scan: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:45 +01:00
Piotr Jastrzebski
5010c082f6 test_concurrent_population_before_latest_version_iterator: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
f8964f3aff test_concurrent_populating_partition_range_reads: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
3e1da7525e test_random_row_population: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
e6cf785829 test_continuity_is_populated_when_read_overlaps_with_older_version: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
2b61411c7b test_continuity_population_with_multicolumn_clustering_key: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
561f5fbb5a test_continuity_is_populated_for_single_row_reads: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
a1b6557877 test_concurrent_setting_of_continuity_on_read_upper_bound: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
6bbd0c7301 test_reading_from_random_partial_partition: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
327eb8fbbd test_tombstone_merging_of_overlapping_tombstones_in_many_versions: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
07df1a6f87 test_concurrent_reads_and_eviction: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
63f45d522e test_eviction: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
57d19a390a test_random_partition_population: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
e9e8121ffe test_single_key_queries_after_population_in_reverse_order: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
9acbb1e0f4 test_query_of_incomplete_range_goes_to_underlying: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
7456c31e10 test_cache_delegates_to_underlying_only_once_with_single_partition: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
4a3f5249ce test_cache_uses_continuity_info_for_single_partition_query: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
869443e11f test_cache_delegates_to_underlying_only_once_empty_single_partition_query: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
4cc9a0d852 test_cache_delegates_to_underlying_only_once_empty_full_range: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
5cdc77b66e test_cache_works_after_clearing: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
5091474f14 test_cache_delegates_to_underlying: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:54:44 +01:00
Piotr Jastrzebski
c0c88b3d4e Fix master 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:53:11 +01:00
Piotr Jastrzebski
c394dd9288 row_cache_test: add tests for small_buffer 
When a buffer of a flat reader is small then the reader can't
handle range_tombstones correctly.

This is not a problem on a production when the buffer is large.

Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-24 20:09:11 +01:00
José Guilherme Vanz
380bc0aa0d Swap arguments order of mutation constructor 
Swap arguments in the mutation constructor keeping the same standard
from the constructor variants. Refs #3084

Signed-off-by: José Guilherme Vanz <guilherme.sft@gmail.com>
Message-Id: <20180120000154.3823-1-guilherme.sft@gmail.com>
 2018-01-21 12:58:42 +02:00
Piotr Jastrzebski
d266eaa01e mutation_source: rename make_flat_mutation_reader to make_reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-19 09:30:12 +01:00
Piotr Jastrzebski
b99dd17dcd test_cache_delegates_to_underlying_only_once_multiple_mutation: use flat reader 
Signed-off-by: Piotr Jastrzebski <piotr@scylladb.com>
 2018-01-17 19:51:03 +01:00
Avi Kivity
93076d25b6 Merge "mutation_source: remove support for creation with mutation_reader" from Piotr 
"After this patchset it's only possible to create a mutation_source with a function that produces flat_mutation_reader."

* 'haaawk/mutation_source_v1' of ssh://github.com/scylladb/seastar-dev:
  Merge flat_mutation_reader_mutation_source into mutation_source
  Remove unused mutation_reader_mutation_source
  Remove unused mutation_source constructor.
  Migrate make_source to flat reader
  Migrate run_conversion_to_mutation_reader_tests to flat reader
  flat_mutation_reader_from_mutations: add support for slicing
  Remove unused mutation_source constructor.
  Migrate partition_counting_reader to flat reader
  Migrate throttled_mutation_source to flat reader
  Extract delegating_reader from make_delegating_reader
  row_cache_test: call row_cache::make_flat_reader in mutation_sources
  Remove unused friend declaration in flat_mutation_reader::impl
  Migrate make_source_with to flat reader
  Migrate make_empty_mutation_source to flat reader
  Remove unused mutation_source constructor
  Migrate test_multi_range_reader to flat reader
  Remove unused mutation_source constructors
 2018-01-15 18:15:53 +02:00
Glauber Costa
5140aaea00 add a timeout to fast forward to 
In the last patch, we enabled per-request timeouts, we enable timeouts
in fill_buffer. There are many places, though, in which we
fast_forward_to before we fill_buffer, so in order to make that
effective we need to propagate the timeouts to fast_forward_to as well.

In the same way as fill_buffer, we make the argument optional wherever
possible in the high level callers, making them mandatory in the
implementations.

Signed-off-by: Glauber Costa <glauber@scylladb.com>
 2018-01-12 07:43:19 -05:00
Tomasz Grabiec
5a32cf9008 tests: Make bad_alloc from test_concurrent_reads_and_eviction less likely 
With -m1G, the test failed sporadically, because too many large
mutations were accumulated in memory. Avoid by limiting backlog.

Message-Id: <1515486430-4778-1-git-send-email-tgrabiec@scylladb.com>
 2018-01-09 13:52:38 +02:00