Our debugging builds always produce the annoying false warning like:
==1199==ERROR: AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete) on 0x62300003d500
This error could be silenced by setting ASAN_OPTIONS=alloc_dealloc_mismatch=0
(and we do this in test.py), but it's still annoying for manual runs, and
can mask real bugs of this type.
The problem appears to be that the address sanitizer doesn't understand
our new(with_align(..)) trick we used to allocate the reactor object,
and when we eventually use ordinary "delete" on this object, it thinks
we mixed malloc and delete.
This patch uses posix_memalign() and free() to allocate and free the
reactor structure, and ASAN stops complaining.
Signed-off-by: Nadav Har'El <nyh@cloudius-systems.com>
At this point, users of the interface are futurized already, so we
just need to make sure they call the right function.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
The comparator used to sort the set should the underlying types' comparator,
not the set's comparator.
Using the latter will eventually crash with out of bound reads if we're lucky (I was),
or sort incorrectly if we are unlucky.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
This function is called at startup and makes sure that the cluster_name field
in system.local exists, and if it exists, that it matches the expected value.
To simplifly things, I am leaving the sstable check out. For us, that would be
a map-reduce operation, and if the sstables are indeed corrupted, we would have
caught that already for sure.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
This patch provide a function to store the current schema version.
Currently, it is called every time the node boots, with a random schema.
That is incorrect and will be fixed shortly. But for now, cqlsh needs
to see a valid value here, so this will do.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
Soon that will involve a query. The idiom make_ready_future<>().then()
is a bit unusual to say the least, but it will soon be replace by an
actual future.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
We will have to flush it from other places as well, so wrap the flushing code
into a method - specially because the current code has issues and it will be
easier to deal with it if it is in a single place.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
This should really be generated by the build scripts, but since we haven't
even discussed any versioning scheme, I'm introducing the functions here - they
are needed to populate some system tables, and later on we can make them return
the right thing.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
We won't create our own versions of database and query_proxy, so we need
some setup to be done. The current code will capture those variables and
setup the structure used to conduct the queries. Later on, it will also
carry on the database's basic setup.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
The messaging service is initialized very early, before we have the
proxy or query processor initialized. It is mostly fine, except for
the fact that the messaging service also finishes the initialization
of the storage service. That part will issue queries agains the system
tables, (as soon as we support them), and need to happen later.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
We need to be able to do it so we can, among other things, create CQL
statements that include the current state of the tokens.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
If the client state is marked as internal, go for the internal version
of the queries instead.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
Most of the time we're querying internal, we are going for the system.
Defaulting to it just makes it easier, and callers can still change it
with set_keyspace if needed.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
What "internal" really means here, is queries that operate on the system tables.
Up until now, there wasn't really an issue because we weren't really checking
on this flag, and the internal calls were all unimplemented.
Now that we are about to hook up the internal calls, leaving this state marked
as internal will lead us to fail when we try to issue statements - like create
table - that are not, and will not be implemented in their internal
counterparts.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
received is moved to the inner attribute _receiver. Trying to call receiver
after that will SEGFAULT us.
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
It is a better fit for things that are names, not blobs. We have a user that expects
a bytes parameter, but that is for no other reason than the fact that the field used
to be of bytes type.
Let's fix that, and future users will be able to use sstrings
Signed-off-by: Glauber Costa <glommer@cloudius-systems.com>
"We don't want multiple shards to respond with the same data. Higher level code
assumes that shard data is non-overlapping. It's cheaper to drop duplicates as
soon as possible. Memtable reader for example will never have overlapping
data, so cache hitting queries will never need to pay for this. Compaction
process may also rely on this."
SIGALRM is used by the boost unit test library, which interferes with our
use. This causes spurious unit test failures.
Switch to a real-time signal instead.
"This series implements schema mutation announcement by pushing schema
mutations via migration manager as well as wiring up DEFINITIONS_UPDATE
verb to the merge_schema() function. This makes schema changes visible
to all nodes that are live at the time:
Node 1:
[penberg@nero apache-cassandra-2.1.7]$ ./bin/cqlsh --no-color 127.0.0.1
Connected to TestCluster at 127.0.0.1:9042.
[cqlsh 5.0.1 | Cassandra 3.0.0-SNAPSHOT | CQL spec 3.2.0 | Native protocol v3]
Use HELP for help.
cqlsh> CREATE KEYSPACE keyspace3 WITH REPLICATION = { 'class' : 'SimpleStrategy', 'replication_factor' : 1 };
cqlsh> SELECT * FROM system.schema_keyspaces;
keyspace_name | durable_writes | strategy_class | strategy_options
---------------+----------------+--------------------------------------------+------------------------------
keyspace3 | True | SimpleStrategy | {"replication_factor":"1"}\n
system | True | org.apache.cassandra.locator.LocalStrategy | {}
(2 rows)
cqlsh> CREATE TABLE keyspace3.standard1 ( key blob PRIMARY KEY, C0 blob, C1 blob, C2 blob, C3 blob, C4 blob);
cqlsh> SELECT keyspace_name, columnfamily_name, key_validator FROM system.schema_columnfamilies;
keyspace_name | columnfamily_name | key_validator
---------------+-----------------------+-------------------------------------------
keyspace3 | standard1 | org.apache.cassandra.db.marshal.BytesType
system | local | org.apache.cassandra.db.marshal.UTF8Type
system | peers | org.apache.cassandra.db.marshal.UTF8Type
system | schema_columnfamilies | org.apache.cassandra.db.marshal.UTF8Type
system | schema_columns | org.apache.cassandra.db.marshal.UTF8Type
system | schema_keyspaces | org.apache.cassandra.db.marshal.UTF8Type
(6 rows)
cqlsh>
Node 2:
[penberg@nero apache-cassandra-2.1.7]$ ./bin/cqlsh --no-color 127.0.0.2
Connected to TestCluster at 127.0.0.2:9042.
[cqlsh 5.0.1 | Cassandra 3.0.0-SNAPSHOT | CQL spec 3.2.0 | Native protocol v3]
Use HELP for help.
cqlsh> SELECT * FROM system.schema_keyspaces;
keyspace_name | durable_writes | strategy_class | strategy_options
---------------+----------------+--------------------------------------------+------------------------------
keyspace3 | True | SimpleStrategy | {"replication_factor":"1"}\n
system | True | org.apache.cassandra.locator.LocalStrategy | {}
(2 rows)
cqlsh> SELECT keyspace_name, columnfamily_name, key_validator FROM system.schema_columnfamilies;
keyspace_name | columnfamily_name | key_validator
---------------+-----------------------+-------------------------------------------
keyspace3 | standard1 | org.apache.cassandra.db.marshal.BytesType
system | local | org.apache.cassandra.db.marshal.UTF8Type
system | peers | org.apache.cassandra.db.marshal.UTF8Type
system | schema_columnfamilies | org.apache.cassandra.db.marshal.UTF8Type
system | schema_columns | org.apache.cassandra.db.marshal.UTF8Type
system | schema_keyspaces | org.apache.cassandra.db.marshal.UTF8Type
(6 rows)
cqlsh>
We eventually also need schema pulling capability for nodes that join
late or get out of sync for full schema distribution support. That is,
however, out of scope for this patch series."
Announce schema mutations in a cluster via the DEFINITIONS_UPDATE verb
and pass them to merge_schema() at endpoints.
Signed-off-by: Pekka Enberg <penberg@cloudius-systems.com>
Various enable_if overload take precedence if a non-const frozen_mutation
is provided (instead of matching the const frozen_mutation& signature).
Provide a non-const frozen_mutation& signature to work around the issue.
