4 Commits

Author	SHA1	Message	Date
Nadav Har'El	5b2f35a21a	Merge "Redis: fix the options related to Redis API, fix the DEL and GET command" ... Merged pull request https://github.com/scylladb/scylla/pull/5381 by Peng Jian, fixing multiple small issues with Redis: * Rename the options related to Redis API, and describe them clearly. * Rename redis_transport_port to redis_port * Rename redis_transport_port_ssl to redis_ssl_port * Rename redis_default_database_count to redis_database_count * Remove unnecessary option enable_redis_protocol * Modify the default value of opition redis_read_consistency_level and redis_write_consistency_level to LOCAL_QUORUM * Fix the DEL command: support to delete mutilple keys in one command. * Fix the GET command: return the empty string when the required key is not exists. * Fix the redis-test/test_del_non_existent_key: mark xfail.	2019-12-05 11:58:34 +02:00
fastio	01599ffbae	Redis API: Support the syntax of deleting multiple keys in one DEL command, fix the returning value for GET command. ... Support to delete multiple keys in one DEL command. The feature of returning number of the really deleted keys is still not supported. Return empty string to client for GET command when the required key is not exists. Fixes: #5334 Signed-off-by: Peng Jian <pengjian.uestc@gmail.com>	2019-12-03 17:27:40 +08:00
Amos Kong	4fa862adf4	redis: skip processing request of EOF ... When I test the redis cmd by echo and nc, there is a redundant error in the end. I checked by strace, currently if client read nothing from stdin, it will shutdown the socket, redis server will read nothing (0 byte) from socket. But it tries to process the empty command and returns an error. $ echo -n -e '*1\r\n$4\r\nping\r\n' |strace nc localhost 6379 | ... | read(0, "*1\r\n$4\r\nping\r\n", 8192) = 14 | select(5, [4], [4], [], NULL) = 1 (out [4]) |>>> sendto(4, "*1\r\n$4\r\nping\r\n", 14, 0, NULL, 0) = 14 | select(5, [0 4], [], [], NULL) = 1 (in [0]) | recvfrom(0, 0x7ffe4d5b6c70, 8192, 0, 0x7ffe4d5b6bf0, 0x7ffe4d5b6bec) = -1 ENOTSOCK (Socket operation on non-socket) | read(0, "", 8192) = 0 |>>> shutdown(4, SHUT_WR) = 0 | select(5, [4], [], [], NULL) = 1 (in [4]) | recvfrom(4, "+PONG\r\n-ERR unknown command ''\r\n", 8192, 0, 0x7ffe4d5b6bf0, [0]) = 32 | write(1, "+PONG\r\n-ERR unknown command ''\r\n", 32+PONG | -ERR unknown command '' | ) = 32 | select(5, [4], [], [], NULL) = 1 (in [4]) | recvfrom(4, "", 8192, 0, 0x7ffe4d5b6bf0, [0]) = 0 | close(1) = 0 | close(4) = 0 Current result: $ echo -n -e '' |nc localhost 6379 -ERR unknown command '' $ echo -n -e '*1\r\n$4\r\nping\r\n' |nc localhost 6379 +PONG -ERR unknown command '' Expected: $ echo -n -e '' |nc localhost 6379 $ echo -n -e '*1\r\n$4\r\nping\r\n' |nc localhost 6379 +PONG Signed-off-by: Amos Kong <amos@scylladb.com>	2019-12-03 10:47:56 +08:00
Peng Jian	0737d9e84d	redis: Redis API in Scylla ... Scylla has advantage and amazing features. If Redis build on the top of Scylla, it has the above features automatically. It's achived great progress in cluster master managment, data persistence, failover and replication. The benefits to the users are easy to use and develop in their production environment, and taking avantages of Scylla. Using the Ragel to parse the Redis request, server abtains the command name and the parameters from the request, invokes the Scylla's internal API to read and write the data, then replies to client. Signed-off-by: Peng Jian, <pengjian.uestc@gmail.com>	2019-11-20 04:55:56 +08:00