# # Copyright (C) 2024-present ScyllaDB # # SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0 # import asyncio import pytest import time import logging import re from cassandra.cluster import NoHostAvailable # type: ignore from cassandra.query import SimpleStatement, ConsistencyLevel from test.pylib.internal_types import IPAddress from test.pylib.manager_client import ManagerClient from test.pylib.rest_client import ScyllaMetricsClient, TCPRESTClient, inject_error from test.pylib.tablets import get_tablet_replicas from test.pylib.scylla_cluster import ReplaceConfig from test.pylib.util import wait_for from test.cluster.util import get_topology_coordinator, find_server_by_host_id, new_test_keyspace logger = logging.getLogger(__name__) async def get_hint_metrics(client: ScyllaMetricsClient, server_ip: IPAddress, metric_name: str): metrics = await client.query(server_ip) return metrics.get(f"scylla_hints_manager_{metric_name}") async def create_sync_point(client: TCPRESTClient, server_ip: IPAddress) -> str: response = await client.post_json("/hinted_handoff/sync_point", host=server_ip, port=10_000) return response async def await_sync_point(client: TCPRESTClient, server_ip: IPAddress, sync_point: str, timeout: int) -> bool: params = { "id": sync_point, "timeout": str(timeout) } response = await client.get_json("/hinted_handoff/sync_point", host=server_ip, port=10_000, params=params) match response: case "IN_PROGRESS": return False case "DONE": return True case _: pytest.fail(f"Unexpected response from the server: {response}") # Write with RF=1 and CL=ANY to a dead node should write hints and succeed @pytest.mark.asyncio async def test_write_cl_any_to_dead_node_generates_hints(manager: ManagerClient): node_count = 2 servers = await manager.servers_add(node_count) cql = manager.get_cql() async with new_test_keyspace(manager, "WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}") as ks: table = f"{ks}.t" await cql.run_async(f"CREATE TABLE {table} (pk int primary key, v int)") await manager.server_stop_gracefully(servers[1].server_id) hints_before = await get_hint_metrics(manager.metrics, servers[0].ip_addr, "written") # Some of the inserts will be targeted to the dead node. # The coordinator doesn't have live targets to send the write to, but it should write a hint. for i in range(100): await cql.run_async(SimpleStatement(f"INSERT INTO {table} (pk, v) VALUES ({i}, {i+1})", consistency_level=ConsistencyLevel.ANY)) # Verify hints are written hints_after = await get_hint_metrics(manager.metrics, servers[0].ip_addr, "written") assert hints_after > hints_before # For dropping the keyspace await manager.server_start(servers[1].server_id) @pytest.mark.asyncio async def test_limited_concurrency_of_writes(manager: ManagerClient): """ We want to verify that Scylla correctly limits the concurrency of writing hints to disk. To do that, we leverage error injections decreasing the threshold when hints should start being rejected, and we expect to receive an exception indicating that a node is overloaded. """ node1 = await manager.server_add(config={ "error_injections_at_startup": ["decrease_max_size_of_hints_in_progress"] }) node2 = await manager.server_add() cql = manager.get_cql() async with new_test_keyspace(manager, "WITH replication = {'class': 'SimpleStrategy', 'replication_factor': 2}") as ks: table = f"{ks}.t" await cql.run_async(f"CREATE TABLE {table} (pk int primary key, v int)") await manager.server_stop_gracefully(node2.server_id) async with inject_error(manager.api, node1.ip_addr, "slow_down_writing_hints"): try: for i in range(100): await cql.run_async(SimpleStatement(f"INSERT INTO {table} (pk, v) VALUES ({i}, {i})", consistency_level=ConsistencyLevel.ONE)) pytest.fail("The coordinator node has not been overloaded, which indiciates that the concurrency of writing hints is NOT limited") except NoHostAvailable as e: for _, err in e.errors.items(): assert err.summary == "Coordinator node overloaded" and re.match(r"Too many in flight hints: \d+", err.message) # For dropping the keyspace await manager.server_start(node2.server_id) @pytest.mark.asyncio async def test_sync_point(manager: ManagerClient): """ We want to verify that the sync point API is compliant with its design. This test concerns one particular aspect of it: Scylla should create a sync point for ALL nodes if the parameter `target_hosts` of a request is empty, not just live nodes. """ node_count = 3 [node1, node2, node3] = await manager.servers_add(node_count) cql = manager.get_cql() async with new_test_keyspace(manager, "WITH replication = {'class': 'SimpleStrategy', 'replication_factor': 3}") as ks: table = f"{ks}.t" await cql.run_async(f"CREATE TABLE {table} (pk int primary key, v int)") await manager.server_stop_gracefully(node2.server_id) await manager.server_stop_gracefully(node3.server_id) await manager.server_not_sees_other_server(node1.ip_addr, node2.ip_addr) await manager.server_not_sees_other_server(node1.ip_addr, node3.ip_addr) mutation_count = 5 for primary_key in range(mutation_count): await cql.run_async(SimpleStatement(f"INSERT INTO {table} (pk, v) VALUES ({primary_key}, {primary_key})", consistency_level=ConsistencyLevel.ONE)) # Mutations need to be applied to hinted handoff's commitlog before we create the sync point. # Otherwise, the sync point will correspond to no hints at all. async def check_written_hints(min_count: int) -> bool: errors = await get_hint_metrics(manager.metrics, node1.ip_addr, "errors") assert errors == 0, "Writing hints to disk failed" hints = await get_hint_metrics(manager.metrics, node1.ip_addr, "written") if hints >= min_count: return True return None deadline = time.time() + 30 await wait_for(lambda: check_written_hints(2 * mutation_count), deadline) sync_point1 = await create_sync_point(manager.api.client, node1.ip_addr) await manager.server_start(node2.server_id) await manager.server_sees_other_server(node1.ip_addr, node2.ip_addr) assert not (await await_sync_point(manager.api.client, node1.ip_addr, sync_point1, 3)) await manager.server_start(node3.server_id) await manager.server_sees_other_server(node1.ip_addr, node3.ip_addr) assert await await_sync_point(manager.api.client, node1.ip_addr, sync_point1, 30) @pytest.mark.asyncio @pytest.mark.skip_mode(mode='release', reason="error injections aren't enabled in release mode") async def test_hints_consistency_during_decommission(manager: ManagerClient): """ This test reproduces the failure observed in scylladb/scylla-dtest#4582 in a more reliable way than the test_hintedhandoff_decom dtest. We want to make sure that data stored in hints will not get lost if hints replay happens in parallel to streaming during decommission. The test is vnodes-specific. """ (server1, server2, server3) = await manager.servers_add(3, config={ "error_injections_at_startup": ["decrease_hints_flush_period"] }) cql = manager.cql logger.info("Creatting a keyspace with RF=1 and a table") async with new_test_keyspace(manager, "WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1} AND tablets = { 'enabled': false }") as ks: table = f"{ks}.t" await cql.run_async(f"CREATE TABLE {table} (pk int primary key, v int)") logger.info("Stopping node 3") await manager.server_stop_gracefully(server3.server_id) await manager.others_not_see_server(server3.ip_addr) # Write 100 rows with CL=ANY. Some of the rows will only be stored as hints because of RF=1 logger.info("Writing 100 rows with CL=ANY") for i in range(100): await cql.run_async(SimpleStatement(f"INSERT INTO {table} (pk, v) VALUES ({i}, {i + 1})", consistency_level=ConsistencyLevel.ANY)) # Temporarily pause hints replay, we will unpause it after decommission starts and streaming is done, # but before switching to writing to new nodes logger.info("Pause hints replay on nodes 1 and 2") for srv in (server1, server2): await manager.api.enable_injection(srv.ip_addr, "hinted_handoff_pause_hint_replay", one_shot=False) # Start the node logger.info("Start node 3") await manager.server_start(server3.server_id) await manager.servers_see_each_other([server1, server2, server3]) # Record the current position of hints so that we can wait for them later sync_points = await asyncio.gather(*[create_sync_point(manager.api.client, srv.ip_addr) for srv in (server1, server2)]) sync_points = list(sync_points) async with asyncio.TaskGroup() as tg: coord = await get_topology_coordinator(manager) coord_srv = await find_server_by_host_id(manager, [server1, server2, server3], coord) # Make sure topology coordinator will pause right after streaming logger.info("Enabling injection on the topology coordinator that will tell it to pause streaming") await manager.api.enable_injection(coord_srv.ip_addr, "topology_coordinator_pause_after_streaming", one_shot=False) coord_log = await manager.server_open_log(coord_srv.server_id) coord_mark = await coord_log.mark() # Start decommission - it will get stuck on error injection so do it in the background logger.info("Starting decommission in the background") decommission_result = tg.create_task(manager.decommission_node(server3.server_id)) # Wait until streaming ends logger.info("Wait until decomission finishes streaming") await coord_log.wait_for(f'decommissioning: streaming completed for node', from_mark=coord_mark) # Now, unpause hints and let them be replayed logger.info("Unpause hints replay on nodes 1 and 2") for srv in (server1, server2): await manager.api.disable_injection(srv.ip_addr, "hinted_handoff_pause_hint_replay") logger.info("Wait until hints are replayed from nodes 1 and 2") await asyncio.gather(*(await_sync_point(manager.api.client, srv.ip_addr, pt, timeout=30) for srv, pt in zip((server1, server2), sync_points))) # Unpause streaming and let decommission finish logger.info("Unpause streaming") await manager.api.disable_injection(coord_srv.ip_addr, "topology_coordinator_pause_after_streaming") logger.info("Wait until decomission finishes") await decommission_result # Verify that no data has been lost - if the hints replay only sent the hints to the original destination (server3), # then they will be only present on server3 which already left the cluster logger.info("Verify that no data stored in hints have been lost") for i in range(100): assert list(await cql.run_async(f"SELECT v FROM {table} WHERE pk = {i}")) == [(i + 1,)] @pytest.mark.asyncio async def test_hints_consistency_during_replace(manager: ManagerClient): """ Reproducer for https://github.com/scylladb/scylladb/issues/24980 In this test, we stop a node, then write some data with CL=ANY and RF=1 to generate hints, and then replace the stopped node with a new one. After completing hint replay, all rows should be present on the cluster. """ servers = await manager.servers_add(3, config={ "error_injections_at_startup": ["decrease_hints_flush_period"] }) cql = await manager.get_cql_exclusive(servers[0]) async with new_test_keyspace(manager, "WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1}") as ks: table = f"{ks}.t" await cql.run_async(f"CREATE TABLE {table} (pk int primary key, v int)") await manager.server_stop_gracefully(servers[2].server_id) await manager.others_not_see_server(servers[2].ip_addr) # Write 100 rows with CL=ANY. Some of the rows will only be stored as hints because of RF=1 for i in range(100): await cql.run_async(SimpleStatement(f"INSERT INTO {table} (pk, v) VALUES ({i}, {i + 1})", consistency_level=ConsistencyLevel.ANY)) sync_point = await create_sync_point(manager.api.client, servers[0].ip_addr) await manager.server_add(replace_cfg=ReplaceConfig(replaced_id = servers[2].server_id, reuse_ip_addr = False, use_host_id = True)) assert await await_sync_point(manager.api.client, servers[0].ip_addr, sync_point, 30) # Verify that all rows were recovered by the hint replay for i in range(100): assert list(await cql.run_async(f"SELECT v FROM {table} WHERE pk = {i}")) == [(i + 1,)] @pytest.mark.asyncio async def test_draining_hints(manager: ManagerClient): """ This test verifies that all hints are drained when a node is being decommissioned. """ s1, s2, _ = await manager.servers_add(3) cql = manager.get_cql() await manager.api.set_logger_level(s1.ip_addr, "hints_manager", "trace") await cql.run_async("CREATE KEYSPACE ks WITH REPLICATION = {'class': 'SimpleStrategy', 'replication_factor': 3}") await cql.run_async("CREATE TABLE ks.t (pk int PRIMARY KEY, v int)") await manager.server_stop_gracefully(s2.server_id) # Generate hints towards s2 on s1 with probability 1 - ((#nodes - 1) / #nodes)^1000 ~= 1. for i in range(1000): await cql.run_async(SimpleStatement(f"INSERT INTO ks.t (pk, v) VALUES ({i}, {i + 1})", consistency_level=ConsistencyLevel.ANY)) sync_point = await create_sync_point(manager.api.client, s1.ip_addr) await manager.server_start(s2.server_id) async with asyncio.TaskGroup() as tg: _ = tg.create_task(manager.decommission_node(s1.server_id, timeout=60)) _ = tg.create_task(await_sync_point(manager.api.client, s1.ip_addr, sync_point, 60)) @pytest.mark.asyncio @pytest.mark.skip_mode(mode='release', reason='error injections are not supported in release mode') async def test_canceling_hint_draining(manager: ManagerClient): """ This test verifies that draining hints is canceled as soon as we issue a shutdown, but it's resumed after starting the node again. """ s1, s2, _ = await manager.servers_add(3) cql = manager.get_cql() host_id2 = await manager.get_host_id(s2.server_id) await manager.api.set_logger_level(s1.ip_addr, "hints_manager", "trace") await cql.run_async("CREATE KEYSPACE ks WITH REPLICATION = {'class': 'SimpleStrategy', 'replication_factor': 3}") await cql.run_async("CREATE TABLE ks.t (pk int PRIMARY KEY, v int)") await manager.server_stop_gracefully(s2.server_id) # Generate hints towards s2 on s1 with probability 1 - ((#nodes - 1) / #nodes)^1000 ~= 1. for i in range(1000): await cql.run_async(SimpleStatement(f"INSERT INTO ks.t (pk, v) VALUES ({i}, {i + 1})", consistency_level=ConsistencyLevel.ANY)) sync_point = await create_sync_point(manager.api.client, s1.ip_addr) await manager.api.enable_injection(s1.ip_addr, "hinted_handoff_pause_hint_replay", False, {}) await manager.remove_node(s1.server_id, s2.server_id) await manager.server_stop_gracefully(s1.server_id) s1_log = await manager.server_open_log(s1.server_id) s1_mark = await s1_log.mark() await manager.server_update_cmdline(s1.server_id, ["--logger-log-level", "hints_manager=trace"]) await manager.server_start(s1.server_id) s1_log = await manager.server_open_log(s1.server_id) # Make sure the node still knows about the decommissioned node and does start draining for it. await s1_log.wait_for(f"Draining starts for {host_id2}", from_mark=s1_mark) # Make sure draining finishes successfully. assert await await_sync_point(manager.api.client, s1.ip_addr, sync_point, 60) await s1_log.wait_for(f"Removed hint directory for {host_id2}") @pytest.mark.asyncio @pytest.mark.skip_mode(mode='release', reason='error injections are not supported in release mode') async def test_hint_to_pending(manager: ManagerClient): """ This test reproduces the scenario where sending a hint to a pending replica is needed for consistency as in https://github.com/scylladb/scylladb/issues/19835. In the test, we have 2 servers and a table with RF=1. One server is stopped, and we perform a write generating a hint to it. Then, we start the stopped server again and immediately request a tablet migration from that server. The hint is sent after the tablet migration performs streaming but before it completes. The order of operations is induced using error injections. At the end, we verify that the hint was successfully applied. """ servers = await manager.servers_add(2, property_file=[ {"dc": "dc1", "rack": "r1"}, {"dc": "dc1", "rack": "r1"}, ]) cql = await manager.get_cql_exclusive(servers[0]) await manager.disable_tablet_balancing() async with new_test_keyspace(manager, "WITH replication = {'class': 'NetworkTopologyStrategy', 'replication_factor': 1} AND tablets = {'initial': 1}") as ks: table = f"{ks}.t" await cql.run_async(f"CREATE TABLE {table} (pk int primary key, v int)") replica = (await get_tablet_replicas(manager, servers[0], ks, "t", 0))[0] host_ids = [await manager.get_host_id(server.server_id) for server in servers] if replica[0] != host_ids[1]: # We'll use server 0 as the source of the hint, so the tablet replica needs to be on server 1 await manager.api.move_tablet(servers[0].ip_addr, ks, "t", replica[0], replica[1], host_ids[1], 0, 0) await manager.server_stop_gracefully(servers[1].server_id) await manager.others_not_see_server(servers[1].ip_addr) await cql.run_async(SimpleStatement(f"INSERT INTO {table} (pk, v) VALUES (0, 0)", consistency_level=ConsistencyLevel.ANY)) await manager.api.enable_injection(servers[0].ip_addr, "hinted_handoff_pause_hint_replay", False) await manager.server_start(servers[1].server_id) sync_point = await create_sync_point(manager.api.client, servers[0].ip_addr) await manager.api.enable_injection(servers[0].ip_addr, "pause_after_streaming_tablet", False) tablet_migration = asyncio.create_task(manager.api.move_tablet(servers[0].ip_addr, ks, "t", host_ids[1], 0, host_ids[0], 0, 0)) async def migration_reached_streaming(): stages = await cql.run_async(f"SELECT stage FROM system.tablets WHERE keyspace_name='{ks}' ALLOW FILTERING") logger.info(f"Current stages: {[row.stage for row in stages]}") return set(["streaming"]) == set([row.stage for row in stages]) or None await wait_for(migration_reached_streaming, time.time() + 60) await manager.api.disable_injection(servers[0].ip_addr, "hinted_handoff_pause_hint_replay") assert await await_sync_point(manager.api.client, servers[0].ip_addr, sync_point, 30) await manager.api.message_injection(servers[0].ip_addr, "pause_after_streaming_tablet") done, pending = await asyncio.wait([tablet_migration]) for task in pending: task.cancel() for task in done: task.result() assert list(await cql.run_async(f"SELECT v FROM {table} WHERE pk = 0")) == [(0,)]