mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-29 04:37:00 +00:00
f03480c054
While trying to debug an unrelated bug, I was annoyed by the fact that parsing caching options keep throwing exceptions all the time. Those exceptions have no reason to happen: we try to convert the value to a number, and if we fail we fall back to one of the two blessed strings. We could just as easily just test for those strings beforehand and avoid all of that. While we're on it, the exception message should show the value of "r", not "k". Signed-off-by: Glauber Costa <glommer@scylladb.com>
89 lines
2.6 KiB
C++
89 lines
2.6 KiB
C++
/*
|
|
* Copyright (C) 2015 Cloudius Systems, Ltd.
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
#include <core/sstring.hh>
|
|
#include <boost/lexical_cast.hpp>
|
|
#include "exceptions/exceptions.hh"
|
|
#include "json.hh"
|
|
|
|
class schema;
|
|
|
|
class caching_options {
|
|
// For Origin, the default value for the row is "NONE". However, since our
|
|
// row_cache will cache both keys and rows, we will default to ALL.
|
|
//
|
|
// FIXME: We don't yet make any changes to our caching policies based on
|
|
// this (and maybe we shouldn't)
|
|
static constexpr auto default_key = "ALL";
|
|
static constexpr auto default_row = "ALL";
|
|
|
|
sstring _key_cache;
|
|
sstring _row_cache;
|
|
caching_options(sstring k, sstring r) : _key_cache(k), _row_cache(r) {
|
|
if ((k != "ALL") && (k != "NONE")) {
|
|
throw exceptions::configuration_exception("Invalid key value: " + k);
|
|
}
|
|
|
|
if ((r == "ALL") || (r == "NONE")) {
|
|
return;
|
|
} else {
|
|
try {
|
|
boost::lexical_cast<unsigned long>(r);
|
|
} catch (boost::bad_lexical_cast& e) {
|
|
throw exceptions::configuration_exception("Invalid key value: " + r);
|
|
}
|
|
}
|
|
}
|
|
|
|
friend class schema;
|
|
caching_options() : _key_cache(default_key), _row_cache(default_row) {}
|
|
public:
|
|
|
|
sstring to_sstring() const {
|
|
return json::to_json(std::map<sstring, sstring>({{ "keys", _key_cache }, { "rows_per_partition", _row_cache }}));
|
|
}
|
|
|
|
static caching_options from_sstring(const sstring& str) {
|
|
auto map = json::to_map(str);
|
|
if (map.size() > 2) {
|
|
throw exceptions::configuration_exception("Invalid map: " + str);
|
|
}
|
|
sstring k;
|
|
sstring r;
|
|
if (map.count("keys")) {
|
|
k = map.at("keys");
|
|
} else {
|
|
k = default_key;
|
|
}
|
|
|
|
if (map.count("rows_per_partition")) {
|
|
r = map.at("rows_per_partition");
|
|
} else {
|
|
r = default_row;
|
|
}
|
|
return caching_options(k, r);
|
|
}
|
|
};
|
|
|
|
|
|
|