mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-29 19:21:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
copilot/fix-batchlog-size-check
scylladb/cql3/statements
History
copilot-swe-agent[bot] 91dd15d3bf Fix batch size check to only apply to atomic batches with tests 
The verify_batch_size() check was applied to all batches before determining mutate_atomic, causing unnecessary failures for batches that never touch system.batchlog. Only logged multi-partition batches (mutate_atomic=true) are stored as blobs in system.batchlog and require size validation.

Changed:

* Moved verify_batch_size() call in execute_without_conditions() directly
  into the logged multi-partition branch for clearer intent
* The check is now placed exactly where mutate_atomic=true, making the
  code more intuitive

Result:
Batch Type  Single-Partition  Size Check
LOGGED      false             YES
LOGGED      true              NO
UNLOGGED    N/A               NO

Tests:

* test_unlogged_batch_size_not_checked: Unlogged batch >1024KB succeeds
* test_logged_multi_partition_batch_size_checked: Logged multi-partition batch >1024KB fails
* test_logged_single_partition_batch_size_not_checked: Logged single-partition batch >1024KB succeeds

Fixes #27605

Co-authored-by: mykaul <yaniv.kaul@scylladb.com>
2025-12-15 10:45:29 +02:00
..
raw
cql3: Move vector search select to dedicated class
2025-10-29 08:37:21 +01:00
alter_keyspace_statement.cc
cql3: ks_prop_defs: Expand numeric RF to rack list
2025-10-29 23:32:59 +01:00
alter_keyspace_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
alter_role_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
alter_service_level_statement.cc
cql3: Improve errors when manipulating default service level
2025-11-28 15:32:37 +03:00
alter_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
alter_table_statement.cc
tombstone_gc: don't use 'repair' mode for colocated tables
2025-11-25 09:15:46 +01:00
alter_table_statement.hh
treewide: Move mutation related files to a mutation directory
2025-09-24 13:23:38 +03:00
alter_type_statement.cc
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
alter_type_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
alter_view_statement.cc
tombstone_gc: don't use 'repair' mode for colocated tables
2025-11-25 09:15:46 +01:00
alter_view_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
attach_service_level_statement.cc
cql3: Improve errors when manipulating default service level
2025-11-28 15:32:37 +03:00
attach_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
authentication_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
authentication_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
authorization_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
authorization_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
batch_statement.cc
Fix batch size check to only apply to atomic batches with tests
2025-12-15 10:45:29 +02:00
batch_statement.hh
treewide: Move mutation related files to a mutation directory
2025-09-24 13:23:38 +03:00
bound.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
cas_request.cc
storage: Add cdc options to cas_request::apply
2025-10-09 12:28:10 +02:00
cas_request.hh
storage: Add cdc options to cas_request::apply
2025-10-09 12:28:10 +02:00
cf_prop_defs.cc
tombstone_gc: don't use 'repair' mode for colocated tables
2025-11-25 09:15:46 +01:00
cf_prop_defs.hh
tombstone_gc: don't use 'repair' mode for colocated tables
2025-11-25 09:15:46 +01:00
cf_properties.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
cf_statement.cc
cql3: prevent from empty option use in cf_statement::column_family()
2025-03-31 09:43:22 +03:00
create_aggregate_statement.cc
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
create_aggregate_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
create_function_statement.cc
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
create_function_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
create_index_statement.cc
index: allow vector indexes without rf_rack_valid_keyspces
2025-12-05 09:26:26 +02:00
create_index_statement.hh
index: Set tombstone_gc when creating secondary index
2025-10-20 14:04:45 +02:00
create_keyspace_statement.cc
cql3: remove warning when creating keyspace with tablets
2025-11-03 16:04:37 +01:00
create_keyspace_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
create_role_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
create_service_level_statement.cc
cql3: Improve errors when manipulating default service level
2025-11-28 15:32:37 +03:00
create_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
create_table_statement.cc
tombstone_gc: don't use 'repair' mode for colocated tables
2025-11-25 09:15:46 +01:00
create_table_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
create_type_statement.cc
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
create_type_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
create_view_statement.cc
tombstone_gc: don't use 'repair' mode for colocated tables
2025-11-25 09:15:46 +01:00
create_view_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
delete_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
delete_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
describe_statement.cc
cql3: Produce CREATE MATERIALIZED VIEW statement when describing MV of index
2025-09-03 15:21:37 +02:00
describe_statement.hh
cql3: Use managed_bytes instead of bytes in DESCRIBE
2025-06-30 19:12:14 +02:00
detach_service_level_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
detach_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_aggregate_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_aggregate_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_function_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_function_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_index_statement.cc
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
drop_index_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
drop_keyspace_statement.cc
service/migration_manager: pass storage_proxy to prepare_keyspace_drop_announcement()
2025-08-27 08:55:47 +02:00
drop_keyspace_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_role_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_service_level_statement.cc
cql3: Improve errors when manipulating default service level
2025-11-28 15:32:37 +03:00
drop_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_table_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
drop_table_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
drop_type_statement.cc
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
drop_type_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
drop_view_statement.cc
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
drop_view_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
function_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
function_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
grant_role_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
grant_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
grant_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
index_prop_defs.cc
cql3/statements/index_prop_defs.cc: Remove unused include
2025-10-09 16:01:56 +02:00
index_prop_defs.hh
cql3/statements/index_prop_defs: Mark methods as const-qualified
2025-10-09 15:53:29 +02:00
index_target.cc
custom_index: remove unneeded duplicate of a static string
2025-07-07 13:47:06 +02:00
index_target.hh
custom_index: remove unneeded duplicate of a static string
2025-07-07 13:47:06 +02:00
ks_prop_defs.cc
cql3: reject ALTER KEYSPACE if rf of datacenter with tablets is omitted
2025-11-24 06:36:51 +02:00
ks_prop_defs.hh
cql3: ks_prop_defs: Expand numeric RF to rack list
2025-10-29 23:32:59 +01:00
list_effective_service_level_statement.cc
treewide: Move type related files to a type directory As requested in #22110, moved the files and fixed other includes and build system.
2025-09-17 17:32:19 +03:00
list_effective_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_permissions_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
list_permissions_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_roles_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_service_level_attachments_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
list_service_level_attachments_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_service_level_statement.cc
audit: Add shares support to service level management
2025-01-15 15:01:05 +01:00
list_service_level_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
list_users_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
list_users_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
modification_statement.cc
storage_proxy: cas: take cas_request by raw reference
2025-12-07 16:14:56 +01:00
modification_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
permission_altering_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
permission_altering_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
prepared_statement.hh
transport: implement SCYLLA_USE_METADATA_ID support
2025-05-14 09:59:16 +02:00
property_definitions.cc
locator, cql3: Support rack lists in replication options
2025-10-02 19:42:39 +02:00
property_definitions.hh
locator, cql3: Support rack lists in replication options
2025-10-02 19:42:39 +02:00
prune_materialized_view_statement.cc
mv: allow setting concurrency in PRUNE MATERIALIZED VIEW
2025-11-27 00:02:28 +01:00
prune_materialized_view_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
request_validations.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
revoke_role_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
revoke_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
revoke_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
role-management-statements.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
schema_altering_statement.cc
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
schema_altering_statement.hh
everywhere: use utils::chunked_vector for list of mutations
2025-07-13 19:13:11 +03:00
select_statement.cc
vector_search: Fix ANN query abort on CQL timeout
2025-12-02 01:17:01 +01:00
select_statement.hh
vector_search: Fix ANN query abort on CQL timeout
2025-12-02 01:17:01 +01:00
service_level_statement.cc
audit: Add shares support to service level management
2025-01-15 15:01:05 +01:00
service_level_statement.hh
audit: Add shares support to service level management
2025-01-15 15:01:05 +01:00
sl_prop_defs.cc
treewide: Move type related files to a type directory As requested in #22110, moved the files and fixed other includes and build system.
2025-09-17 17:32:19 +03:00
sl_prop_defs.hh
cql3/statements: update SL statements for workload prioritization
2025-01-02 07:13:34 +01:00
statement_type.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
strongly_consistent_modification_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
strongly_consistent_modification_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
strongly_consistent_select_statement.cc
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
strongly_consistent_select_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
truncate_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
truncate_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00
update_statement.cc
vector_search: remove dependence on cql3
2025-10-21 17:41:55 +03:00
update_statement.hh
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
use_statement.cc
audit: Add support to CQL statements
2025-01-15 11:10:36 +01:00
use_statement.hh
treewide: relicense to ScyllaDB-Source-Available-1.0
2024-12-18 17:45:13 +02:00