91dd15d3bf
The verify_batch_size() check was applied to all batches before determining mutate_atomic, causing unnecessary failures for batches that never touch system.batchlog. Only logged multi-partition batches (mutate_atomic=true) are stored as blobs in system.batchlog and require size validation. Changed: * Moved verify_batch_size() call in execute_without_conditions() directly into the logged multi-partition branch for clearer intent * The check is now placed exactly where mutate_atomic=true, making the code more intuitive Result: Batch Type Single-Partition Size Check LOGGED false YES LOGGED true NO UNLOGGED N/A NO Tests: * test_unlogged_batch_size_not_checked: Unlogged batch >1024KB succeeds * test_logged_multi_partition_batch_size_checked: Logged multi-partition batch >1024KB fails * test_logged_single_partition_batch_size_not_checked: Logged single-partition batch >1024KB succeeds Fixes #27605 Co-authored-by: mykaul <yaniv.kaul@scylladb.com>
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cqlpy - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.