schema_extension allows making invisible changes to system_schema that evade upgrade rollback tests. They appear in system_schema as an encoded blob which reduces serviceability, as they cannot be read. Deprecate it and point users to adding explicit columns in scylla_tables. We could probably make use of the data structure, after we teach it to encode its payload into proper named and typed columns instead of using IDL. Closes scylladb/scylladb#23151
50 lines
1.4 KiB
C++
50 lines
1.4 KiB
C++
/*
|
|
* Copyright 2020-present ScyllaDB
|
|
*/
|
|
/*
|
|
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <map>
|
|
|
|
#include <seastar/core/sstring.hh>
|
|
|
|
#include "bytes_fwd.hh"
|
|
#include "cdc/cdc_options.hh"
|
|
#include "schema/schema.hh"
|
|
#include "serializer_impl.hh"
|
|
|
|
namespace cdc {
|
|
|
|
class cdc_extension : public schema_extension {
|
|
cdc::options _cdc_options;
|
|
public:
|
|
static constexpr auto NAME = "cdc";
|
|
|
|
// cdc_extension was written before schema_extension was deprecated, so support it
|
|
// without warnings
|
|
#pragma clang diagnostic push
|
|
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
|
|
cdc_extension() = default;
|
|
cdc_extension(const options& opts) : _cdc_options(opts) {}
|
|
explicit cdc_extension(std::map<sstring, sstring> tags) : _cdc_options(std::move(tags)) {}
|
|
explicit cdc_extension(const bytes& b) : _cdc_options(cdc_extension::deserialize(b)) {}
|
|
explicit cdc_extension(const sstring& s) {
|
|
throw std::logic_error("Cannot create cdc info from string");
|
|
}
|
|
#pragma clang diagnostic pop
|
|
bytes serialize() const override {
|
|
return ser::serialize_to_buffer<bytes>(_cdc_options.to_map());
|
|
}
|
|
static std::map<sstring, sstring> deserialize(const bytes_view& buffer) {
|
|
return ser::deserialize_from_buffer(buffer, std::type_identity<std::map<sstring, sstring>>());
|
|
}
|
|
const options& get_options() const {
|
|
return _cdc_options;
|
|
}
|
|
};
|
|
|
|
}
|