Files
scylladb/sstables/random_access_reader.cc
copilot-swe-agent[bot] 168e0a40e3 Fix oversized allocation in sstables::parse by using fragmented buffer
This addresses issue where reading summary positions could cause
large contiguous memory allocations (249856 bytes reported).
Added read_exactly_fragmented() method to random_access_reader to
support reading into fragmented buffers, avoiding oversized allocations.

Co-authored-by: mykaul <4655593+mykaul@users.noreply.github.com>
2025-11-06 11:57:10 +00:00

82 lines
2.3 KiB
C++

/*
* Copyright (C) 2020-present ScyllaDB
*/
/*
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
*/
#include <exception>
#include "sstables/random_access_reader.hh"
#include "utils/disk-error-handler.hh"
#include "utils/log.hh"
#include "utils/fragmented_temporary_buffer.hh"
namespace sstables {
extern logging::logger sstlog;
future <temporary_buffer<char>> random_access_reader::read_exactly(size_t n) noexcept {
try {
return _in->read_exactly(n);
} catch (...) {
return current_exception_as_future<temporary_buffer<char>>();
}
}
future<fragmented_temporary_buffer> random_access_reader::read_exactly_fragmented(size_t n) noexcept {
try {
fragmented_temporary_buffer::reader reader;
return reader.read_exactly(*_in, n);
} catch (...) {
return current_exception_as_future<fragmented_temporary_buffer>();
}
}
static future<> close_if_needed(std::unique_ptr<input_stream<char>> in) {
if (!in) {
return make_ready_future<>();
}
return in->close().finally([in = std::move(in)] {});
}
future<> random_access_reader::seek(uint64_t pos) noexcept {
try {
auto tmp = std::make_unique<input_stream<char>>(open_at(pos));
std::swap(tmp, _in);
return close_if_needed(std::move(tmp));
} catch (...) {
return current_exception_as_future();
}
}
future<> random_access_reader::close() noexcept {
return futurize_invoke(close_if_needed, std::move(_in));
}
file_random_access_reader::file_random_access_reader(file f, uint64_t file_size, size_t buffer_size, unsigned read_ahead)
: _file(std::move(f)), _file_size(file_size), _buffer_size(buffer_size), _read_ahead(read_ahead) {
set(open_at(0));
}
input_stream<char> file_random_access_reader::open_at(uint64_t pos) {
auto len = _file_size - pos;
file_input_stream_options options;
options.buffer_size = _buffer_size;
options.read_ahead = _read_ahead;
return make_file_input_stream(_file, pos, len, std::move(options));
}
future<> file_random_access_reader::close() noexcept {
return random_access_reader::close().finally([this] {
return _file.close().handle_exception([save = _file](auto ep) {
sstlog.warn("sstable close failed: {}", ep);
general_disk_error();
});
});
}
}