mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-21 17:10:35 +00:00
86ed627fc4
The namespace usage in this directory is very inconsistent, with files
and classes scattered in:
* global namespace
* namespace compaction
* namespace sstables
With cases, where all three used in the same file. This code used to
live in sstables/ and some of it still retains namespace sstables as a
heritage of that time. The mismatch between the dir (future module) and
the namespace used is confusing, so finish the migration and move all
code in compaction/ to namespace compaction too.
This patch, although large, is mechanic and only the following kind of
changes are made:
* replace namespace sstable {} with namespace compaction {}
* add namespace compaction {}
* drop/add sstables::
* drop/add compaction::
* move around forward-declarations so they are in the correct namespace
context
This refactoring revealed some awkward leftover coupling between
sstables and compaction, in sstables/sstable_set.cc, where the
make_sstable_set() methods of compaction strategies are implemented.
103 lines
4.8 KiB
C++
103 lines
4.8 KiB
C++
/*
|
|
* Copyright (C) 2017-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "compaction_strategy_impl.hh"
|
|
#include "sstables/shared_sstable.hh"
|
|
|
|
namespace compaction {
|
|
|
|
class size_tiered_backlog_tracker;
|
|
|
|
class size_tiered_compaction_strategy_options {
|
|
public:
|
|
static constexpr uint64_t DEFAULT_MIN_SSTABLE_SIZE = 50L * 1024L * 1024L;
|
|
static constexpr double DEFAULT_BUCKET_LOW = 0.5;
|
|
static constexpr double DEFAULT_BUCKET_HIGH = 1.5;
|
|
static constexpr double DEFAULT_COLD_READS_TO_OMIT = 0.05;
|
|
static constexpr auto MIN_SSTABLE_SIZE_KEY = "min_sstable_size";
|
|
static constexpr auto BUCKET_LOW_KEY = "bucket_low";
|
|
static constexpr auto BUCKET_HIGH_KEY = "bucket_high";
|
|
static constexpr auto COLD_READS_TO_OMIT_KEY = "cold_reads_to_omit";
|
|
private:
|
|
uint64_t min_sstable_size = DEFAULT_MIN_SSTABLE_SIZE;
|
|
double bucket_low = DEFAULT_BUCKET_LOW;
|
|
double bucket_high = DEFAULT_BUCKET_HIGH;
|
|
double cold_reads_to_omit = DEFAULT_COLD_READS_TO_OMIT;
|
|
public:
|
|
size_tiered_compaction_strategy_options(const std::map<sstring, sstring>& options);
|
|
|
|
size_tiered_compaction_strategy_options();
|
|
size_tiered_compaction_strategy_options(const size_tiered_compaction_strategy_options&) = default;
|
|
size_tiered_compaction_strategy_options(size_tiered_compaction_strategy_options&&) = default;
|
|
size_tiered_compaction_strategy_options& operator=(const size_tiered_compaction_strategy_options&) = default;
|
|
size_tiered_compaction_strategy_options& operator=(size_tiered_compaction_strategy_options&&) = default;
|
|
|
|
static void validate(const std::map<sstring, sstring>& options, std::map<sstring, sstring>& unchecked_options);
|
|
|
|
friend class size_tiered_compaction_strategy;
|
|
};
|
|
|
|
class size_tiered_compaction_strategy : public compaction_strategy_impl {
|
|
size_tiered_compaction_strategy_options _options;
|
|
|
|
// Return a list of pair of shared_sstable and its respective size.
|
|
static std::vector<std::pair<sstables::shared_sstable, uint64_t>> create_sstable_and_length_pairs(const std::vector<sstables::shared_sstable>& sstables);
|
|
|
|
// Group files of similar size into buckets.
|
|
static std::vector<std::vector<sstables::shared_sstable>> get_buckets(const std::vector<sstables::shared_sstable>& sstables, size_tiered_compaction_strategy_options options);
|
|
|
|
std::vector<std::vector<sstables::shared_sstable>> get_buckets(const std::vector<sstables::shared_sstable>& sstables) const;
|
|
|
|
// Maybe return a bucket of sstables to compact
|
|
std::vector<sstables::shared_sstable>
|
|
most_interesting_bucket(std::vector<std::vector<sstables::shared_sstable>> buckets, unsigned min_threshold, unsigned max_threshold);
|
|
|
|
static bool is_bucket_interesting(const std::vector<sstables::shared_sstable>& bucket, int min_threshold) {
|
|
return bucket.size() >= size_t(min_threshold);
|
|
}
|
|
|
|
bool is_any_bucket_interesting(const std::vector<std::vector<sstables::shared_sstable>>& buckets, int min_threshold) const {
|
|
return std::ranges::any_of(buckets, [&] (const auto& bucket) {
|
|
return this->is_bucket_interesting(bucket, min_threshold);
|
|
});
|
|
}
|
|
public:
|
|
size_tiered_compaction_strategy() = default;
|
|
|
|
size_tiered_compaction_strategy(const std::map<sstring, sstring>& options);
|
|
explicit size_tiered_compaction_strategy(const size_tiered_compaction_strategy_options& options);
|
|
static void validate_options(const std::map<sstring, sstring>& options, std::map<sstring, sstring>& unchecked_options);
|
|
|
|
virtual future<compaction_descriptor> get_sstables_for_compaction(compaction_group_view& table_s, strategy_control& control) override;
|
|
|
|
virtual std::vector<compaction_descriptor> get_cleanup_compaction_jobs(compaction_group_view& table_s, std::vector<sstables::shared_sstable> candidates) const override;
|
|
|
|
static int64_t estimated_pending_compactions(const std::vector<sstables::shared_sstable>& sstables,
|
|
int min_threshold, int max_threshold, size_tiered_compaction_strategy_options options);
|
|
virtual future<int64_t> estimated_pending_compactions(compaction_group_view& table_s) const override;
|
|
|
|
virtual compaction_strategy_type type() const override {
|
|
return compaction_strategy_type::size_tiered;
|
|
}
|
|
|
|
// Return the most interesting bucket for a set of sstables
|
|
static std::vector<sstables::shared_sstable>
|
|
most_interesting_bucket(const std::vector<sstables::shared_sstable>& candidates, int min_threshold, int max_threshold,
|
|
size_tiered_compaction_strategy_options options = {});
|
|
|
|
virtual std::unique_ptr<compaction_backlog_tracker::impl> make_backlog_tracker() const override;
|
|
|
|
virtual compaction_descriptor get_reshaping_job(std::vector<sstables::shared_sstable> input, schema_ptr schema, reshape_config cfg) const override;
|
|
|
|
friend class ::compaction::size_tiered_backlog_tracker;
|
|
};
|
|
|
|
}
|