Files
scylladb/test/perf/perf_mutation_readers.cc
Benny Halevy 3feb759943 everywhere: use utils::chunked_vector for list of mutations
Currently, we use std::vector<*mutation> to keep
a list of mutations for processing.
This can lead to large allocation, e.g. when the vector
size is a function of the number of tables.

Use a chunked vector instead to prevent oversized allocations.

`perf-simple-query --smp 1` results obtained for fixed 400MHz frequency
and PGO disabled:

Before (read path):
```
enable-cache=1
Running test with config: {partitions=10000, concurrency=100, mode=read, query_single_key=no, counters=no}
Disabling auto compaction
Creating 10000 partitions...

89055.97 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.2 tasks/op,   39417 insns/op,   18003 cycles/op,        0 errors)
103372.72 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.2 tasks/op,   39380 insns/op,   17300 cycles/op,        0 errors)
98942.27 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.2 tasks/op,   39413 insns/op,   17336 cycles/op,        0 errors)
103752.93 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.2 tasks/op,   39407 insns/op,   17252 cycles/op,        0 errors)
102516.77 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.2 tasks/op,   39403 insns/op,   17288 cycles/op,        0 errors)
throughput:
	mean=   99528.13 standard-deviation=6155.71
	median= 102516.77 median-absolute-deviation=3844.59
	maximum=103752.93 minimum=89055.97
instructions_per_op:
	mean=   39403.99 standard-deviation=14.25
	median= 39406.75 median-absolute-deviation=9.30
	maximum=39416.63 minimum=39380.39
cpu_cycles_per_op:
	mean=   17435.81 standard-deviation=318.24
	median= 17300.40 median-absolute-deviation=147.59
	maximum=18002.53 minimum=17251.75
```

After (read path)
```
enable-cache=1
Running test with config: {partitions=10000, concurrency=100, mode=read, query_single_key=no, counters=no}
Disabling auto compaction
Creating 10000 partitions...
59755.04 tps ( 66.2 allocs/op,   0.0 logallocs/op,  14.2 tasks/op,   39466 insns/op,   22834 cycles/op,        0 errors)
71854.16 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.2 tasks/op,   39417 insns/op,   17883 cycles/op,        0 errors)
82149.45 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.2 tasks/op,   39411 insns/op,   17409 cycles/op,        0 errors)
49640.04 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.3 tasks/op,   39474 insns/op,   19975 cycles/op,        0 errors)
54963.22 tps ( 66.1 allocs/op,   0.0 logallocs/op,  14.3 tasks/op,   39474 insns/op,   18235 cycles/op,        0 errors)
throughput:
	mean=   63672.38 standard-deviation=13195.12
	median= 59755.04 median-absolute-deviation=8709.16
	maximum=82149.45 minimum=49640.04
instructions_per_op:
	mean=   39448.38 standard-deviation=31.60
	median= 39466.17 median-absolute-deviation=25.75
	maximum=39474.12 minimum=39411.42
cpu_cycles_per_op:
	mean=   19267.01 standard-deviation=2217.03
	median= 18234.80 median-absolute-deviation=1384.25
	maximum=22834.26 minimum=17408.67
```

`perf-simple-query --smp 1 --write` results obtained for fixed 400MHz frequency
and PGO disabled:

Before (write path):
```
enable-cache=1
Running test with config: {partitions=10000, concurrency=100, mode=write, query_single_key=no, counters=no}
Disabling auto compaction
63736.96 tps ( 59.4 allocs/op,  16.4 logallocs/op,  14.3 tasks/op,   49667 insns/op,   19924 cycles/op,        0 errors)
64109.41 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   49992 insns/op,   20084 cycles/op,        0 errors)
56950.47 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   50005 insns/op,   20501 cycles/op,        0 errors)
44858.42 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   50014 insns/op,   21947 cycles/op,        0 errors)
28592.87 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   50027 insns/op,   27659 cycles/op,        0 errors)
throughput:
	mean=   51649.63 standard-deviation=15059.74
	median= 56950.47 median-absolute-deviation=12087.33
	maximum=64109.41 minimum=28592.87
instructions_per_op:
	mean=   49941.18 standard-deviation=153.76
	median= 50005.24 median-absolute-deviation=73.01
	maximum=50027.07 minimum=49667.05
cpu_cycles_per_op:
	mean=   22023.01 standard-deviation=3249.92
	median= 20500.74 median-absolute-deviation=1938.76
	maximum=27658.75 minimum=19924.32
```

After (write path)
```
enable-cache=1
Running test with config: {partitions=10000, concurrency=100, mode=write, query_single_key=no, counters=no}
Disabling auto compaction
53395.93 tps ( 59.4 allocs/op,  16.5 logallocs/op,  14.3 tasks/op,   50326 insns/op,   21252 cycles/op,        0 errors)
46527.83 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   50704 insns/op,   21555 cycles/op,        0 errors)
55846.30 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   50731 insns/op,   21060 cycles/op,        0 errors)
55669.30 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   50735 insns/op,   21521 cycles/op,        0 errors)
52130.17 tps ( 59.3 allocs/op,  16.0 logallocs/op,  14.3 tasks/op,   50757 insns/op,   21334 cycles/op,        0 errors)
throughput:
	mean=   52713.91 standard-deviation=3795.38
	median= 53395.93 median-absolute-deviation=2955.40
	maximum=55846.30 minimum=46527.83
instructions_per_op:
	mean=   50650.57 standard-deviation=182.46
	median= 50731.38 median-absolute-deviation=84.09
	maximum=50756.62 minimum=50325.87
cpu_cycles_per_op:
	mean=   21344.42 standard-deviation=202.86
	median= 21334.00 median-absolute-deviation=176.37
	maximum=21554.61 minimum=21060.24
```

Fixes #24815

Improvement for rare corner cases. No backport required

Signed-off-by: Benny Halevy <bhalevy@scylladb.com>

Closes scylladb/scylladb#24919
2025-07-13 19:13:11 +03:00

452 lines
16 KiB
C++

/*
* Copyright (C) 2018-present ScyllaDB
*/
/*
* SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
*/
#include <seastar/core/sleep.hh>
#include <seastar/testing/perf_tests.hh>
#include <seastar/util/closeable.hh>
#include "test/lib/simple_schema.hh"
#include "test/lib/simple_position_reader_queue.hh"
#include "test/perf/perf.hh"
#include "readers/from_mutations.hh"
#include "readers/mutation_fragment_v1_stream.hh"
#include "readers/empty.hh"
#include "readers/combined.hh"
#include "replica/memtable.hh"
namespace tests {
class combined {
mutable simple_schema _schema;
perf::reader_concurrency_semaphore_wrapper _semaphore;
reader_permit _permit;
utils::chunked_vector<mutation> _one_row;
utils::chunked_vector<mutation> _single;
std::vector<utils::chunked_vector<mutation>> _disjoint_interleaved;
std::vector<utils::chunked_vector<mutation>> _disjoint_ranges;
std::vector<utils::chunked_vector<mutation>> _overlapping_partitions_disjoint_rows;
private:
static utils::chunked_vector<mutation> create_one_row(simple_schema&, reader_permit);
static utils::chunked_vector<mutation> create_single_stream(simple_schema&, reader_permit);
static std::vector<utils::chunked_vector<mutation>> create_disjoint_interleaved_streams(simple_schema&, reader_permit);
static std::vector<utils::chunked_vector<mutation>> create_disjoint_ranges_streams(simple_schema&, reader_permit);
static std::vector<utils::chunked_vector<mutation>> create_overlapping_partitions_disjoint_rows_streams(simple_schema&, reader_permit);
protected:
simple_schema& schema() const { return _schema; }
reader_permit permit() const { return _permit; }
const utils::chunked_vector<mutation>& one_row_stream() const { return _one_row; }
const utils::chunked_vector<mutation>& single_stream() const { return _single; }
const std::vector<utils::chunked_vector<mutation>>& disjoint_interleaved_streams() const {
return _disjoint_interleaved;
}
const std::vector<utils::chunked_vector<mutation>>& disjoint_ranges_streams() const {
return _disjoint_ranges;
}
const std::vector<utils::chunked_vector<mutation>>& overlapping_partitions_disjoint_rows_streams() const {
return _overlapping_partitions_disjoint_rows;
}
future<> consume_all(mutation_reader mr) const;
public:
combined()
: _semaphore("combined")
, _permit(_semaphore.make_permit())
, _one_row(create_one_row(_schema, _permit))
, _single(create_single_stream(_schema, _permit))
, _disjoint_interleaved(create_disjoint_interleaved_streams(_schema, _permit))
, _disjoint_ranges(create_disjoint_ranges_streams(_schema, _permit))
, _overlapping_partitions_disjoint_rows(create_overlapping_partitions_disjoint_rows_streams(_schema, _permit))
{ }
};
utils::chunked_vector<mutation> combined::create_one_row(simple_schema& s, reader_permit permit)
{
return s.make_pkeys(1)
| std::views::transform([&] (auto& dkey) {
auto m = mutation(s.schema(), dkey);
m.apply(s.make_row(permit, s.make_ckey(0), "value"));
return m;
})
| std::ranges::to<utils::chunked_vector<mutation>>();
}
utils::chunked_vector<mutation> combined::create_single_stream(simple_schema& s, reader_permit permit)
{
return s.make_pkeys(32)
| std::views::transform([&] (auto& dkey) {
auto m = mutation(s.schema(), dkey);
for (auto i = 0; i < 16; i++) {
m.apply(s.make_row(permit, s.make_ckey(i), "value"));
}
return m;
})
| std::ranges::to<utils::chunked_vector<mutation>>();
}
std::vector<utils::chunked_vector<mutation>> combined::create_disjoint_interleaved_streams(simple_schema& s, reader_permit permit)
{
auto base = create_single_stream(s, permit);
std::vector<utils::chunked_vector<mutation>> mss;
for (auto i = 0; i < 4; i++) {
mss.emplace_back(
base
| std::views::drop(i)
| std::views::take(base.size() - i)
| std::views::stride(4)
| std::ranges::to<utils::chunked_vector<mutation>>()
);
}
return mss;
}
std::vector<utils::chunked_vector<mutation>> combined::create_disjoint_ranges_streams(simple_schema& s, reader_permit permit)
{
auto base = create_single_stream(s, permit);
std::vector<utils::chunked_vector<mutation>> mss;
auto slice = base.size() / 4;
for (auto i = 0; i < 4; i++) {
mss.emplace_back(
base
| std::views::drop(i * slice)
| std::views::take(std::min((i + 1) * slice, base.size()) - i * slice)
| std::ranges::to<utils::chunked_vector<mutation>>()
);
}
return mss;
}
std::vector<utils::chunked_vector<mutation>> combined::create_overlapping_partitions_disjoint_rows_streams(simple_schema& s, reader_permit permit) {
auto keys = s.make_pkeys(4);
std::vector<utils::chunked_vector<mutation>> mss;
for (int i = 0; i < 4; i++) {
mss.emplace_back(keys
| std::views::transform([&] (auto& dkey) {
auto m = mutation(s.schema(), dkey);
for (int j = 0; j < 32; j++) {
m.apply(s.make_row(permit, s.make_ckey(32 * i + j), "value"));
}
return m;
})
| std::ranges::to<utils::chunked_vector<mutation>>());
}
return mss;
}
future<> combined::consume_all(mutation_reader mr) const
{
return with_closeable(mutation_fragment_v1_stream(std::move(mr)), [] (auto& mr) {
perf_tests::start_measuring_time();
return mr.consume_pausable([] (mutation_fragment mf) {
perf_tests::do_not_optimize(mf);
return stop_iteration::no;
}).then([] {
perf_tests::stop_measuring_time();
});
});
}
PERF_TEST_F(combined, one_mutation)
{
std::vector<mutation_reader> mrs;
mrs.emplace_back(make_mutation_reader_from_mutations(schema().schema(), permit(), one_row_stream()[0]));
return consume_all(make_combined_reader(schema().schema(), permit(), std::move(mrs)));
}
PERF_TEST_F(combined, one_row)
{
std::vector<mutation_reader> mrs;
mrs.emplace_back(make_mutation_reader_from_mutations(schema().schema(), permit(), one_row_stream()));
return consume_all(make_combined_reader(schema().schema(), permit(), std::move(mrs)));
}
PERF_TEST_F(combined, single_active)
{
std::vector<mutation_reader> mrs;
mrs.reserve(4);
mrs.emplace_back(make_mutation_reader_from_mutations(schema().schema(), permit(), single_stream()));
for (auto i = 0; i < 3; i++) {
mrs.emplace_back(make_empty_mutation_reader(schema().schema(), permit()));
}
return consume_all(make_combined_reader(schema().schema(), permit(), std::move(mrs)));
}
PERF_TEST_F(combined, many_overlapping)
{
std::vector<mutation_reader> mrs;
mrs.reserve(4);
for (auto i = 0; i < 4; i++) {
mrs.emplace_back(make_mutation_reader_from_mutations(schema().schema(), permit(), single_stream()));
}
return consume_all(make_combined_reader(schema().schema(), permit(), std::move(mrs)));
}
PERF_TEST_F(combined, disjoint_interleaved)
{
return consume_all(make_combined_reader(schema().schema(), permit(),
disjoint_interleaved_streams()
| std::views::transform([this] (auto&& ms) {
return schema().schema(), make_mutation_reader_from_mutations(schema().schema(), permit(), std::move(ms));
})
| std::ranges::to<std::vector<mutation_reader>>()
));
}
PERF_TEST_F(combined, disjoint_ranges)
{
return consume_all(make_combined_reader(schema().schema(), permit(),
disjoint_ranges_streams()
| std::views::transform([this] (auto&& ms) {
return make_mutation_reader_from_mutations(schema().schema(), permit(), std::move(ms));
})
| std::ranges::to<std::vector<mutation_reader>>()
));
}
PERF_TEST_F(combined, overlapping_partitions_disjoint_rows)
{
return consume_all(make_combined_reader(schema().schema(), permit(),
overlapping_partitions_disjoint_rows_streams()
| std::views::transform([this] (auto&& ms) {
return make_mutation_reader_from_mutations(schema().schema(), permit(), std::move(ms));
})
| std::ranges::to<std::vector<mutation_reader>>()
));
}
struct mutation_bounds {
mutation m;
position_in_partition lower;
position_in_partition upper;
};
class clustering_combined {
mutable simple_schema _schema;
perf::reader_concurrency_semaphore_wrapper _semaphore;
reader_permit _permit;
std::vector<mutation_bounds> _almost_disjoint_ranges;
private:
static std::vector<mutation_bounds> create_almost_disjoint_ranges(simple_schema&, reader_permit);
protected:
simple_schema& schema() const { return _schema; }
reader_permit permit() const { return _permit; }
const std::vector<mutation_bounds>& almost_disjoint_clustering_ranges() const {
return _almost_disjoint_ranges;
}
future<size_t> consume_all(mutation_reader mr) const;
public:
clustering_combined()
: _semaphore("clustering_combined")
, _permit(_semaphore.make_permit())
, _almost_disjoint_ranges(create_almost_disjoint_ranges(_schema, _permit))
{ }
};
std::vector<mutation_bounds> clustering_combined::create_almost_disjoint_ranges(simple_schema& s, reader_permit permit) {
auto pk = s.make_pkey();
std::vector<mutation_bounds> mbs;
for (int i = 0; i < 150; i += 30) {
auto m = mutation(s.schema(), pk);
for (int j = 0; j < 32; ++j) {
m.apply(s.make_row(permit, s.make_ckey(i + j), "value"));
}
mbs.push_back(mutation_bounds{std::move(m),
position_in_partition::for_key(s.make_ckey(i)),
position_in_partition::for_key(s.make_ckey(i + 31))});
}
return mbs;
}
future<size_t> clustering_combined::consume_all(mutation_reader mr) const
{
return do_with(mutation_fragment_v1_stream(std::move(mr)), size_t(0), [] (auto& mr, size_t& num_mfs) {
perf_tests::start_measuring_time();
return mr.consume_pausable([&num_mfs] (mutation_fragment mf) {
++num_mfs;
perf_tests::do_not_optimize(mf);
return stop_iteration::no;
}).then([&num_mfs] {
perf_tests::stop_measuring_time();
return num_mfs;
}).finally([&mr] {
return mr.close();
});
});
}
PERF_TEST_F(clustering_combined, ranges_generic)
{
return consume_all(make_combined_reader(schema().schema(), permit(),
almost_disjoint_clustering_ranges()
| std::views::transform([this] (auto&& mb) {
return make_mutation_reader_from_mutations(schema().schema(), permit(), std::move(mb.m));
})
| std::ranges::to<std::vector<mutation_reader>>()
));
}
PERF_TEST_F(clustering_combined, ranges_specialized)
{
auto rbs = almost_disjoint_clustering_ranges() | std::views::transform([this] (auto&& mb) {
return reader_bounds{
make_mutation_reader_from_mutations(schema().schema(), permit(), std::move(mb.m)),
std::move(mb.lower), std::move(mb.upper)};
}) | std::ranges::to<std::vector<reader_bounds>>();
auto q = std::make_unique<simple_position_reader_queue>(*schema().schema(), std::move(rbs));
return consume_all(make_clustering_combined_reader(
schema().schema(), permit(), streamed_mutation::forwarding::no, std::move(q)));
}
class memtable {
static constexpr size_t partition_count = 1000;
perf::reader_concurrency_semaphore_wrapper _semaphore;
std::optional<dht::partition_range> _partition_range;
protected:
static constexpr size_t row_count = 50;
reader_permit _permit;
mutable simple_schema _schema;
std::vector<dht::decorated_key> _dkeys;
public:
memtable()
: _semaphore(__FILE__)
, _permit(_semaphore.make_permit())
, _dkeys(_schema.make_pkeys(partition_count))
{}
protected:
schema_ptr schema() const { return _schema.schema(); }
reader_permit permit() const { return _permit; }
const dht::partition_range& single_partition_range() {
auto& dk = _dkeys[_dkeys.size() / 2];
_partition_range.emplace(dht::partition_range::make_singular(dk));
return *_partition_range;
}
const dht::partition_range& multi_partition_range(size_t n) {
auto start_idx = (_dkeys.size() - n) / 2;
auto& start_dk = _dkeys[start_idx];
auto& end_dk = _dkeys[start_idx + n];
_partition_range.emplace(dht::partition_range::make(dht::ring_position(start_dk),
{dht::ring_position(end_dk), false}));
return *_partition_range;
}
future<> consume_all(mutation_reader mr) const {
return with_closeable(std::move(mr), [] (auto& mr) {
return mr.consume_pausable([] (mutation_fragment_v2 mf) {
perf_tests::do_not_optimize(mf);
return stop_iteration::no;
});
});
}
};
class memtable_single_row : public memtable {
lw_shared_ptr<replica::memtable> _mt;
public:
memtable_single_row()
: _mt(make_lw_shared<replica::memtable>(schema()))
{
std::ranges::for_each(
_dkeys
| std::views::transform([&] (auto& dkey) {
auto m = mutation(schema(), dkey);
m.apply(_schema.make_row(_permit, _schema.make_ckey(0), "value"));
return m;
}),
[&] (mutation m) {
_mt->apply(m);
}
);
}
protected:
replica::memtable& mt() { return *_mt; }
};
PERF_TEST_F(memtable_single_row, one_partition)
{
return consume_all(mt().make_mutation_reader(schema(), permit(), single_partition_range()));
}
PERF_TEST_F(memtable_single_row, many_partitions)
{
return consume_all(mt().make_mutation_reader(schema(), permit(), multi_partition_range(25)));
}
class memtable_multi_row : public memtable {
lw_shared_ptr<replica::memtable> _mt;
public:
memtable_multi_row()
: _mt(make_lw_shared<replica::memtable>(_schema.schema()))
{
std::ranges::for_each(
_dkeys
| std::views::transform([&] (auto& dkey) {
auto m = mutation(_schema.schema(), dkey);
for (auto i = 0u; i < row_count; i++) {
m.apply(_schema.make_row(_permit, _schema.make_ckey(i), "value"));
}
return m;
}),
[&] (mutation m) {
_mt->apply(m);
}
);
}
protected:
replica::memtable& mt() { return *_mt; }
};
PERF_TEST_F(memtable_multi_row, one_partition)
{
return consume_all(mt().make_mutation_reader(schema(), permit(), single_partition_range()));
}
PERF_TEST_F(memtable_multi_row, many_partitions)
{
return consume_all(mt().make_mutation_reader(schema(), permit(), multi_partition_range(25)));
}
class memtable_large_partition : public memtable {
lw_shared_ptr<replica::memtable> _mt;
public:
memtable_large_partition()
: _mt(make_lw_shared<replica::memtable>(_schema.schema()))
{
std::ranges::for_each(
_dkeys
| std::views::transform([&] (auto& dkey) {
auto m = mutation(_schema.schema(), dkey);
// Make sure the partition fills buffers in flat mutation reader multiple times
for (auto i = 0u; i < 8 * 1024; i++) {
m.apply(_schema.make_row(_permit, _schema.make_ckey(i), "value"));
}
return m;
}),
[&] (mutation m) {
_mt->apply(m);
}
);
}
protected:
replica::memtable& mt() { return *_mt; }
};
PERF_TEST_F(memtable_large_partition, one_partition)
{
return consume_all(mt().make_mutation_reader(schema(), permit(), single_partition_range()));
}
PERF_TEST_F(memtable_large_partition, many_partitions)
{
return consume_all(mt().make_mutation_reader(schema(), permit(), multi_partition_range(25)));
}
}