ead9961783
Switch vector dimension handling to fixed-width `uint32_t` type, update parsing/validation, and add boundary tests. The dimension is parsed as `unsigned long` at first which is guaranteed to be **at least** 32-bit long, which is safe to downcast to `uint32_t`. Move `MAX_VECTOR_DIMENSION` from `cql3_type::raw_vector` to `cql3_type` to ensure public visibility for checks outside the class. Add tests to verify the type boundaries. Fixes: https://scylladb.atlassian.net/browse/SCYLLADB-223 Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com> Co-authored-by: Dawid Pawlik <dawid.pawlik@scylladb.com> Closes scylladb/scylladb#28762
77 lines
2.3 KiB
C++
77 lines
2.3 KiB
C++
/*
|
|
* Copyright (C) 2014-present ScyllaDB
|
|
*
|
|
* Modified by ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: (LicenseRef-ScyllaDB-Source-Available-1.0 and Apache-2.0)
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include "column_specification.hh"
|
|
#include "data_dictionary/data_dictionary.hh"
|
|
|
|
namespace cql3 {
|
|
|
|
class assignment_testable {
|
|
public:
|
|
virtual ~assignment_testable() {}
|
|
|
|
enum class test_result {
|
|
EXACT_MATCH,
|
|
WEAKLY_ASSIGNABLE,
|
|
NOT_ASSIGNABLE,
|
|
};
|
|
|
|
struct vector_test_result {
|
|
test_result result;
|
|
std::optional<vector_dimension_t> dimension_opt;
|
|
};
|
|
|
|
static bool is_assignable(test_result tr) {
|
|
return tr != test_result::NOT_ASSIGNABLE;
|
|
}
|
|
|
|
static bool is_exact_match(test_result tr) {
|
|
return tr == test_result::EXACT_MATCH;
|
|
}
|
|
|
|
/**
|
|
* @return whether this object can be assigned to the provided receiver. We distinguish
|
|
* between 3 values:
|
|
* - EXACT_MATCH if this object is exactly of the type expected by the receiver
|
|
* - WEAKLY_ASSIGNABLE if this object is not exactly the expected type but is assignable nonetheless
|
|
* - NOT_ASSIGNABLE if it's not assignable
|
|
* Most caller should just call the isAssignable() method on the result, though functions have a use for
|
|
* testing "strong" equality to decide the most precise overload to pick when multiple could match.
|
|
*/
|
|
virtual test_result test_assignment(data_dictionary::database db, const sstring& keyspace, const schema* schema_opt, const column_specification& receiver) const = 0;
|
|
|
|
virtual vector_test_result test_assignment_any_size_float_vector() const = 0;
|
|
|
|
virtual std::optional<data_type> assignment_testable_type_opt() const = 0;
|
|
|
|
// for error reporting
|
|
virtual sstring assignment_testable_source_context() const = 0;
|
|
};
|
|
|
|
inline bool is_assignable(assignment_testable::test_result tr) {
|
|
return assignment_testable::is_assignable(tr);
|
|
}
|
|
|
|
inline bool is_exact_match(assignment_testable::test_result tr) {
|
|
return assignment_testable::is_exact_match(tr);
|
|
}
|
|
|
|
}
|
|
|
|
template <>
|
|
struct fmt::formatter<cql3::assignment_testable> {
|
|
constexpr auto parse(format_parse_context& ctx) { return ctx.begin(); }
|
|
auto format(const cql3::assignment_testable& at, fmt::format_context& ctx) const {
|
|
return fmt::format_to(ctx.out(), "{}", at.assignment_testable_source_context());
|
|
}
|
|
};
|