Files
scylladb/dist/common/scripts/scylla_cpuset_setup
Yaniv Michael Kaul af8eaa9ea5 scripts: fixes flagged by CodeQL/PyLens
Unused imports, unused variables and such.
Initially, there were no functional changes, just to get rid of some standard CodeQL warnings.

I've then broken the CI, as apparently there's a install time(!?) Python script creation for the sole purpose of product
naming. I changed it - we have it in etcdir, as SCYLLA-PRODUCT-FILE.
So added (copied from a different script) a get_product() helper function in scylla_util.py and used it instead.

While at it, also fixed the too broad import from scylla_util, which 'forced' me to also fix other specific imports (such as shutil).

Improvement - no need to backport.
Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>

Closes scylladb/scylladb#27883
2026-01-09 15:13:12 +02:00

47 lines
1.5 KiB
Python
Executable File

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
#
# Copyright 2018-present ScyllaDB
#
#
# SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
import os
import sys
import argparse
from scylla_util import is_container, sysconfig_parser
if __name__ == '__main__':
if not is_container() and os.getuid() > 0:
print('Requires root permission.')
sys.exit(1)
parser = argparse.ArgumentParser(description='Configure cpuset configuration for Scylla.')
parser.add_argument('--cpuset',
help='CPUs to use (in cpuset(7) format; default: all))')
parser.add_argument('--smp',
help='number of threads (default: one per CPU)')
args = parser.parse_args()
if not args.cpuset and not args.smp:
parser.print_help()
sys.exit(1)
cpuset = smp = None
try:
cfg = sysconfig_parser('/etc/scylla.d/cpuset.conf')
line = cfg.get('CPUSET')
cpuset_args = parser.parse_args(line.split())
cpuset = cpuset_args.cpuset
smp = cpuset_args.smp
except:
pass
if cpuset != args.cpuset or smp != args.smp:
if os.path.exists('/etc/scylla.d/perftune.yaml'):
os.remove('/etc/scylla.d/perftune.yaml')
cfg.set('CPUSET', '{cpuset}{smp}'.format( \
cpuset='--cpuset {} '.format(args.cpuset) if args.cpuset else '', \
smp='--smp {} '.format(args.smp) if args.smp else '' \
))
cfg.commit()