Files
scylladb/dist/common/scripts/scylla_rsyslog_setup
Yaniv Michael Kaul af8eaa9ea5 scripts: fixes flagged by CodeQL/PyLens
Unused imports, unused variables and such.
Initially, there were no functional changes, just to get rid of some standard CodeQL warnings.

I've then broken the CI, as apparently there's a install time(!?) Python script creation for the sole purpose of product
naming. I changed it - we have it in etcdir, as SCYLLA-PRODUCT-FILE.
So added (copied from a different script) a get_product() helper function in scylla_util.py and used it instead.

While at it, also fixed the too broad import from scylla_util, which 'forced' me to also fix other specific imports (such as shutil).

Improvement - no need to backport.
Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>

Closes scylladb/scylladb#27883
2026-01-09 15:13:12 +02:00

31 lines
1.0 KiB
Python
Executable File

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
#
# Copyright 2020-present ScyllaDB
#
#
# SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
import os
import sys
import argparse
from scylla_util import systemd_unit
def update_rsysconf(rsyslog_server):
if ':' not in rsyslog_server:
rsyslog_server = rsyslog_server + ':1514'
with open('/etc/rsyslog.d/scylla.conf', 'w') as f:
f.write("if $programname == 'scylla' then @@{};RSYSLOG_SyslogProtocol23Format\n".format(rsyslog_server))
systemd_unit('rsyslog.service').restart()
if __name__ == '__main__':
if os.getuid() > 0:
print('Requires root permission.')
sys.exit(1)
parser = argparse.ArgumentParser(description='Updating rsyslog to send logs to a remote server.')
parser.add_argument('--remote-server', required=True,
help='specify remote rsyslog server, use ip:port format. If not port is included, Scylla-Monitoring port will be used')
args = parser.parse_args()
update_rsysconf(args.remote_server)