Files
scylladb/locator/token_metadata.hh
Petr Gusev e39f4b399c token_metadata: improve stale versions diagnostics
Before waiting on stale_versions_in_use(), we log the stale versions
the barrier_and_drain handler will wait for, along with the number of
token_metadata references representing each version.
To achieve this, we store a pointer to token_metadata in
version_tracker, traverse the _trackers list, and output all items
with a version smaller than the latest. Since token_metadata
contains the version_tracker instance, it is guaranteed to remain
alive during traversal. To count references, token_metadata now
inherits from enable_lw_shared_from_this.

This helps diagnose tablet migration stalls and allows more
deterministic tests: when a barrier is expected to block, we can
verify that the log contains the expected stale versions rather
than checking that the barrier_and_drain is blocked on
stale_versions_in_use() for a fixed amount of time.
2026-02-16 08:57:42 +01:00

507 lines
19 KiB
C++

/*
*
* Modified by ScyllaDB
* Copyright (C) 2015-present ScyllaDB
*/
/*
* SPDX-License-Identifier: (LicenseRef-ScyllaDB-Source-Available-1.0 and Apache-2.0)
*/
#pragma once
#include <functional>
#include <unordered_set>
#include <unordered_map>
#include "gms/inet_address.hh"
#include "dht/ring_position.hh"
#include <optional>
#include <memory>
#include <boost/icl/interval.hpp>
#include "utils/interval.hh"
#include <seastar/core/shared_future.hh>
#include <seastar/core/shared_ptr.hh>
#include <seastar/core/semaphore.hh>
#include <seastar/core/sharded.hh>
#include "utils/chunked_vector.hh"
#include "utils/phased_barrier.hh"
#include "service/topology_state_machine.hh"
#include "locator/types.hh"
#include "locator/topology.hh"
#include "locator/token_metadata_fwd.hh"
struct sort_by_proximity_topology;
// forward declaration since replica/database.hh includes this file
namespace replica {
class keyspace;
}
namespace gms {
class gossiper;
}
namespace locator {
class abstract_replication_strategy;
using token = dht::token;
class shared_token_metadata;
class tablet_metadata;
struct host_id_or_endpoint {
std::variant<host_id, gms::inet_address> _value;
enum class param_type {
host_id,
endpoint,
auto_detect
};
host_id_or_endpoint(const sstring& s, param_type restrict = param_type::auto_detect);
bool has_host_id() const noexcept {
return _value.index() == 0;
}
bool has_endpoint() const noexcept {
return _value.index() == 1;
}
host_id id() const {
return std::get<host_id>(_value);
};
gms::inet_address endpoint() const {
return std::get<gms::inet_address>(_value);
};
// Map the host_id to endpoint or vice verse, using the token_metadata.
// Throws runtime error if failed to resolve.
host_id resolve_id(const gms::gossiper&) const;
gms::inet_address resolve_endpoint(const gms::gossiper&) const;
};
using host_id_or_endpoint_list = std::vector<host_id_or_endpoint>;
[[nodiscard]] inline bool check_host_ids_contain_only_uuid(const auto& host_ids) {
return std::ranges::none_of(host_ids, [](const auto& node_str) { return locator::host_id_or_endpoint{node_str}.has_endpoint(); });
}
class token_metadata_impl;
struct topology_change_info;
struct version_tracker {
public:
friend class shared_token_metadata;
using link_base = boost::intrusive::list_member_hook<boost::intrusive::link_mode<boost::intrusive::auto_unlink>>;
struct link_type : link_base {
link_type() noexcept = default;
link_type(link_type&& o) noexcept { swap_nodes(o); }
link_type& operator=(link_type&& o) noexcept {
if (this != &o) {
unlink();
swap_nodes(o);
}
return *this;
}
};
private:
utils::phased_barrier::operation _op;
service::topology::version_t _version;
const token_metadata* _tm = nullptr;
link_type _link;
// When engaged it means the version is no longer latest and should be released soon as to
// not block barriers. If this version dies past _log_threshold, it should self-report.
std::optional<std::chrono::steady_clock::time_point> _expired_at;
std::chrono::steady_clock::duration _log_threshold;
public:
version_tracker() = default;
version_tracker(utils::phased_barrier::operation op, const token_metadata& tm);
version_tracker(version_tracker&&) noexcept = default;
version_tracker& operator=(version_tracker&& o) noexcept {
if (this != &o) {
std::destroy_at(this);
new (this) version_tracker(std::move(o));
}
return *this;
};
version_tracker(const version_tracker&) = delete;
~version_tracker();
service::topology::version_t version() const {
return _version;
}
long version_use_count() const;
void mark_expired(std::chrono::steady_clock::duration log_threshold) {
if (!_expired_at) {
_expired_at = std::chrono::steady_clock::now();
_log_threshold = log_threshold;
}
}
};
class tokens_iterator {
public:
using iterator_category = std::input_iterator_tag;
using iterator_concept = std::input_iterator_tag;
using value_type = token;
using difference_type = std::ptrdiff_t;
using pointer = token*;
using reference = token&;
public:
tokens_iterator() = default;
tokens_iterator(const token& start, const token_metadata_impl* token_metadata);
bool operator==(const tokens_iterator& it) const;
const token& operator*() const;
tokens_iterator& operator++();
tokens_iterator operator++(int) {
auto tmp = *this;
++*this;
return tmp;
}
private:
utils::chunked_vector<token>::const_iterator _cur_it;
size_t _remaining = 0;
const token_metadata_impl* _token_metadata = nullptr;
friend class token_metadata_impl;
};
class token_metadata final: public enable_lw_shared_from_this<token_metadata> {
shared_token_metadata* _shared_token_metadata = nullptr;
std::unique_ptr<token_metadata_impl> _impl;
private:
friend class token_metadata_ring_splitter;
using tokens_iterator = locator::tokens_iterator;
public:
struct config {
topology::config topo_cfg;
};
using inet_address = gms::inet_address;
using version_t = service::topology::version_t;
using version_tracker_t = version_tracker;
token_metadata(shared_token_metadata& stm, config cfg);
explicit token_metadata(std::unique_ptr<token_metadata_impl> impl);
token_metadata(token_metadata&&) noexcept; // Can't use "= default;" - hits some static_assert in unique_ptr
token_metadata& operator=(token_metadata&&) noexcept;
~token_metadata();
const utils::chunked_vector<token>& sorted_tokens() const;
const tablet_metadata& tablets() const;
tablet_metadata& tablets();
void set_tablets(tablet_metadata);
// Update token->endpoint mappings for a given \c endpoint.
// \c tokens are all the tokens that are now owned by \c endpoint.
//
// Note: the function is not exception safe!
// It must be called only on a temporary copy of the token_metadata
future<> update_normal_tokens(std::unordered_set<token> tokens, host_id endpoint);
const token& first_token(const token& start) const;
size_t first_token_index(const token& start) const;
std::optional<host_id> get_endpoint(const token& token) const;
std::vector<token> get_tokens(const host_id& addr) const;
const std::unordered_map<token, host_id>& get_token_to_endpoint() const;
const std::unordered_set<host_id>& get_leaving_endpoints() const;
const std::unordered_map<token, host_id>& get_bootstrap_tokens() const;
/**
* Update or add a node for a given host_id.
* The other arguments (dc, state, shard_count) are optional, i.e. the corresponding node
* fields won't be updated if std::nullopt is passed.
*/
void update_topology(host_id ep, std::optional<endpoint_dc_rack> opt_dr, std::optional<node::state> opt_st = std::nullopt,
std::optional<shard_id> shard_count = std::nullopt);
/**
* Creates an iterable range of the sorted tokens starting at the token t
* such that t >= start.
*
* @param start A token that will define the beginning of the range
*
* @return The requested range (see the description above)
*/
std::ranges::subrange<tokens_iterator> ring_range(const token& start) const;
/**
* Returns a range of tokens such that the first token t satisfies dht::ring_position_view::ending_at(t) >= start.
*/
std::ranges::subrange<tokens_iterator> ring_range(dht::ring_position_view start) const;
topology& get_topology();
const topology& get_topology() const;
void debug_show() const;
/** @return a copy of the endpoint-to-id map for read-only operations */
std::unordered_set<host_id> get_host_ids() const;
/// Returns host_id of the local node.
host_id get_my_id() const;
void add_bootstrap_token(token t, host_id endpoint);
void add_bootstrap_tokens(std::unordered_set<token> tokens, host_id endpoint);
void remove_bootstrap_tokens(std::unordered_set<token> tokens);
void add_leaving_endpoint(host_id endpoint);
void del_leaving_endpoint(host_id endpoint);
void remove_endpoint(host_id endpoint);
// Checks if the node is part of the token ring. If yes, the node is one of
// the nodes that owns the tokens and inside the set _normal_token_owners.
bool is_normal_token_owner(host_id endpoint) const;
bool is_leaving(host_id endpoint) const;
// Is this node being replaced by another node
bool is_being_replaced(host_id endpoint) const;
// Is any node being replaced by another node
bool is_any_node_being_replaced() const;
void add_replacing_endpoint(host_id existing_node, host_id replacing_node);
void del_replacing_endpoint(host_id existing_node);
/**
* Create a full copy of token_metadata using asynchronous continuations.
* The caller must ensure that the cloned object will not change if
* the function yields.
*/
future<token_metadata> clone_async() const noexcept;
/**
* Create a copy of TokenMetadata with only tokenToEndpointMap. That is, pending ranges,
* bootstrap tokens and leaving endpoints are not included in the copy.
* The caller must ensure that the cloned object will not change if
* the function yields.
*/
future<token_metadata> clone_only_token_map() const noexcept;
/**
* Create a copy of TokenMetadata with tokenToEndpointMap reflecting situation after all
* current leave operations have finished.
* The caller must ensure that the cloned object will not change if
* the function yields.
*
* @return a future holding a new token metadata
*/
future<token_metadata> clone_after_all_left() const noexcept;
/**
* Gently clear the token_metadata members.
* Yield if needed to prevent reactor stalls.
*/
future<> clear_gently() noexcept;
/*
* Number of returned ranges = O(tokens.size())
*/
dht::token_range_vector get_primary_ranges_for(std::unordered_set<token> tokens) const;
/*
* Number of returned ranges = O(1)
*/
dht::token_range_vector get_primary_ranges_for(token right) const;
static boost::icl::interval<token>::interval_type range_to_interval(wrapping_interval<dht::token> r);
static wrapping_interval<dht::token> interval_to_range(boost::icl::interval<token>::interval_type i);
future<> update_topology_change_info(dc_rack_fn& get_dc_rack);
const std::optional<topology_change_info>& get_topology_change_info() const;
token get_predecessor(token t) const;
const std::unordered_set<host_id>& get_normal_token_owners() const;
void for_each_token_owner(std::function<void(const node&)> func) const;
/* Returns the number of different endpoints that own tokens in the ring.
* Bootstrapping tokens are not taken into account. */
size_t count_normal_token_owners() const;
// Returns the map: DC -> host_id of token owners in that DC.
// If there are no token owners in a DC, it is not present in the result.
std::unordered_map<sstring, std::unordered_set<host_id>> get_datacenter_token_owners() const;
// Returns the map: DC -> (map: rack -> host_id of token owners in that rack).
// If there are no token owners in a DC/rack, it is not present in the result.
std::unordered_map<sstring, std::unordered_map<sstring, std::unordered_set<host_id>>>
get_datacenter_racks_token_owners() const;
// Returns the map: DC -> token owners in that DC.
// If there are no token owners in a DC, it is not present in the result.
std::unordered_map<sstring, std::unordered_set<std::reference_wrapper<const node>>> get_datacenter_token_owners_nodes() const;
// Returns the map: DC -> (map: rack -> token owners in that rack).
// If there are no token owners in a DC/rack, it is not present in the result.
std::unordered_map<sstring, std::unordered_map<sstring, std::unordered_set<std::reference_wrapper<const node>>>>
get_datacenter_racks_token_owners_nodes() const;
// Updates the read_new flag, switching read requests from
// the old endpoints to the new ones during topology changes:
// read_new_t::no - no read_endpoints will be stored on update_pending_ranges, all reads goes to normal endpoints;
// read_new_t::yes - triggers update_pending_ranges to compute and store new ranges for read requests.
// The value is preserved in all clone functions, the default is read_new_t::no.
using read_new_t = bool_class<class read_new_tag>;
void set_read_new(read_new_t value);
long get_ring_version() const;
void invalidate_cached_rings();
version_t get_version() const;
void set_version(version_t version);
shared_token_metadata& get_shared_token_metadata();
friend class token_metadata_impl;
friend class shared_token_metadata;
private:
void set_version_tracker(version_tracker_t tracker);
void set_shared_token_metadata(shared_token_metadata& stm);
// Clears and disposes the token metadata impl in the background, if present.
void clear_and_dispose_impl() noexcept;
};
struct topology_change_info {
lw_shared_ptr<token_metadata> target_token_metadata;
utils::chunked_vector<dht::token> all_tokens;
token_metadata::read_new_t read_new;
topology_change_info(lw_shared_ptr<token_metadata> target_token_metadata_,
utils::chunked_vector<dht::token> all_tokens_,
token_metadata::read_new_t read_new_);
future<> clear_gently();
};
using token_metadata_lock = semaphore_units<>;
using token_metadata_lock_func = noncopyable_function<future<token_metadata_lock>() noexcept>;
class shared_token_metadata : public peering_sharded_service<shared_token_metadata> {
named_gate _background_dispose_gate{"shared_token_metadata::background_dispose_gate"};
mutable_token_metadata_ptr _shared;
token_metadata_lock_func _lock_func;
std::chrono::steady_clock::duration _stall_detector_threshold = std::chrono::seconds(2);
// We use this barrier during the transition to a new token_metadata version to ensure that the
// system stops using previous versions. Here are the key points:
// * A new phase begins when a mutable_token_metadata_ptr passed to shared_token_metadata::set has
// a higher version than the current one.
// * Each shared_token_metadata::set call initiates an operation on the barrier. If multiple calls
// have the same version, multiple operations may be initiated with the same phase.
// * The operation is stored within the new token_metadata instance (token_metadata::set_version_tracker),
// and it completes when the instance is destroyed.
// * The method shared_token_metadata::stale_versions_in_use can be used to wait for the phase
// transition to complete. Once this future resolves, there will be no token_metadata instances
// with versions lower than the current one.
// * Multiple new phases (version upgrades) can be started before accessing stale_versions_in_use.
// However, stale_versions_in_use waits for all previous phases to finish, as advance_and_await
// includes its own invocation as an operation in the new phase.
utils::phased_barrier _versions_barrier;
shared_future<> _stale_versions_in_use{make_ready_future<>()};
using version_tracker_list_type = boost::intrusive::list<version_tracker,
boost::intrusive::member_hook<version_tracker, version_tracker::link_type, &version_tracker::_link>,
boost::intrusive::constant_time_size<false>>;
version_tracker_list_type _trackers;
private:
version_tracker new_tracker(const token_metadata& tm);
public:
// used to construct the shared object as a sharded<> instance
// lock_func returns semaphore_units<>
explicit shared_token_metadata(token_metadata_lock_func lock_func, token_metadata::config cfg)
: _shared(make_lw_shared<token_metadata>(*this, cfg))
, _lock_func(std::move(lock_func))
, _versions_barrier("shared_token_metadata::versions_barrier")
{
_shared->set_version_tracker(new_tracker(*_shared));
}
shared_token_metadata(const shared_token_metadata& x) = delete;
shared_token_metadata(shared_token_metadata&& x) = default;
future<> stop() noexcept;
mutable_token_metadata_ptr make_token_metadata_ptr() {
return make_lw_shared<token_metadata>(*this, token_metadata::config{_shared->get_topology().get_config()});
}
mutable_token_metadata_ptr make_token_metadata_ptr(token_metadata&& tm) {
tm.set_shared_token_metadata(*this);
return make_lw_shared<token_metadata>(std::move(tm));
}
token_metadata_ptr get() const noexcept {
return _shared;
}
void set(mutable_token_metadata_ptr tmptr) noexcept;
void set_stall_detector_threshold(std::chrono::steady_clock::duration threshold) {
_stall_detector_threshold = threshold;
}
// Returns a map version -> use_count
std::unordered_map<service::topology::version_t, int> describe_stale_versions();
future<> stale_versions_in_use() const {
return _stale_versions_in_use.get_future();
}
// Token metadata changes are serialized
// using the schema_tables merge_lock.
//
// Must be called on shard 0.
future<token_metadata_lock> get_lock() const noexcept {
return _lock_func();
}
// mutate_token_metadata_on_all_shards acquires the shared_token_metadata lock,
// clones the token_metadata (using clone_async)
// and calls an asynchronous functor on
// the cloned copy of the token_metadata to mutate it.
//
// If the functor is successful, the mutated clone
// is set back to to the shared_token_metadata,
// otherwise, the clone is destroyed.
future<> mutate_token_metadata(seastar::noncopyable_function<future<> (token_metadata&)> func);
// mutate_token_metadata_on_all_shards acquires the shared_token_metadata lock,
// clones the token_metadata (using clone_async)
// and calls an asynchronous functor on
// the cloned copy of the token_metadata to mutate it.
//
// If the functor is successful, the mutated clone
// is set back to to the shared_token_metadata on all shards,
// otherwise, the clone is destroyed.
//
// Must be called on shard 0.
static future<> mutate_on_all_shards(sharded<shared_token_metadata>& stm, seastar::noncopyable_function<future<> (token_metadata&)> func);
void clear_and_dispose(std::unique_ptr<token_metadata_impl> impl) noexcept;
private:
// for testing only, unsafe to be called without awaiting get_lock() first
void mutate_token_metadata_for_test(seastar::noncopyable_function<void (token_metadata&)> func);
friend struct ::sort_by_proximity_topology;
};
class pending_token_metadata {
std::vector<locator::mutable_token_metadata_ptr> _shards{smp::count};
public:
future<> assign(locator::mutable_token_metadata_ptr new_token_metadata);
locator::mutable_token_metadata_ptr& local();
locator::token_metadata_ptr local() const;
future<> destroy();
};
}