5998a859f7
Modify the methods which calculate the default gc mode as well as that which validates whether repair-mode can be used at all, so both accepts use of repair-mode on RF=1 tables. This de-facto changes the default tombstone-gc to repair-mode for all tables. Documentation is updated accordingly. Some tests need adjusting: * cqlpy/test_select_from_mutation_fragments.py: disable GC for some test cases because this patch makes tombstones they write subject to GC when using defaults. * test/cluster/test_mv.py::test_mv_tombstone_gc_not_inherited used repair-mode as a non-default for the base table and expected the MV to revert to default. Another mode has to be used as the non-default (immediate). * test/cqlpy/test_tools.py::test_scylla_sstable_dump_schema: don't compare tombstone_gc schema extension when comparing dumped schema vs. original. The tool's schema loader doesn't have access to the keyspace definition so it will come up with different defaults for tombstone-gc. * test/boost/row_cache_test.cc::test_populating_cache_with_expired_and_nonexpired_tombstones sets tombstone expiry assuming the tombstone-gc timeout-mode default. Change the CREATE TABLE statement to set the expected mode.
70 lines
3.4 KiB
Python
70 lines
3.4 KiB
Python
#
|
|
# Copyright (C) 2024-present ScyllaDB
|
|
#
|
|
# SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
#
|
|
"""
|
|
Tests for materialized views that need a three-node cluster.
|
|
Note that most materialized-view functional tests can make due with a single
|
|
node, and belong in cqlpy. We also have topology_experimental_raft/
|
|
test_mv_tablets.py for tests that each needs a cluster of a different
|
|
size, and/or special Scylla parameters.
|
|
"""
|
|
import logging
|
|
import pytest
|
|
|
|
from test.cluster.util import new_test_keyspace, new_test_table, new_materialized_view
|
|
|
|
ksdef = "WITH REPLICATION = { 'class': 'NetworkTopologyStrategy', 'replication_factor': 3 } AND TABLETS = {'enabled': false }"
|
|
|
|
logger = logging.getLogger(__name__)
|
|
pytestmark = pytest.mark.prepare_3_racks_cluster
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
@pytest.mark.skip(reason="tombstone_gc repair mode is not supported yet for MVs due to #24816")
|
|
async def test_mv_tombstone_gc_setting(manager):
|
|
"""
|
|
Test that the tombstone_gc parameter can be set on a materialized view,
|
|
during CREATE MATERIALIZED VIEW and later with ALTER MATERIALIZED VIEW.
|
|
Note that the test only tests the ability to set this parameter - not
|
|
its actual function after it's set.
|
|
The tombstone_gc feature is Scylla-only, so the test is scylla_only.
|
|
|
|
tombstone_gc=repair is not supported on a table with RF=1, and RF>1
|
|
is not supported on a single node, which is why this test needs to
|
|
be here and not in the single-node cqlpy.
|
|
"""
|
|
cql = manager.cql
|
|
async with new_test_keyspace(manager, ksdef) as keyspace:
|
|
async with new_test_table(manager, keyspace, "p int primary key, x int") as table:
|
|
# Adding "WITH tombstone_gc = ..." In the CREATE MATERIALIZED VIEW:
|
|
async with new_materialized_view(manager, table, "*", "p, x", "p is not null and x is not null", "WITH tombstone_gc = {'mode': 'repair'}") as mv:
|
|
s = list(cql.execute(f"DESC {mv}"))[0].create_statement
|
|
assert "'mode': 'repair'" in s
|
|
# Adding "WITH tombstone_gc = ..." In the ALTER MATERIALIZED VIEW:
|
|
async with new_materialized_view(manager, table, "*", "p, x", "p is not null and x is not null") as mv:
|
|
s = list(cql.execute(f"DESC {mv}"))[0].create_statement
|
|
assert not "'mode': 'repair'" in s
|
|
await cql.run_async("ALTER MATERIALIZED VIEW " + mv + " WITH tombstone_gc = {'mode': 'repair'}")
|
|
s = list(cql.execute(f"DESC {mv}"))[0].create_statement
|
|
assert "'mode': 'repair'" in s
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_mv_tombstone_gc_not_inherited(manager):
|
|
"""
|
|
Test that the tombstone_gc parameter set on a base table is NOT inherited
|
|
by a view created on it later.
|
|
This behavior is not explicitly documented anywhere, but this test
|
|
demonstrates the existing behavior.
|
|
"""
|
|
cql = manager.cql
|
|
async with new_test_keyspace(manager, ksdef) as keyspace:
|
|
async with new_test_table(manager, keyspace, "p int primary key, x int", "WITH tombstone_gc = {'mode': 'immediate'}") as table:
|
|
s = list(cql.execute(f"DESC {table}"))[0].create_statement
|
|
assert "'mode': 'immediate'" in s
|
|
async with new_materialized_view(manager, table, "*", "p, x", "p is not null and x is not null") as mv:
|
|
s = list(cql.execute(f"DESC {mv}"))[0].create_statement
|
|
# Base's setting is NOT inherited to the view:
|
|
assert not "'mode': 'immediate'" in s
|