83aee954b4
So far it was not allowed to pass a scope when using the primary_replica_only option, this patch enables it because the concepts are now combined so that: - scope=all primary_replica_only=true gets the global primary replica - scope=dc primary_replica_only=true gets the local primary replica - scope=rack primary_replica_only=true is like a noop, it gets the only replica in the rack (rf=#racks) - scope=node primary_replica_only=node is not allowed Fixes #26584 Signed-off-by: Robert Bindar <robert.bindar@scylladb.com>
116 lines
5.3 KiB
Python
116 lines
5.3 KiB
Python
#
|
|
# Copyright 2023-present ScyllaDB
|
|
#
|
|
# SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
#
|
|
|
|
import pytest
|
|
|
|
from test.nodetool.utils import check_nodetool_fails_with
|
|
from test.nodetool.rest_api_mock import expected_request
|
|
|
|
|
|
def test_refresh(nodetool):
|
|
nodetool("refresh", "ks", "tbl", expected_requests=[
|
|
expected_request("POST", "/storage_service/sstables/ks", params={"cf": "tbl"})])
|
|
|
|
|
|
@pytest.mark.parametrize("load_and_stream_opt", ["--load-and-stream", "-las"])
|
|
def test_refresh_load_and_stream(nodetool, load_and_stream_opt):
|
|
nodetool("refresh", "ks", "tbl", load_and_stream_opt, expected_requests=[
|
|
expected_request("POST", "/storage_service/sstables/ks", params={"cf": "tbl", "load_and_stream": "true"})])
|
|
|
|
|
|
@pytest.mark.parametrize("load_and_stream_opt", ["--load-and-stream", "-las"])
|
|
@pytest.mark.parametrize("primary_replica_only_opt", ["--primary-replica-only", "-pro"])
|
|
def test_refresh_load_and_stream_and_primary_replica_only(nodetool, load_and_stream_opt, primary_replica_only_opt):
|
|
nodetool("refresh", "ks", "tbl", load_and_stream_opt, primary_replica_only_opt, expected_requests=[
|
|
expected_request("POST", "/storage_service/sstables/ks",
|
|
params={"cf": "tbl", "load_and_stream": "true", "primary_replica_only": "true"})])
|
|
|
|
|
|
def test_refresh_no_table(nodetool):
|
|
check_nodetool_fails_with(
|
|
nodetool,
|
|
("refresh", "ks"),
|
|
{"expected_requests": []},
|
|
["nodetool: refresh requires ks and cf args",
|
|
"error processing arguments: required parameter is missing: table"])
|
|
|
|
|
|
def test_refresh_no_table_no_keyspace(nodetool):
|
|
check_nodetool_fails_with(
|
|
nodetool,
|
|
("refresh",),
|
|
{"expected_requests": []},
|
|
["nodetool: refresh requires ks and cf args",
|
|
"error processing arguments: required parameters are missing: keyspace and table"])
|
|
|
|
|
|
def test_refresh_primary_replica_only(nodetool, scylla_only):
|
|
check_nodetool_fails_with(
|
|
nodetool,
|
|
("refresh", "ks", "tbl", "--primary-replica-only"),
|
|
{"expected_requests": []},
|
|
["error processing arguments: --primary-replica-only|-pro takes no effect without --load-and-stream|-las"])
|
|
|
|
|
|
def test_refresh_skip_cleanup(nodetool, scylla_only):
|
|
nodetool("refresh", "ks", "tbl", "--skip-cleanup", expected_requests=[
|
|
expected_request("POST", "/storage_service/sstables/ks", params={"cf": "tbl", "skip_cleanup": "true"})])
|
|
|
|
|
|
def test_refresh_skip_cleanup_load_and_stream(nodetool, scylla_only):
|
|
check_nodetool_fails_with(
|
|
nodetool,
|
|
("refresh", "ks", "tbl", "--load-and-stream", "--skip-cleanup"),
|
|
{"expected_requests": []},
|
|
["error processing arguments: --skip-cleanup takes no effect with --load-and-stream|-las"])
|
|
|
|
def test_refresh_scope_only(nodetool, scylla_only):
|
|
check_nodetool_fails_with(
|
|
nodetool,
|
|
("refresh", "ks", "tbl", "--scope=all"),
|
|
{"expected_requests": []},
|
|
["error processing arguments: --scope takes no effect without --load-and-stream|-las"])
|
|
|
|
def test_refresh_scope_node_primary_replica(nodetool, scylla_only):
|
|
check_nodetool_fails_with(
|
|
nodetool,
|
|
("refresh", "ks", "tbl", "--scope=node", "--primary-replica-only", "--load-and-stream"),
|
|
{"expected_requests": []},
|
|
["error processing arguments: Cannot set both primary_replica_only and scope=node"])
|
|
|
|
@pytest.mark.parametrize("scope_val", ["all", "dc", "rack"])
|
|
def test_refresh_scope_primary_replica(nodetool, scylla_only, scope_val):
|
|
nodetool("refresh", "ks", "tbl", "--load-and-stream", f"--scope={scope_val}", "--primary-replica-only", expected_requests=[
|
|
expected_request("POST", "/storage_service/sstables/ks",
|
|
params={"cf": "tbl", "load_and_stream": "true", "primary_replica_only": "true", "scope": f"{scope_val}"})])
|
|
|
|
def test_refresh_scope_illegal(nodetool, scylla_only):
|
|
check_nodetool_fails_with(
|
|
nodetool,
|
|
("refresh", "ks", "tbl", "--scope=broken", "--load-and-stream"),
|
|
{"expected_requests": []},
|
|
["error processing arguments: Invalid scope parameter value"])
|
|
|
|
@pytest.mark.parametrize("load_and_stream_opt", ["--load-and-stream", "-las"])
|
|
@pytest.mark.parametrize("scope_val", ["all", "dc", "rack", "node"])
|
|
def test_refresh_load_and_stream_scope(nodetool, load_and_stream_opt, scope_val):
|
|
nodetool("refresh", "ks", "tbl", load_and_stream_opt, f"--scope={scope_val}", expected_requests=[
|
|
expected_request("POST", "/storage_service/sstables/ks",
|
|
params={"cf": "tbl", "load_and_stream": "true", "scope": f"{scope_val}"})])
|
|
|
|
|
|
def test_refresh_skip_reshape(nodetool, scylla_only):
|
|
nodetool("refresh", "ks", "tbl", "--skip-reshape", expected_requests=[
|
|
expected_request("POST", "/storage_service/sstables/ks", params={"cf": "tbl", "skip_reshape": "true"})])
|
|
|
|
|
|
def test_refresh_skip_reshape_load_and_stream(nodetool, scylla_only):
|
|
check_nodetool_fails_with(
|
|
nodetool,
|
|
("refresh", "ks", "tbl", "--load-and-stream", "--skip-reshape"),
|
|
{"expected_requests": []},
|
|
["error processing arguments: --skip-reshape takes no effect with --load-and-stream|-las"])
|