mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-23 01:50:35 +00:00
772b32d9f7
Fixtures previously ran GDB once (module scope) to find live objects (sstables, tasks, schemas) and stored their addresses. Tests then reused those addresses in separate GDB invocations. Sometimes these addresses would become stale and the test would step on use-after-free (e.g. sstables compacted away between invocations). Fix by dropping the fixtures. The helper functions used by the fixtures to obtain the required objects are converted to gdb convenience functions, which can be used in the same expression as the test command invocation. Thus, the object is aquired on-demand at the moment it is used, so it is guaranteed to be fresh and relevant. Fixes: SCYLLADB-1020 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Closes scylladb/scylladb#28999
80 lines
2.4 KiB
Python
80 lines
2.4 KiB
Python
# Copyright 2025-present ScyllaDB
|
|
#
|
|
# SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
|
|
"""
|
|
GDB helper functions for `scylla_gdb` tests.
|
|
They should be loaded to GDB by "-x {dir}/gdb_utils.py}",
|
|
when loaded, they can be run in gdb e.g. `$get_sstables()`
|
|
|
|
Depends on helper functions injected to GDB by `scylla-gdb.py` script.
|
|
(sharded, for_each_table, seastar_lw_shared_ptr, find_sstables, find_vptrs, resolve,
|
|
get_seastar_memory_start_and_size).
|
|
"""
|
|
|
|
import gdb
|
|
import uuid
|
|
|
|
|
|
class get_schema(gdb.Function):
|
|
"""Finds and returns a schema pointer."""
|
|
|
|
def __init__(self):
|
|
super(get_schema, self).__init__('get_schema')
|
|
|
|
def invoke(self):
|
|
db = sharded(gdb.parse_and_eval('::debug::the_database')).local()
|
|
table = next(for_each_table(db))
|
|
return seastar_lw_shared_ptr(table['_schema']).get()
|
|
|
|
|
|
class get_sstable(gdb.Function):
|
|
"""Finds and returns an sstable pointer."""
|
|
|
|
def __init__(self):
|
|
super(get_sstable, self).__init__('get_sstable')
|
|
|
|
def invoke(self):
|
|
return next(find_sstables())
|
|
|
|
|
|
class get_task(gdb.Function):
|
|
"""
|
|
Finds and returns a Scylla fiber task.
|
|
Because we stopped Scylla while it was idle, we don't expect to find
|
|
any ready task with get_local_tasks(), but we can find one with a
|
|
find_vptrs() loop. I noticed that a nice one (with multiple tasks chained
|
|
to it for "scylla fiber") is one from http_server::do_accept_one.
|
|
"""
|
|
def __init__(self):
|
|
super(get_task, self).__init__('get_task')
|
|
|
|
def invoke(self):
|
|
for obj_addr, vtable_addr in find_vptrs():
|
|
name = resolve(vtable_addr, startswith='vtable for seastar::continuation')
|
|
if name and 'do_accept_one' in name:
|
|
return obj_addr.cast(gdb.lookup_type('uintptr_t'))
|
|
|
|
|
|
class get_coroutine(gdb.Function):
|
|
"""
|
|
Finds and returns a coroutine frame.
|
|
Prints COROUTINE_NOT_FOUND if the coroutine is not present.
|
|
"""
|
|
def __init__(self):
|
|
super(get_coroutine, self).__init__('get_coroutine')
|
|
|
|
def invoke(self):
|
|
target = 'service::topology_coordinator::run() [clone .resume]'
|
|
for obj_addr, vtable_addr in find_vptrs():
|
|
name = resolve(vtable_addr)
|
|
if name and name.strip() == target:
|
|
return obj_addr.cast(gdb.lookup_type('uintptr_t'))
|
|
print("COROUTINE_NOT_FOUND")
|
|
|
|
|
|
# Register the functions in GDB
|
|
get_schema()
|
|
get_sstable()
|
|
get_task()
|
|
get_coroutine()
|