mirror of
https://github.com/scylladb/scylladb.git
synced 2026-06-03 05:26:58 +00:00
99a72a9676
As a part of CQL rewrite we want to be able to perform filtering by calling `evaluate()` on an expression and checking if it evaluates to `true`. Currently trying to do that for a binary operator would result in an error. Right now checking if a binary operation like `col1 = 123` is true is done using `is_satisfied_by`, which is able to check if a binary operation evaluates to true for a small set of predefined cases. Eventually once the grammar is relaxed we will be able to write expressions like: `(col1 < col2) = (1 > ?)`, which doesn't fit with what `is_satisfied_by` is supposed to do. Additionally expressions like `1 = NULL` should evaluate to `NULL`, not `true` or `false`. `is_satsified_by` is not able to express that properly. The proper way to go is implementing `evaluate(binary_operator)`, which takes a binary operation and returns what the result of it would be. Implementing `prepare_expression` for `binary_operator` requires us to be able to evaluate it first. In the next PR I will add support for `prepare_expression`. Closes #12052 * github.com:scylladb/scylladb: cql-pytest: enable two unset value tests that pass now cql-pytest: reduce unset value error message cql3: expr: change unset value error messages to lowercase cql_pytest: ensure that where clauses like token(p) = 0 AND p = 0 are rejected cql3: expr: remove needless braces around switch cases cql3: move evaluation IS_NOT NULL to a separate function expr_test: test evaluating LIKE binary_operator expr_test: test evaluating IS_NOT binary_operator expr_test: test evaluating CONTAINS_KEY binary_operator expr_test: test evaluating CONTAINS binary_operator expr_test: test evaluating IN binary_operator expr_test: test evaluating GTE binary_operator expr_test: test evaluating GT binary_operator expr_test: test evaluating LTE binary_operator expr_test: test evaluating LT binary_operator expr_test: test evaluating NEQ binary_operator expr_test: test evaluating EQ binary_operator cql3: expr properly handle null in is_one_of() cql3: expr properly handle null in like() cql3: expr properly handle null in contains_key() cql3: expr properly handle null in contains() cql3: expr: properly handle null in limits() cql3: expr: remove unneeded overload of limits() cql3: expr: properly handle null in equality operators cql3: expr: remove unneeded overload of equal() cql3: expr: use evaluate(binary_operator) in is_satisfied_by cql3: expr: handle IS NOT NULL when evaluating binary_operator cql3: expr: make it possible to evaluate binary_operator cql3: expr: accept expression as lhs argument to like() cql3: expr: accept expression as lhs in contains_key cql3: expr: accept expression as lhs argument to contains()