mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-06-03 05:26:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
next-4.6
scylladb/cql3/statements
History
Nadav Har'El cbcfa31e51 cql: validate bloom_filter_fp_chance up-front 
Scylla's Bloom filter implementation has a minimal false-positive rate
that it can support (6.71e-5). When setting bloom_filter_fp_chance any
lower than that, the compute_bloom_spec() function, which writes the bloom
filter, throws an exception. However, this is too late - it only happens
while flushing the memtable to disk, and a failure at that point causes
Scylla to crash.

Instead, we should refuse the table creation with the unsupported
bloom_filter_fp_chance. This is also what Cassandra did six years ago -
see CASSANDRA-11920.

This patch also includes a regression test, which crashes Scylla before
this patch but passes after the patch (and also passes on Cassandra).

Fixes #11524.

Signed-off-by: Nadav Har'El <nyh@scylladb.com>

Closes #11576

(cherry picked from commit 4c93a694b7)
2022-10-04 16:23:25 +03:00
..
raw
Merge ' cql3: Demand ALLOW FILTERING for unlimited, sliced partitions ' from Dejan Mircevski
2021-08-31 18:05:26 +03:00
alter_keyspace_statement.cc
client_state: Add database argument to has_keyspace_access()
2021-08-27 14:07:18 +03:00
alter_keyspace_statement.hh
cql: allow restricting SimpleStrategy in ALTER KEYSPACE
2021-06-13 14:45:40 +03:00
alter_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
alter_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_table_statement.cc
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
alter_table_statement.hh
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
alter_type_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
alter_type_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
alter_view_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
alter_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
attach_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
attach_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
authentication_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
authentication_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
authorization_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
authorization_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
batch_statement.cc
prepared_statements: Invalidate batch statement too
2022-05-08 12:33:00 +03:00
batch_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
bound.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cas_request.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cas_request.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cf_prop_defs.cc
cql: validate bloom_filter_fp_chance up-front
2022-10-04 16:23:25 +03:00
cf_prop_defs.hh
sstables: give a more descriptive name to compaction_options
2021-09-12 11:21:33 +03:00
cf_properties.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
cf_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_aggregate_statement.cc
cql3: Replace all uses of bind_and_get with evaluate_to_raw_view
2021-09-21 16:20:30 +02:00
create_aggregate_statement.hh
cql3: create_aggregate_statement: convert term::raw to expression
2021-08-26 15:53:27 +03:00
create_function_statement.cc
treewide: add initial WebAssembly support to UDF
2021-09-13 19:03:58 +02:00
create_function_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_index_statement.cc
test/cql-pytest: CREATE INDEX IF NOT EXISTS vs. Cassandra
2021-08-11 13:41:58 +02:00
create_index_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
create_keyspace_statement.cc
abstract_replication_strategy: add to_qualified_class_name
2021-10-18 12:13:25 +03:00
create_keyspace_statement.hh
cql3: statements/create_keyspace: add get_keyspace_metadata()
2021-09-07 10:37:25 +03:00
create_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
create_service_level_statement.cc
cql3: statements: create_service_level_statement: don't ignore replace_defaults()
2021-10-10 18:16:50 +03:00
create_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
create_table_statement.cc
client_state: Add database argument to has_keyspace_access()
2021-08-27 14:07:18 +03:00
create_table_statement.hh
cql: add configurable restriction of DateTieredCompactionStrategy
2021-06-24 20:59:27 +03:00
create_type_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
create_type_statement.hh
cql3: statements/create_type: expose create_type()
2021-09-07 10:37:25 +03:00
create_view_statement.cc
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
create_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
delete_statement.cc
cql3: rename variable_specifications to prepare_context
2021-07-24 14:33:33 +03:00
delete_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
detach_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
detach_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_aggregate_statement.cc
cql3: add statements for user-defined aggregates
2021-08-13 11:16:52 +02:00
drop_aggregate_statement.hh
cql3: add statements for user-defined aggregates
2021-08-13 11:16:52 +02:00
drop_function_statement.cc
cql3,functions: add checking if a function is used in UDA
2021-08-13 11:16:47 +02:00
drop_function_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_index_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_index_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_keyspace_statement.cc
client_state: Add database argument to has_keyspace_access()
2021-08-27 14:07:18 +03:00
drop_keyspace_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_service_level_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_table_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_table_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_type_statement.cc
client_state: Add database argument to has_keyspace_access()
2021-08-27 14:07:18 +03:00
drop_type_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
drop_view_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
drop_view_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
function_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
function_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
grant_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
grant_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
grant_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_prop_defs.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_prop_defs.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_target.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
index_target.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
ks_prop_defs.cc
cql3: keyspace prepare_options: expand replication_factor also for fully qualified NetworkTopologyStrategy
2021-10-18 12:18:07 +03:00
ks_prop_defs.hh
abstract_replication_strategy: add to_qualified_class_name
2021-10-18 12:13:25 +03:00
list_permissions_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
list_permissions_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_roles_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_service_level_attachments_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
list_service_level_attachments_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_service_level_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
list_service_level_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
list_users_statement.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
list_users_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
modification_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
modification_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
permission_altering_statement.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
permission_altering_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
prepared_statement.hh
cql3: Demand ALLOW FILTERING for unlimited, sliced partitions
2021-08-31 10:45:41 -04:00
property_definitions.cc
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
property_definitions.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
request_validations.hh
cql3: replace seastar::sprint() with fmt::format()
2021-10-27 17:02:00 +03:00
revoke_role_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
revoke_statement.cc
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
revoke_statement.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
role-management-statements.cc
cql3: deinline non-trivial methods in selection.hh
2021-10-05 12:58:55 +02:00
schema_altering_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
schema_altering_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
select_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
select_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
service_level_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
service_level_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
sl_prop_defs.cc
cql3: fix misleading error message for service level timeouts
2022-09-01 20:34:22 +03:00
sl_prop_defs.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
statement_type.hh
treewide: extent copyright statements to present day
2021-06-06 19:18:49 +03:00
truncate_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
truncate_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
update_statement.cc
cql: INSERT JSON should refuse empty-string partition key
2022-03-02 22:00:15 +02:00
update_statement.hh
treewide: reduce header interdependencies
2021-06-07 15:58:35 +03:00
use_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00
use_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-05-08 12:32:41 +03:00