Files
scylladb/dist/common/scripts/scylla_memory_setup
Yaniv Michael Kaul af8eaa9ea5 scripts: fixes flagged by CodeQL/PyLens
Unused imports, unused variables and such.
Initially, there were no functional changes, just to get rid of some standard CodeQL warnings.

I've then broken the CI, as apparently there's a install time(!?) Python script creation for the sole purpose of product
naming. I changed it - we have it in etcdir, as SCYLLA-PRODUCT-FILE.
So added (copied from a different script) a get_product() helper function in scylla_util.py and used it instead.

While at it, also fixed the too broad import from scylla_util, which 'forced' me to also fix other specific imports (such as shutil).

Improvement - no need to backport.
Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>

Closes scylladb/scylladb#27883
2026-01-09 15:13:12 +02:00

43 lines
1.3 KiB
Python
Executable File

#!/usr/bin/env python3
# -*- coding: utf-8 -*-
#
# Copyright 2019-present ScyllaDB
#
#
# SPDX-License-Identifier: LicenseRef-ScyllaDB-Source-Available-1.0
import os
import sys
import argparse
from scylla_util import etcdir_p
if __name__ == '__main__':
if os.getuid() > 0:
print('Requires root permission.')
sys.exit(1)
parser = argparse.ArgumentParser(description='Configure memory for Scylla.')
parser.add_argument('--lock-memory',
help='lock all memory', action='store_true')
parser.add_argument('--memory',
help='memory to use, in bytes (ex: 4G, default=all)')
parser.add_argument('--reserve-memory',
help='memory reserved to OS (if --memory not specified)')
args = parser.parse_args()
if not args.lock_memory and not args.memory and not args.reserve_memory:
parser.print_help()
sys.exit(1)
conf_args=[]
if args.lock_memory:
conf_args.append('--lock-memory=1')
if args.memory:
conf_args.append('--memory={}'.format(args.memory))
if args.reserve_memory:
conf_args.append('--reserve-memory={}'.format(args.reserve_memory))
conf = 'MEM_CONF="{}"\n'.format(' '.join(conf_args))
with open(str(etcdir_p() / 'scylla.d' / 'memory.conf'), 'w') as f:
f.write(conf)