Store schema_ptr in reader permit instead of storing a const pointer to schema to ensure that the schema doesn't get changed elsewhere when the permit is holding on to it. Also update the constructors and all the relevant callers to pass down schema_ptr instead of a raw pointer. Fixes #16180 Signed-off-by: Lakshmi Narayanan Sreethar <lakshmi.sreethar@scylladb.com> Closes scylladb/scylladb#16658
328 lines
9.7 KiB
C++
328 lines
9.7 KiB
C++
/*
|
|
* Copyright (C) 2019-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <seastar/util/optimized_optional.hh>
|
|
#include "seastarx.hh"
|
|
|
|
#include "db/timeout_clock.hh"
|
|
#include "schema/schema_fwd.hh"
|
|
#include "tracing/trace_state.hh"
|
|
|
|
namespace query {
|
|
|
|
struct max_result_size;
|
|
|
|
}
|
|
|
|
namespace seastar {
|
|
class file;
|
|
} // namespace seastar
|
|
|
|
struct reader_resources {
|
|
int count = 0;
|
|
ssize_t memory = 0;
|
|
|
|
static reader_resources with_memory(ssize_t memory) { return reader_resources(0, memory); }
|
|
|
|
reader_resources() = default;
|
|
|
|
reader_resources(int count, ssize_t memory)
|
|
: count(count)
|
|
, memory(memory) {
|
|
}
|
|
|
|
reader_resources operator-(const reader_resources& other) const {
|
|
return reader_resources{count - other.count, memory - other.memory};
|
|
}
|
|
|
|
reader_resources& operator-=(const reader_resources& other) {
|
|
count -= other.count;
|
|
memory -= other.memory;
|
|
return *this;
|
|
}
|
|
|
|
reader_resources operator+(const reader_resources& other) const {
|
|
return reader_resources{count + other.count, memory + other.memory};
|
|
}
|
|
|
|
reader_resources& operator+=(const reader_resources& other) {
|
|
count += other.count;
|
|
memory += other.memory;
|
|
return *this;
|
|
}
|
|
|
|
bool non_zero() const {
|
|
return count > 0 || memory > 0;
|
|
}
|
|
};
|
|
|
|
inline bool operator==(const reader_resources& a, const reader_resources& b) {
|
|
return a.count == b.count && a.memory == b.memory;
|
|
}
|
|
|
|
std::ostream& operator<<(std::ostream& os, const reader_resources& r);
|
|
|
|
class reader_concurrency_semaphore;
|
|
|
|
/// A permit for a specific read.
|
|
///
|
|
/// Used to track the read's resource consumption. Use `consume_memory()` to
|
|
/// register memory usage, which returns a `resource_units` RAII object that
|
|
/// should be held onto while the respective resources are in use.
|
|
class reader_permit {
|
|
friend class reader_concurrency_semaphore;
|
|
friend class tracking_allocator_base;
|
|
|
|
public:
|
|
class resource_units;
|
|
class need_cpu_guard;
|
|
class awaits_guard;
|
|
|
|
enum class state {
|
|
waiting_for_admission,
|
|
waiting_for_memory,
|
|
waiting_for_execution,
|
|
active,
|
|
active_need_cpu,
|
|
active_await,
|
|
inactive,
|
|
evicted,
|
|
};
|
|
|
|
class impl;
|
|
|
|
private:
|
|
shared_ptr<impl> _impl;
|
|
|
|
private:
|
|
reader_permit() = default;
|
|
reader_permit(shared_ptr<impl>);
|
|
explicit reader_permit(reader_concurrency_semaphore& semaphore, schema_ptr schema, std::string_view op_name,
|
|
reader_resources base_resources, db::timeout_clock::time_point timeout, tracing::trace_state_ptr trace_ptr);
|
|
explicit reader_permit(reader_concurrency_semaphore& semaphore, schema_ptr schema, sstring&& op_name,
|
|
reader_resources base_resources, db::timeout_clock::time_point timeout, tracing::trace_state_ptr trace_ptr);
|
|
|
|
reader_permit::impl& operator*() { return *_impl; }
|
|
reader_permit::impl* operator->() { return _impl.get(); }
|
|
|
|
void mark_need_cpu() noexcept;
|
|
|
|
void mark_not_need_cpu() noexcept;
|
|
|
|
void mark_awaits() noexcept;
|
|
|
|
void mark_not_awaits() noexcept;
|
|
|
|
operator bool() const { return bool(_impl); }
|
|
|
|
friend class optimized_optional<reader_permit>;
|
|
|
|
void consume(reader_resources res);
|
|
|
|
void signal(reader_resources res);
|
|
|
|
public:
|
|
~reader_permit();
|
|
|
|
reader_permit(const reader_permit&) = default;
|
|
reader_permit(reader_permit&&) = default;
|
|
|
|
reader_permit& operator=(const reader_permit&) = default;
|
|
reader_permit& operator=(reader_permit&&) = default;
|
|
|
|
bool operator==(const reader_permit& o) const {
|
|
return _impl == o._impl;
|
|
}
|
|
|
|
reader_concurrency_semaphore& semaphore();
|
|
|
|
const schema_ptr& get_schema() const;
|
|
std::string_view get_op_name() const;
|
|
state get_state() const;
|
|
|
|
bool needs_readmission() const;
|
|
|
|
// Call only when needs_readmission() = true.
|
|
future<> wait_readmission();
|
|
|
|
resource_units consume_memory(size_t memory = 0);
|
|
|
|
resource_units consume_resources(reader_resources res);
|
|
|
|
future<resource_units> request_memory(size_t memory);
|
|
|
|
reader_resources consumed_resources() const;
|
|
|
|
reader_resources base_resources() const;
|
|
|
|
void release_base_resources() noexcept;
|
|
|
|
sstring description() const;
|
|
|
|
db::timeout_clock::time_point timeout() const noexcept;
|
|
|
|
void set_timeout(db::timeout_clock::time_point timeout) noexcept;
|
|
|
|
const tracing::trace_state_ptr& trace_state() const noexcept;
|
|
|
|
void set_trace_state(tracing::trace_state_ptr trace_ptr) noexcept;
|
|
|
|
// If the read was aborted, throw the exception the read was aborted with.
|
|
// Otherwise no-op.
|
|
void check_abort();
|
|
|
|
query::max_result_size max_result_size() const;
|
|
void set_max_result_size(query::max_result_size);
|
|
|
|
void on_start_sstable_read() noexcept;
|
|
void on_finish_sstable_read() noexcept;
|
|
|
|
uintptr_t id() { return reinterpret_cast<uintptr_t>(_impl.get()); }
|
|
};
|
|
|
|
using reader_permit_opt = optimized_optional<reader_permit>;
|
|
|
|
class reader_permit::resource_units {
|
|
reader_permit _permit;
|
|
reader_resources _resources;
|
|
|
|
friend class reader_permit;
|
|
friend class reader_concurrency_semaphore;
|
|
private:
|
|
class already_consumed_tag {};
|
|
resource_units(reader_permit permit, reader_resources res, already_consumed_tag);
|
|
resource_units(reader_permit permit, reader_resources res);
|
|
public:
|
|
resource_units(const resource_units&) = delete;
|
|
resource_units(resource_units&&) noexcept;
|
|
~resource_units();
|
|
resource_units& operator=(const resource_units&) = delete;
|
|
resource_units& operator=(resource_units&&) noexcept;
|
|
void add(resource_units&& o);
|
|
void reset_to(reader_resources res);
|
|
void reset_to_zero() noexcept;
|
|
reader_permit permit() const { return _permit; }
|
|
reader_resources resources() const { return _resources; }
|
|
};
|
|
|
|
std::ostream& operator<<(std::ostream& os, reader_permit::state s);
|
|
|
|
/// Mark a permit as needing CPU.
|
|
///
|
|
/// Conceptually, a permit is considered as needing CPU, when at least one reader
|
|
/// associated with it has an ongoing foreground operation initiated by
|
|
/// its consumer. E.g. a pending `fill_buffer()` call.
|
|
/// This class is an RAII need_cpu marker meant to be used by keeping it alive
|
|
/// while the reader is in need of CPU.
|
|
class reader_permit::need_cpu_guard {
|
|
reader_permit_opt _permit;
|
|
public:
|
|
explicit need_cpu_guard(reader_permit permit) noexcept : _permit(std::move(permit)) {
|
|
_permit->mark_need_cpu();
|
|
}
|
|
need_cpu_guard(need_cpu_guard&&) noexcept = default;
|
|
need_cpu_guard(const need_cpu_guard&) = delete;
|
|
~need_cpu_guard() {
|
|
if (_permit) {
|
|
_permit->mark_not_need_cpu();
|
|
}
|
|
}
|
|
need_cpu_guard& operator=(need_cpu_guard&&) = delete;
|
|
need_cpu_guard& operator=(const need_cpu_guard&) = delete;
|
|
};
|
|
|
|
/// Mark a permit as awaiting I/O or an operation running on a remote shard.
|
|
///
|
|
/// Conceptually, a permit is considered awaiting, when at least one reader
|
|
/// associated with it is waiting on I/O or a remote shard as part of a
|
|
/// foreground operation initiated by its consumer. E.g. an sstable reader
|
|
/// waiting on a disk read as part of its `fill_buffer()` call.
|
|
/// This class is an RAII awaits marker meant to be used by keeping it alive
|
|
/// until said awaited event completes.
|
|
class reader_permit::awaits_guard {
|
|
reader_permit_opt _permit;
|
|
public:
|
|
explicit awaits_guard(reader_permit permit) noexcept : _permit(std::move(permit)) {
|
|
_permit->mark_awaits();
|
|
}
|
|
awaits_guard(awaits_guard&&) noexcept = default;
|
|
awaits_guard(const awaits_guard&) = delete;
|
|
~awaits_guard() {
|
|
if (_permit) {
|
|
_permit->mark_not_awaits();
|
|
}
|
|
}
|
|
awaits_guard& operator=(awaits_guard&&) = delete;
|
|
awaits_guard& operator=(const awaits_guard&) = delete;
|
|
};
|
|
|
|
template <typename Char>
|
|
temporary_buffer<Char> make_tracked_temporary_buffer(temporary_buffer<Char> buf, reader_permit::resource_units units) {
|
|
return temporary_buffer<Char>(buf.get_write(), buf.size(), make_object_deleter(buf.release(), std::move(units)));
|
|
}
|
|
|
|
inline temporary_buffer<char> make_new_tracked_temporary_buffer(size_t size, reader_permit& permit) {
|
|
auto buf = temporary_buffer<char>(size);
|
|
return temporary_buffer<char>(buf.get_write(), buf.size(), make_object_deleter(buf.release(), permit.consume_memory(size)));
|
|
}
|
|
|
|
file make_tracked_file(file f, reader_permit p);
|
|
|
|
class tracking_allocator_base {
|
|
reader_permit _permit;
|
|
protected:
|
|
tracking_allocator_base(reader_permit permit) noexcept : _permit(std::move(permit)) { }
|
|
void consume(size_t memory) {
|
|
_permit.consume(reader_resources::with_memory(memory));
|
|
}
|
|
void signal(size_t memory) {
|
|
_permit.signal(reader_resources::with_memory(memory));
|
|
}
|
|
};
|
|
|
|
template <typename T>
|
|
class tracking_allocator : public tracking_allocator_base {
|
|
public:
|
|
using value_type = T;
|
|
using propagate_on_container_move_assignment = std::true_type;
|
|
using is_always_equal = std::false_type;
|
|
|
|
private:
|
|
std::allocator<T> _alloc;
|
|
|
|
public:
|
|
tracking_allocator(reader_permit permit) noexcept : tracking_allocator_base(std::move(permit)) { }
|
|
|
|
T* allocate(size_t n) {
|
|
auto p = _alloc.allocate(n);
|
|
try {
|
|
consume(n * sizeof(T));
|
|
} catch (...) {
|
|
_alloc.deallocate(p, n);
|
|
throw;
|
|
}
|
|
return p;
|
|
}
|
|
void deallocate(T* p, size_t n) {
|
|
_alloc.deallocate(p, n);
|
|
if (n) {
|
|
signal(n * sizeof(T));
|
|
}
|
|
}
|
|
|
|
template <typename U>
|
|
friend bool operator==(const tracking_allocator<U>& a, const tracking_allocator<U>& b);
|
|
};
|
|
|
|
template <typename T>
|
|
bool operator==(const tracking_allocator<T>& a, const tracking_allocator<T>& b) {
|
|
return a._semaphore == b._semaphore;
|
|
}
|