4ab4619341
Currently when running against a debug build, our integration test suite suffers from a ton of timeout related error logs, caused by auth queries timing out. This causes spurious test failures due to the unexpected error messages in the log. This patch increases the timeout for internal distributed auth queries in debug mode, to give the slow debug builds more headroom to meet the timeout. Refs: #6548 Signed-off-by: Botond Dénes <bdenes@scylladb.com> Message-Id: <20200811145757.1593350-1-bdenes@scylladb.com>
123 lines
4.2 KiB
C++
123 lines
4.2 KiB
C++
/*
|
|
* Copyright (C) 2017 ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "auth/common.hh"
|
|
|
|
#include <seastar/core/shared_ptr.hh>
|
|
|
|
#include "cql3/query_processor.hh"
|
|
#include "cql3/statements/create_table_statement.hh"
|
|
#include "database.hh"
|
|
#include "schema_builder.hh"
|
|
#include "service/migration_manager.hh"
|
|
#include "timeout_config.hh"
|
|
|
|
namespace auth {
|
|
|
|
namespace meta {
|
|
|
|
constexpr std::string_view AUTH_KS("system_auth");
|
|
constexpr std::string_view USERS_CF("users");
|
|
constexpr std::string_view AUTH_PACKAGE_NAME("org.apache.cassandra.auth.");
|
|
|
|
}
|
|
|
|
static logging::logger auth_log("auth");
|
|
|
|
// Func must support being invoked more than once.
|
|
future<> do_after_system_ready(seastar::abort_source& as, seastar::noncopyable_function<future<>()> func) {
|
|
struct empty_state { };
|
|
return delay_until_system_ready(as).then([&as, func = std::move(func)] () mutable {
|
|
return exponential_backoff_retry::do_until_value(1s, 1min, as, [func = std::move(func)] {
|
|
return func().then_wrapped([] (auto&& f) -> std::optional<empty_state> {
|
|
if (f.failed()) {
|
|
auth_log.debug("Auth task failed with error, rescheduling: {}", f.get_exception());
|
|
return { };
|
|
}
|
|
return { empty_state() };
|
|
});
|
|
});
|
|
}).discard_result();
|
|
}
|
|
|
|
static future<> create_metadata_table_if_missing_impl(
|
|
std::string_view table_name,
|
|
cql3::query_processor& qp,
|
|
std::string_view cql,
|
|
::service::migration_manager& mm) {
|
|
static auto ignore_existing = [] (seastar::noncopyable_function<future<>()> func) {
|
|
return futurize_invoke(std::move(func)).handle_exception_type([] (exceptions::already_exists_exception& ignored) { });
|
|
};
|
|
auto& db = qp.db();
|
|
auto parsed_statement = cql3::query_processor::parse_statement(cql);
|
|
auto& parsed_cf_statement = static_cast<cql3::statements::raw::cf_statement&>(*parsed_statement);
|
|
|
|
parsed_cf_statement.prepare_keyspace(meta::AUTH_KS);
|
|
|
|
auto statement = static_pointer_cast<cql3::statements::create_table_statement>(
|
|
parsed_cf_statement.prepare(db, qp.get_cql_stats())->statement);
|
|
|
|
const auto schema = statement->get_cf_meta_data(qp.db());
|
|
const auto uuid = generate_legacy_id(schema->ks_name(), schema->cf_name());
|
|
|
|
schema_builder b(schema);
|
|
b.set_uuid(uuid);
|
|
schema_ptr table = b.build();
|
|
return ignore_existing([&mm, table = std::move(table)] () {
|
|
return mm.announce_new_column_family(table, false);
|
|
});
|
|
}
|
|
|
|
future<> create_metadata_table_if_missing(
|
|
std::string_view table_name,
|
|
cql3::query_processor& qp,
|
|
std::string_view cql,
|
|
::service::migration_manager& mm) noexcept {
|
|
return futurize_invoke(create_metadata_table_if_missing_impl, table_name, qp, cql, mm);
|
|
}
|
|
|
|
future<> wait_for_schema_agreement(::service::migration_manager& mm, const database& db, seastar::abort_source& as) {
|
|
static const auto pause = [] { return sleep(std::chrono::milliseconds(500)); };
|
|
|
|
return do_until([&db, &as] {
|
|
as.check();
|
|
return db.get_version() != database::empty_version;
|
|
}, pause).then([&mm, &as] {
|
|
return do_until([&mm, &as] {
|
|
as.check();
|
|
return mm.have_schema_agreement();
|
|
}, pause);
|
|
});
|
|
}
|
|
|
|
const timeout_config& internal_distributed_timeout_config() noexcept {
|
|
#ifdef DEBUG
|
|
// Give the much slower debug tests more headroom for completing auth queries.
|
|
static const auto t = 30s;
|
|
#else
|
|
static const auto t = 5s;
|
|
#endif
|
|
static const timeout_config tc{t, t, t, t, t, t, t};
|
|
return tc;
|
|
}
|
|
|
|
}
|