Raphael S. Carvalho ef5681486f compaction: do not unconditionally delete a new sstable in interrupted compaction ...

After incremental compaction, new sstables may have already replaced old
sstables at any point. Meaning that a new sstable is in-use by table and
a old sstable is already deleted when compaction itself is UNFINISHED.
Therefore, we should *NEVER* delete a new sstable unconditionally for an
interrupted compaction, or data loss could happen.
To fix it, we'll only delete new sstables that didn't replace anything
in the table, meaning they are unused.

Found the problem while auditting the code.

Fixes #4479.

Signed-off-by: Raphael S. Carvalho <raphaelsc@scylladb.com>
Message-Id: <20190506134723.16639-1-raphaelsc@scylladb.com>

2019-05-06 16:55:36 +03:00

..

mc

sstables: provide large_data_handler to constructor

2019-03-26 16:24:19 +02:00

binary_search.hh

…

checksum_utils.hh

sstables: Use fast_crc_combine() in the default checksummer

2018-12-03 14:40:35 +01:00

column_name_helper.hh

Update seastar submodule

2018-11-21 00:01:44 +02:00

column_translation.hh

sstables: store column name in column_translation::column_info

2018-11-30 08:59:00 +01:00

compaction_backlog_manager.hh

…

compaction_manager.cc

compaction_manager: Add perform_sstable_scrub

2019-03-06 13:13:21 +00:00

compaction_manager.hh

compaction_manager: Add perform_sstable_scrub

2019-03-06 13:13:21 +00:00

compaction_strategy_impl.hh

Replace std::experimental types with C++17 std version.

2019-01-08 13:16:36 +02:00

compaction_strategy.cc

time_window_backlog_tracker: fix use after free

2019-05-05 12:47:51 +03:00

compaction_weight_registration.hh

…

compaction.cc

compaction: do not unconditionally delete a new sstable in interrupted compaction

2019-05-06 16:55:36 +03:00

compaction.hh

Replace std::experimental types with C++17 std version.

2019-01-08 13:16:36 +02:00

component_type.hh

…

compress.cc

Replace std::experimental types with C++17 std version.

2019-01-08 13:16:36 +02:00

compress.hh

sstables: compress.hh: add missing include

2019-03-26 16:05:08 +02:00

consumer.hh

sstable: pass full length of buffer to vint deserialiser

2019-03-14 13:37:06 +00:00

data_consume_context.hh

Delete data_consume_rows_at_once.

2018-11-27 14:11:50 +02:00

date_tiered_compaction_strategy.hh

Replace std::experimental types with C++17 std version.

2019-01-08 13:16:36 +02:00

disk_types.hh

…

downsampling.hh

…

exceptions.hh

sstables: convert sprint() to format()

2018-11-01 13:16:17 +00:00

filter.hh

…

hyperloglog.hh

…

index_entry.hh

sstables: Refactor predicates on bound_kind_m

2019-01-02 17:50:44 -08:00

index_reader.hh

sstable: handle missing index entry

2019-01-14 10:47:21 +01:00

integrity_checked_file_impl.cc

Switch to the the CMake-ified Seastar

2019-01-30 11:17:38 +02:00

integrity_checked_file_impl.hh

…

key.hh

Update seastar submodule

2018-11-21 00:01:44 +02:00

leveled_compaction_strategy.hh

Replace std::experimental types with C++17 std version.

2019-01-08 13:16:36 +02:00

leveled_manifest.hh

Replace std::experimental types with C++17 std version.

2019-01-08 13:16:36 +02:00

liveness_info.hh

sstables: mc: use proper gc_clock types for local_deletion_time and ttl

2019-01-22 15:34:32 +02:00

m_format_read_helpers.cc

vint: drop deserialize_type structure

2019-03-14 13:37:06 +00:00

m_format_read_helpers.hh

gc_clock: make 64 bit

2019-01-22 15:34:32 +02:00

metadata_collector.hh

sstables/metadata_collector: move the default values to the global tracker

2019-02-07 10:16:50 +00:00

mp_row_consumer.cc

sstables/counters: fix remote counter shard detection

2019-02-08 17:04:22 +00:00

mp_row_consumer.hh

sstables: mc: Write static compact tables the same way as Cassandra

2019-03-18 11:18:33 +01:00

mutation_fragment_filter.hh

Merge "Add more extensive test for mutation reader fast-forwarding" from Paweł

2018-12-20 15:05:21 +01:00

partition.cc

sstables: reader: Do not read the head of the partition when index can be used

2018-12-18 11:11:37 +01:00

prepended_input_stream.cc

…

prepended_input_stream.hh

…

progress_monitor.hh

…

random_access_reader.hh

…

remove.hh

…

row.hh

sstables: mc: use int64_t for local_deletion_time and ttl

2019-01-22 15:34:32 +02:00

segmented_compress_params.hh

…

shareable_components.hh

sstables: move shareable_components def to its own header

2019-03-26 16:05:08 +02:00

shared_index_lists.hh

…

shared_sstable.hh

…

size_tiered_backlog_tracker.hh

…

size_tiered_compaction_strategy.hh

…

sstable_set.hh

sstables: make partitioned sstable set available to custom compaction strategies

2019-04-25 12:59:04 +03:00

sstable_version_k_l.hh

…

sstable_version_m.hh

…

sstable_version.cc

…

sstable_version.hh

…

sstables_manager.cc

sstables: provide large_data_handler to constructor

2019-03-26 16:24:19 +02:00

sstables_manager.hh

sstables: provide large_data_handler to constructor

2019-03-26 16:24:19 +02:00

sstables.cc

sstables: make lamdas that std:move mutable

2019-04-21 18:11:42 +03:00

sstables.hh

sstables: make lamdas that std:move mutable

2019-04-21 18:11:42 +03:00

stats.hh

sstables: add capped_tombstone_deletion_time stats counter

2019-01-22 15:34:32 +02:00

time_window_compaction_strategy.hh

compaction: fix sstable_window_size calculation is only unit/size is set

2019-03-18 11:19:18 +02:00

types.hh

sstables: mc: Write static compact tables the same way as Cassandra

2019-03-18 11:18:33 +01:00

version.hh

Add sstable format helper methods

2019-04-12 09:33:40 +02:00

writer_impl.hh

sstables: Extract sstable_writer_impl to a header

2018-12-12 12:07:31 +01:00

writer.hh

sstables: checksummed_file_writer: fix dma alignment

2019-02-21 21:26:56 +01:00