0684dbb5bd
A `writer_node` contains a chain of multiple BTI nodes. `writer_node::_node_size` is the size (in bytes) of the entire chain. But the parent of the `writer_node` wants to know the offset to the rootmost node in the chain. This can be deduced from the `writer_node::_transition_length` and the `writer_node::_node_size`. But there's an error in the logic for that, for the special case when there are two nodes in the chain. The rootmost node will be SINGLE_NOPAYLOAD_12 if and only if *the leafmost node* is smaller than 16 bytes, which is true if and only if `_node_size` is smaller than 19 bytes. But the current logic compares `_node_size` against 16. That's incorrect. This patch fixes that. There was a test for this branch, but it was not good enough. It only tested payloads of size 1 and 20, but the problem is only revealed by payloads of size 13-14. The test has been extended to cover all sizes between 1 and 20.
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cqlpy - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.