mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-04-28 12:17:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
0752ef1481848db364fa82aee125a36ecbadfe8d
scylladb/test/boost
History
Michał Chojnowski 295b27a07b cache_flat_mutation_reader: only call get_iterator_in_latest() when pointing at a row 
Calling `_next_row.get_iterator_in_latest()` is illegal when `_next_row` is not
pointing at a row. In particular, the iterator returned by such call might be
dangling.

We have observed this to cause a use-after-free in the field, when a reverse
read called `maybe_add_to_cache` after `_latest_it` was left dangling after
a dead row removal in `copy_from_cache_to_buffer`.

To fix this, we should ensure that we only call `_next_row.get_iterator_in_latest`
is pointing at a row.

Only the occurrences of this problem in `maybe_add_to_cache` are truly dangerous.
As far as I can see, other occurrences can't break anything as of now.
But we apply fixes to them anyway.

Closes scylladb/scylladb#18046
2024-03-27 11:48:42 +01:00
..
aggregate_fcts_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
allocation_strategy_test.cc
…
alternator_unit_test.cc
…
anchorless_list_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
auth_passwords_test.cc
…
auth_resource_test.cc
auth: add fmt::format for auth::resource and friends
2024-01-15 13:26:39 +02:00
auth_test.cc
service:qos: service levels migration
2024-03-21 23:14:57 +01:00
batchlog_manager_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
big_decimal_test.cc
…
bptree_test.cc
…
broken_sstable_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
btree_test.cc
…
bytes_ostream_test.cc
…
cache_algorithm_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
cache_flat_mutation_reader_test.cc
test: add fmt::formatters
2024-02-23 10:52:12 +08:00
cached_file_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
caching_options_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
canonical_mutation_test.cc
…
cartesian_product_test.cc
…
castas_fcts_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cdc_generation_test.cc
…
cdc_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cell_locker_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
checksum_utils_test.cc
…
chunked_managed_vector_test.cc
…
chunked_vector_test.cc
…
clustering_ranges_walker_test.cc
…
CMakeLists.txt
interval: rename interval_test to wrapping_interval_test
2024-02-21 19:38:53 +02:00
column_mapping_test.cc
schema: add fmt::formatter for schema
2024-03-13 09:29:00 +02:00
commitlog_cleanup_test.cc
test: boost: add commitlog_cleanup_test
2024-01-24 10:37:39 +01:00
commitlog_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
compaction_group_test.cc
compaction: Check for key presence in memtable when calculating max purgeable timestamp
2024-03-18 13:37:44 +02:00
compound_test.cc
…
compress_test.cc
…
config_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
continuous_data_consumer_test.cc
reader_permit: store schema_ptr instead of raw schema pointer
2024-01-11 08:37:56 +02:00
counter_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_auth_query_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_auth_syntax_test.cc
…
cql_functions_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_query_group_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_query_large_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_query_like_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
cql_query_test.cc
./: not include unused headers
2024-03-20 09:16:46 +02:00
crc_test.cc
…
data_listeners_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
database_test.cc
replica/database: use include page-size in max-result-size
2024-02-27 02:27:55 -05:00
dirty_memory_manager_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
double_decker_test.cc
utils: do not include unused headers
2024-01-18 12:50:06 +02:00
duration_test.cc
…
dynamic_bitset_test.cc
…
enum_option_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
enum_set_test.cc
test/boost: add formatter for BOOST_REQUIRE_EQUAL
2024-03-15 09:40:22 +02:00
error_injection_test.cc
error_injection: allow injection handlers to not share messages
2024-03-21 14:35:38 +01:00
estimated_histogram_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
exception_container_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
exceptions_fallback_test.cc
…
exceptions_optimized_test.cc
…
exceptions_test.inc.cc
…
expr_test.cc
cql3: add fmt::formatter for raw_value{,_view}
2024-03-05 14:00:13 +08:00
extensions_test.cc
…
filtering_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
flat_mutation_reader_test.cc
treewide: Use partition_slice::is_reversed()
2024-03-13 08:52:46 +02:00
flush_queue_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
fragmented_temporary_buffer_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
frozen_mutation_test.cc
mutation: add fmt::formatter for clustering_row and friends
2024-02-22 17:53:34 +08:00
gossiping_property_file_snitch_test.cc
test/boost: add formatter for BOOST_REQUIRE_EQUAL
2024-03-17 16:58:39 +02:00
group0_cmd_merge_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
group0_test.cc
…
hash_test.cc
…
hashers_test.cc
reader_permit: store schema_ptr instead of raw schema pointer
2024-01-11 08:37:56 +02:00
hint_test.cc
commitlog: add formatter for db::replay_position
2024-01-29 09:59:30 +02:00
idl_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
index_with_paging_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
input_stream_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
intrusive_array_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
json_cql_query_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
json_test.cc
…
keys_test.cc
…
large_paging_state_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
like_matcher_test.cc
…
limiting_data_source_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
linearizing_input_stream_test.cc
…
lister_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
loading_cache_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
locator_topology_test.cc
raft topology: Keep nodes in the left state to topology
2024-03-15 11:05:29 +01:00
log_heap_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
logalloc_standard_allocator_segment_pool_backend_test.cc
…
logalloc_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
managed_bytes_test.cc
…
managed_vector_test.cc
…
map_difference_test.cc
…
memtable_test.cc
treewide: use fmt::to_string() to transform a UUID to std::string
2024-03-26 13:38:37 +08:00
multishard_combining_reader_as_mutation_source_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
multishard_mutation_query_test.cc
./: not include unused headers
2024-03-20 09:16:46 +02:00
murmur_hash_test.cc
…
mutation_fragment_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
mutation_query_test.cc
treewide: Use partition_slice::is_reversed()
2024-03-13 08:52:46 +02:00
mutation_reader_test.cc
treewide: Use partition_slice::is_reversed()
2024-03-13 08:52:46 +02:00
mutation_test.cc
mutation: add split_mutation function
2024-03-20 22:39:51 +04:00
mutation_writer_test.cc
test: Reduce mem footprint of test_token_group_based_splitting_mutation_writer
2024-02-07 09:21:24 +02:00
mvcc_test.cc
row_cache: use preemption_source in update()
2024-02-07 18:31:36 +01:00
network_topology_strategy_test.cc
utils: add fmt::formatter for std::strong_ordering and friends
2024-03-12 14:53:55 +08:00
nonwrapping_interval_test.cc
interval: rename nonwrapping_interval to interval
2024-02-21 19:43:17 +02:00
observable_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
partitioner_test.cc
range.hh: retire
2024-02-21 00:24:25 +02:00
per_partition_rate_limit_test.cc
…
pretty_printers_test.cc
utils/pretty_printers: add "I" specifier support
2024-01-11 14:33:47 +08:00
querier_cache_test.cc
range.hh: retire
2024-02-21 00:24:25 +02:00
query_processor_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
radix_tree_test.cc
…
range_assert.hh
…
range_tombstone_list_assertions.hh
…
range_tombstone_list_test.cc
clustering_bounds_comparator: add fmt::formtter for bound_{kind,view}
2024-03-11 11:37:48 +02:00
rate_limiter_test.cc
…
reader_concurrency_semaphore_test.cc
add fmt::formatter for reader_permit::state and reader_resources
2024-03-11 09:55:51 +02:00
recent_entries_map_test.cc
…
repair_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
restrictions_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
result_utils_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
reusable_buffer_test.cc
…
role_manager_test.cc
auth: add raft_group0_client as dependency
2024-03-01 16:25:14 +01:00
row_cache_test.cc
cache_flat_mutation_reader: only call get_iterator_in_latest() when pointing at a row
2024-03-27 11:48:42 +01:00
rust_test.cc
…
s3_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
schema_change_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
schema_changes_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
schema_loader_test.cc
test/boost/schema_loader_test: add test for mvs and indexes
2024-01-04 03:20:17 -05:00
schema_registry_test.cc
treewide: don't #include "gms/feature_service.hh" from other headers
2024-03-26 15:31:18 +02:00
secondary_index_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
serialization_test.cc
…
serialized_action_test.cc
…
service_level_controller_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
sessions_test.cc
…
small_vector_test.cc
…
snitch_reset_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
sstable_3_x_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
sstable_compaction_test.cc
test/boost/sstable_compaction_test: add validation test with valid sstable
2024-03-12 11:05:18 -04:00
sstable_conforms_to_mutation_source_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
sstable_datafile_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_directory_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_generation_test.cc
…
sstable_move_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_mutation_test.cc
interval: rename nonwrapping_interval to interval
2024-02-21 19:43:17 +02:00
sstable_partition_index_cache_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_resharding_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
sstable_set_test.cc
…
sstable_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
sstable_test.hh
…
stall_free_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
statement_restrictions_test.cc
…
storage_proxy_test.cc
test/storage_proxy: Restore indentation after previous patch
2024-03-12 19:10:44 +03:00
string_format_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
suite.yaml
test: boost: add commitlog_cleanup_test
2024-01-24 10:37:39 +01:00
summary_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
tablets_test.cc
test: tablets: Avoid infinite loop in rebalance_tablets()
2024-03-21 10:19:46 +01:00
tagged_integer_test.cc
…
token_metadata_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
top_k_test.cc
…
total_order_check.hh
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
tracing_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
transport_test.cc
…
types_test.cc
treewide: use fmt::to_string() to transform a UUID to std::string
2024-03-26 13:38:37 +08:00
user_function_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
user_types_test.cc
test_invalid_user_type_statements: increase raft timeout
2024-03-25 14:52:16 +01:00
utf8_test.cc
…
UUID_test.cc
treewide: use fmt::to_string() to transform a UUID to std::string
2024-03-26 13:38:37 +08:00
view_build_test.cc
interval: rename nonwrapping_interval to interval
2024-02-21 19:43:17 +02:00
view_complex_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
view_schema_ckey_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
view_schema_pkey_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
view_schema_test.cc
treewide: replace seastar::future::get0() with seastar::future::get()
2024-02-02 22:12:57 +08:00
vint_serialization_test.cc
…
virtual_reader_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
virtual_table_mutation_source_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
virtual_table_test.cc
test/boost: do not include unused headers
2024-02-06 13:22:16 +02:00
wasm_alloc_test.cc
…
wasm_test.cc
…
wrapping_interval_test.cc
interval: rename nonwrapping_interval to interval
2024-02-21 19:43:17 +02:00