075ca6cc02
Currently, PER PARTITION LIMIT is not implemented for aggregates and queries can result in more rows than expected from the same partition. Instrument the result_set_builder class so that it can enforce PER PARTITION LIMIT for aggregate queries, specifically: - add per_partition_limit to the result_set_builder - expose the number of input rows in the selector result_set_builder gets two new functions handling partition start and end: - accept_partition_end for notifying that a partition has been finished. This is also called when a page ends, so we cannot simply flush here, as a naive implementation could do. - accept_new_partition, where we flush_selectors() if it's indeed a new partition (and not a continuation of the previous) and the query has a grouping: we don't want to flush on new partition in a query like SELECT COUNT(*) FROM foo; Fixes #5363 Closes scylladb/scylladb#21125 * github.com:scylladb/scylladb: test: enable PER PARTIION LIMIT + GROUP BY tests cql3: respect PER PARTITION LIMIT for aggregates cql3: selection: count input rows in the selector cql3: selection: pass per partition limit to the result_set_builder cql3: show different messages for LIMIT and PER PARTITION LIMIT in get_limit
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cqlpy - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.