fd6b5efe75
In storage_service's snapshot code there are checks for _operation_mode being _not_ JOINING to proceed. The intention is apparently to allow for snapshots only after the cluster join. However, here's how the start-up code looks like - _operation_mode = STARTING in storage_service::constructor - snapshot API registered in api::set_server_storage_service - _operation_mode = JOINING in storage_service::join_token_ring So in between steps 2 and 3 snapshots can be taken. Although there's a quick and simple fix for that (check for the _operation_mode to be not STARTING either) I think it's better to register the snapshot API later instead. This will help greatly to de-bload the storage_service, in particular -- to incapsulate the _operation_mode properly. Note, though the check for _operation_mode is made only for taking snapshot, I move all snapshot ops registration to the later phase. Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
58 lines
1.9 KiB
C++
58 lines
1.9 KiB
C++
/*
|
|
* Copyright 2016 ScylaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
#pragma once
|
|
#include "database_fwd.hh"
|
|
#include "service/storage_proxy.hh"
|
|
#include <seastar/http/httpd.hh>
|
|
|
|
namespace service { class load_meter; }
|
|
|
|
namespace api {
|
|
|
|
struct http_context {
|
|
sstring api_dir;
|
|
sstring api_doc;
|
|
httpd::http_server_control http_server;
|
|
distributed<database>& db;
|
|
distributed<service::storage_proxy>& sp;
|
|
service::load_meter& lmeter;
|
|
http_context(distributed<database>& _db,
|
|
distributed<service::storage_proxy>& _sp,
|
|
service::load_meter& _lm)
|
|
: db(_db), sp(_sp), lmeter(_lm) {
|
|
}
|
|
};
|
|
|
|
future<> set_server_init(http_context& ctx);
|
|
future<> set_server_snitch(http_context& ctx);
|
|
future<> set_server_storage_service(http_context& ctx);
|
|
future<> set_server_snapshot(http_context& ctx);
|
|
future<> set_server_gossip(http_context& ctx);
|
|
future<> set_server_load_sstable(http_context& ctx);
|
|
future<> set_server_messaging_service(http_context& ctx);
|
|
future<> set_server_storage_proxy(http_context& ctx);
|
|
future<> set_server_stream_manager(http_context& ctx);
|
|
future<> set_server_gossip_settle(http_context& ctx);
|
|
future<> set_server_cache(http_context& ctx);
|
|
future<> set_server_done(http_context& ctx);
|
|
|
|
}
|