mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-26 19:35:12 +00:00
75b55cea88
" This patchseries is part of my effort to make resharding less special - and hopefully less problematic. The next steps are a bit heavy, so I'd like to, if possible, get this out of the way. After these two patches, there is no more need to ever call reshard_sstables: compact_sstables will do, and it will be able to recognize resharding compactions. To do that we need to unify the creator function, which is trivially done by adding a shard parameter to regular compactions as well: they can just ignore it. I have considered just making the compaction_descriptor have a virtual create() function and specializing it, but because we have to store the creator in the compaction object I decided to keep the virtual function for now. In a later cleanup step, if we can for instance store the entire compaction_descriptor object in the compaction object we could do that. Reviewed-by: Benny Halevy <bhalevy@scylladb.com> Reviewed-by: Raphael S. Carvalho <raphaelsc@scylladb.com> Reviewed-by: Botond Dénes <bdenes@scylladb.com> Tests: unit tests (dev), dtest (resharding.py) " * 'resharding-through-compact-sstables' of github.com:glommer/scylla: resharding: get rid of special reshard_sstables compaction: enhance compaction_descriptor with creator and replace function