mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
09a71ccd84ce76d01aba5bd74a35b2733f7372e2
scylladb/test/boost
History
Nadav Har'El 09a71ccd84 merge: cql3/restrictions: exclude NULLs from comparison in filtering 
Merge pull request https://github.com/scylladb/scylla/pull/6834 by
Juliusz Stasiewicz:

NULLs used to give false positives in GT, LT, GEQ and LEQ ops performed upon
ALLOW FILTERING. That was a consequence of not distinguishing NULL from an
empty buffer.

This patch excludes NULLs on high level, preventing them from entering LHS
of any comparison, i.e. it assumes that any binary operation should return
false whenever the LHS operand is NULL (note: at the moment filters with
RHS NULL, such as ...WHERE x=NULL ALLOW FILTERING, return empty sets anyway).

Fixes #6295

* '6295-do-not-compare-nulls-v2' of github.com:jul-stas/scylla:
  filtering_test: check that NULLs do not compare to normal values
  cql3/restrictions: exclude NULLs from comparison in filtering
2020-07-15 18:32:14 +03:00
..
aggregate_fcts_test.cc
tests: Test min/max on set
2020-07-08 13:39:15 +02:00
allocation_strategy_test.cc
…
alternator_base64_test.cc
build: Be consistent about system versus regular headers
2020-06-10 15:49:51 +03:00
anchorless_list_test.cc
…
auth_passwords_test.cc
…
auth_resource_test.cc
…
auth_test.cc
…
batchlog_manager_test.cc
treewide: propagate trace state to write path
2020-05-18 16:05:23 +02:00
big_decimal_test.cc
big_decimal: Add a test for a corner case
2020-06-25 15:37:23 -07:00
bptree_test.cc
utils: B+ tree implementation
2020-07-14 16:29:43 +03:00
broken_sstable_test.cc
treewide: remove all uses of no_reader_permit()
2020-05-28 11:34:35 +03:00
bytes_ostream_test.cc
test: stop using BOOST_TEST_MESSAGE() for logging
2020-03-05 11:38:11 +03:00
cache_flat_mutation_reader_test.cc
row_cache: pass a valid permit to underlying read
2020-05-28 11:34:35 +03:00
cached_file_test.cc
utils: Introduce cached_file
2020-06-16 16:15:23 +02:00
caching_options_test.cc
…
canonical_mutation_test.cc
…
cartesian_product_test.cc
…
castas_fcts_test.cc
big_decimal: Add more tests
2020-07-03 08:24:41 +02:00
cdc_test.cc
cdc: implement pre/postimage persistence
2020-07-08 15:36:41 +02:00
cell_locker_test.cc
…
checksum_utils_test.cc
everywhere: Don't assume sstring::begin() and sstring::end() are pointers
2020-03-10 13:13:48 -07:00
chunked_vector_test.cc
…
clustering_ranges_walker_test.cc
…
commitlog_test.cc
memtable: pass a valid permit to the delegate reader
2020-05-28 11:34:35 +03:00
compound_test.cc
compound_type: implement validate()
2020-05-07 16:19:56 +03:00
compress_test.cc
…
config_test.cc
test: move config to heap in config_test
2020-04-09 11:22:49 +02:00
continuous_data_consumer_test.cc
treewide: remove all uses of no_reader_permit()
2020-05-28 11:34:35 +03:00
counter_test.cc
…
cql_auth_query_test.cc
…
cql_auth_syntax_test.cc
cql3: return raw::parsed_statement as unique_ptr
2020-03-23 23:19:21 +03:00
cql_functions_test.cc
test: Split cql_query_test
2020-03-16 20:27:45 +03:00
cql_query_group_test.cc
test: Split cql_query_test
2020-03-16 20:27:45 +03:00
cql_query_large_test.cc
test: Split cql_query_test
2020-03-16 20:27:45 +03:00
cql_query_like_test.cc
cql3/restrictions: Use free functions instead of methods
2020-07-07 23:08:09 +02:00
cql_query_test.cc
cql_query_test: Drop get() on cquery_nofail result
2020-07-09 13:52:52 +03:00
crc_test.cc
…
data_listeners_test.cc
test: stop using BOOST_TEST_MESSAGE() for logging
2020-03-05 11:38:11 +03:00
database_test.cc
snap: Get rid of storage_service reference in schema.cc
2020-06-26 20:28:25 +03:00
double_decker_test.cc
double-decker: A combination of B+tree with array
2020-07-14 16:29:53 +03:00
duration_test.cc
…
dynamic_bitset_test.cc
tests: dynamic_bitset_test: don't exhaust random number entropy
2020-05-26 20:46:45 +03:00
enum_option_test.cc
…
enum_set_test.cc
…
error_injection_test.cc
utils: add timeout error injection with lambda
2020-06-03 14:44:00 +02:00
estimated_histogram_test.cc
approx_exponential_histogram: Makes the implementation clearer
2020-06-18 14:18:21 +03:00
extensions_test.cc
db::extensions: add shorthands for add_schema_extension
2020-03-05 16:09:44 +01:00
filtering_test.cc
…
flat_mutation_reader_test.cc
flat_mutation_reader: flat_multi_range_reader: add reader_permit parameter
2020-05-28 11:34:35 +03:00
flush_queue_test.cc
everywhere: Prepare for seastar api v4 (when_all_succeed return value)
2020-06-18 15:13:56 +03:00
fragmented_temporary_buffer_test.cc
…
frozen_mutation_test.cc
…
gossip_test.cc
auth: Move away from storage_service
2020-06-12 22:14:33 +03:00
gossiping_property_file_snitch_test.cc
treewide: replace calls to engine().some_api() with some_api()
2020-04-05 12:46:04 +03:00
hash_test.cc
…
idl_test.cc
…
index_with_paging_test.cc
test: Split secondary_index test
2020-03-16 20:26:34 +03:00
input_stream_test.cc
…
intrusive_array_test.cc
intrusive-array: Array with trusted bounds
2020-07-14 16:29:49 +03:00
json_cql_query_test.cc
treewide: use utils::multiprecision_int for varint implementation
2020-03-04 13:28:16 +02:00
json_test.cc
test: move json tests from manual/ to boost/
2020-07-06 11:24:12 +03:00
keys_test.cc
…
like_matcher_test.cc
tests: like_matcher_test: adjust for C++20 char8_t
2020-05-13 09:37:39 +03:00
limiting_data_source_test.cc
…
linearizing_input_stream_test.cc
test: stop using BOOST_TEST_MESSAGE() for logging
2020-03-05 11:38:11 +03:00
loading_cache_test.cc
tests: loading_cache_test: don't exhaust random number entropy
2020-05-26 20:49:58 +03:00
log_heap_test.cc
…
logalloc_test.cc
logalloc: fix entropy depletion in test_compaction_with_multiple_regions()
2020-05-27 15:51:16 +03:00
managed_vector_test.cc
…
map_difference_test.cc
…
memtable_test.cc
memtable: pass a valid permit to the delegate reader
2020-05-28 11:34:35 +03:00
meta_test.cc
…
multishard_combining_reader_as_mutation_source_test.cc
test: move away from reader_concurrency_semaphore::wait_admission()
2020-05-28 11:34:35 +03:00
multishard_mutation_query_test.cc
test/multishard_mutation_query_test: eliminate another unsafely used boost test macro
2020-05-31 16:08:02 +03:00
murmur_hash_test.cc
…
mutation_fragment_test.cc
memtable: pass a valid permit to the delegate reader
2020-05-28 11:34:35 +03:00
mutation_query_test.cc
build: Be consistent about system versus regular headers
2020-06-10 15:49:51 +03:00
mutation_reader_test.cc
mutation_reader_test: Wait for a future
2020-07-03 08:24:41 +02:00
mutation_test.cc
memtable: pass a valid permit to the delegate reader
2020-05-28 11:34:35 +03:00
mutation_writer_test.cc
mutation_writer_test: Add test_multishard_writer_producer_aborts
2020-04-22 16:28:07 +08:00
mvcc_test.cc
test: stop using BOOST_TEST_MESSAGE() for logging
2020-03-05 11:38:11 +03:00
network_topology_strategy_test.cc
tests: remove unused murmur3 includes
2020-03-15 10:25:20 +01:00
nonwrapping_range_test.cc
…
observable_test.cc
…
partitioner_test.cc
dht: Add find_first_token_for_shard
2020-04-22 18:24:54 +02:00
querier_cache_test.cc
querier_cache: get semaphore from querier
2020-05-28 11:34:35 +03:00
query_processor_test.cc
test: make schema changes in query_processor_test global
2020-07-07 09:09:40 +02:00
range_assert.hh
…
range_test.cc
range_test: Add cases for singular intersection
2020-06-18 12:38:31 +03:00
range_tombstone_list_assertions.hh
…
range_tombstone_list_test.cc
test: stop using BOOST_TEST_MESSAGE() for logging
2020-03-05 11:38:11 +03:00
restrictions_test.cc
filtering_test: check that NULLs do not compare to normal values
2020-07-14 15:37:17 +02:00
reusable_buffer_test.cc
test: stop using BOOST_TEST_MESSAGE() for logging
2020-03-05 11:38:11 +03:00
role_manager_test.cc
…
row_cache_test.cc
treewide: remove all uses of no_reader_permit()
2020-05-28 11:34:35 +03:00
schema_change_test.cc
test: improve comments on test_schema_digest_does_not_change
2020-06-05 14:30:02 +02:00
schema_changes_test.cc
treewide: remove all uses of no_reader_permit()
2020-05-28 11:34:35 +03:00
schema_registry_test.cc
test: move config to heap in schema_registry_test
2020-03-25 14:19:30 +01:00
secondary_index_test.cc
test: add cases for empty paging state for index queries
2020-04-06 08:59:40 +02:00
serialization_test.cc
gms::inet_address: Fix sign extension error in custom address formatting
2020-04-12 17:48:44 +03:00
serialized_action_test.cc
…
small_vector_test.cc
…
snitch_reset_test.cc
…
sstable_3_x_test.cc
sstable_3_x_test: Call await_background_jobs on every test
2020-06-22 14:03:13 +03:00
sstable_conforms_to_mutation_source_test.cc
test: Split sstable_mutation_test
2020-03-16 20:26:34 +03:00
sstable_datafile_test.cc
sstables: optimize procedure that checks if a sstable needs cleanup
2020-06-30 12:58:43 +03:00
sstable_directory_test.cc
distributed_load: initial handling of off-strategy SSTables
2020-06-08 16:06:00 -04:00
sstable_mutation_test.cc
treewide: remove all uses of no_reader_permit()
2020-05-28 11:34:35 +03:00
sstable_resharding_test.cc
distributed_loader: reshard before the node is made online
2020-06-18 09:37:18 -04:00
sstable_run_based_compaction_strategy_for_tests.hh
compaction: Enable tombstone expiration based on the presence of the sstable set
2020-06-07 11:46:48 +03:00
sstable_test.cc
everywhere: Move to seastar api level 3
2020-06-03 10:32:46 -07:00
sstable_test.hh
test/boost/sstable_test.hh: move generic stuff to test/lib/sstable_utils.hh
2020-03-23 09:29:45 +02:00
storage_proxy_test.cc
…
suite.yaml
Update seastar submodule
2020-06-23 19:39:54 +03:00
test_table.cc
test: consistently use a global testlog object in all tests
2020-03-05 13:34:24 +03:00
top_k_test.cc
…
total_order_check.hh
test: stop using BOOST_TEST_MESSAGE() for logging
2020-03-05 11:38:11 +03:00
transport_test.cc
…
truncation_migration_test.cc
…
types_test.cc
build: Be consistent about system versus regular headers
2020-06-10 15:49:51 +03:00
user_function_test.cc
user_function_test: Test UDF without the corresponding experimental flag
2020-04-03 20:00:24 +02:00
user_types_test.cc
cql3/restrictions: Use free functions instead of methods
2020-07-07 23:08:09 +02:00
utf8_test.cc
…
UUID_test.cc
…
view_build_test.cc
db/view: view_update_generator: re-balance wait/signal on the register semaphore
2020-07-07 08:53:00 +02:00
view_complex_test.cc
…
view_schema_ckey_test.cc
test: Split view_schema_test
2020-03-16 20:27:45 +03:00
view_schema_pkey_test.cc
test: Split view_schema_test
2020-03-16 20:27:45 +03:00
view_schema_test.cc
test: Split view_schema_test
2020-03-16 20:27:45 +03:00
vint_serialization_test.cc
…
virtual_reader_test.cc
…