mirror of
https://github.com/scylladb/scylladb.git
synced 2026-06-05 22:43:15 +00:00
a51529dd15
In early versions of the series which proposed protocol servers, the interface had two methods answering pretty much the same question of whether the server is running or not: * listen_addresses(): empty list -> server not running * is_server_running() To reduce redundancy and to avoid possible inconsistencies between the two methods, `is_server_running()` was scrapped, but re-added by a follow-up patch because `listen_addresses()` proved to be unreliable as a source for whether the server is running or not. This patch restores the previous state of having only `listen_addresses()` with two additional changes: * rephrase the comment on `listen_addresses()` to make it clear that implementations must return empty list when the server is not running; * those implementations that have a reliable source of whether the server is running or not, use it to force-return an empty list when the server is not running Tests: dtest(nodetool_additional_test.py) Signed-off-by: Botond Dénes <bdenes@scylladb.com> Message-Id: <20211117062539.16932-1-bdenes@scylladb.com>
83 lines
2.8 KiB
C++
83 lines
2.8 KiB
C++
/*
|
|
* Copyright (C) 2020-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* This file is part of Scylla.
|
|
*
|
|
* Scylla is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Scylla is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <seastar/core/semaphore.hh>
|
|
#include <seastar/core/sharded.hh>
|
|
#include <seastar/core/future.hh>
|
|
|
|
#include "protocol_server.hh"
|
|
|
|
using namespace seastar;
|
|
|
|
namespace auth { class service; }
|
|
namespace service {
|
|
class migration_notifier;
|
|
class endpoint_lifecycle_notifier;
|
|
class memory_limiter;
|
|
}
|
|
namespace gms { class gossiper; }
|
|
namespace cql3 { class query_processor; }
|
|
namespace qos { class service_level_controller; }
|
|
namespace db { class config; }
|
|
|
|
namespace cql_transport {
|
|
|
|
class cql_server;
|
|
class controller : public protocol_server {
|
|
std::vector<socket_address> _listen_addresses;
|
|
std::unique_ptr<sharded<cql_server>> _server;
|
|
semaphore _ops_sem; /* protects start/stop operations on _server */
|
|
bool _stopped = false;
|
|
|
|
sharded<auth::service>& _auth_service;
|
|
sharded<service::migration_notifier>& _mnotifier;
|
|
sharded<service::endpoint_lifecycle_notifier>& _lifecycle_notifier;
|
|
gms::gossiper& _gossiper;
|
|
sharded<cql3::query_processor>& _qp;
|
|
sharded<service::memory_limiter>& _mem_limiter;
|
|
sharded<qos::service_level_controller>& _sl_controller;
|
|
const db::config& _config;
|
|
|
|
future<> set_cql_ready(bool ready);
|
|
future<> do_start_server();
|
|
future<> do_stop_server();
|
|
|
|
future<> subscribe_server(sharded<cql_server>& server);
|
|
future<> unsubscribe_server(sharded<cql_server>& server);
|
|
|
|
public:
|
|
controller(sharded<auth::service>&, sharded<service::migration_notifier>&, gms::gossiper&,
|
|
sharded<cql3::query_processor>&, sharded<service::memory_limiter>&,
|
|
sharded<qos::service_level_controller>&, sharded<service::endpoint_lifecycle_notifier>&,
|
|
const db::config& cfg);
|
|
virtual sstring name() const override;
|
|
virtual sstring protocol() const override;
|
|
virtual sstring protocol_version() const override;
|
|
virtual std::vector<socket_address> listen_addresses() const override;
|
|
virtual future<> start_server() override;
|
|
virtual future<> stop_server() override;
|
|
virtual future<> request_stop_server() override;
|
|
};
|
|
|
|
} // namespace cql_transport
|