38d94475f2
While this isn't strictly needed for anything, messaging_service is supposed to clear its RPC connection objects on stop, for debuggability reasons. But a recent change in this area broke that. std::bind creates copies of its arguments, so the `m.clear()` statement in stop_client() only clears a copy of the vector of shared pointers, instead of clearing the original vector. This patch fixes that. Fixes #22245 Closes scylladb/scylladb#22333