mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
0b5217052d290e9867b46f4015d2084ec6a2ccf3
scylladb/cql3/statements
History
Avi Kivity 8ab20bae68 Merge 'prepared_statements: Invalidate batch statement too' from Eliran Sinvani 
It seams that batch prepared statements always return false for
depends_on_keyspace and depends_on_column_family, this in turn
renders the removal criteria from the cache to always be false
which result by the queries not being evicted.
Here we change the functions to return the true state meaning,
they will return true if any of the sub queries is dependant upon
the keyspace or column family.

In this fix we first make the API more coherent and then use this new API to implement
the batch statement's dependency test.
Fixes #10129

Signed-off-by: Eliran Sinvani <eliransin@scylladb.com>

Closes #10132

* github.com:scylladb/scylla:
  prepared_statements: Invalidate batch statement too
  cql3 statements: Change dependency test API to express better it's purpose
2022-03-07 14:00:05 +02:00
..
raw
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alter_keyspace_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
alter_keyspace_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
alter_role_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alter_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alter_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alter_table_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
alter_table_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
alter_type_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
alter_type_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
alter_view_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
alter_view_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
attach_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
attach_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
authentication_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
authentication_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
authorization_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
authorization_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
batch_statement.cc
prepared_statements: Invalidate batch statement too
2022-02-27 11:48:03 +02:00
batch_statement.hh
Merge 'prepared_statements: Invalidate batch statement too' from Eliran Sinvani
2022-03-07 14:00:05 +02:00
bound.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cas_request.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cas_request.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cf_prop_defs.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cf_prop_defs.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cf_properties.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cf_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
create_aggregate_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_aggregate_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_function_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_function_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_index_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_index_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_keyspace_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_keyspace_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_role_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
create_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
create_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
create_table_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_table_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_type_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_type_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_view_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
create_view_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
delete_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
delete_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
detach_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
detach_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_aggregate_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_aggregate_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_function_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_function_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_index_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_index_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_keyspace_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_keyspace_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_role_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
drop_table_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_table_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_type_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_type_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_view_statement.cc
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
drop_view_statement.hh
treewide: pass mutation timestamp from call sites into migration_manager::prepare_* functions
2022-01-24 15:12:50 +01:00
function_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
function_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
grant_role_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
grant_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
grant_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
index_prop_defs.cc
cross-tree: split coordinator_result from exceptions.hh
2022-03-02 10:12:57 +02:00
index_prop_defs.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
index_target.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
index_target.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
ks_prop_defs.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
ks_prop_defs.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_permissions_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_permissions_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_roles_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_service_level_attachments_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_service_level_attachments_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_service_level_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_service_level_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_users_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
list_users_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
modification_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
modification_statement.hh
Merge 'prepared_statements: Invalidate batch statement too' from Eliran Sinvani
2022-03-07 14:00:05 +02:00
permission_altering_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
permission_altering_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
prepared_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
property_definitions.cc
cross-tree: split coordinator_result from exceptions.hh
2022-03-02 10:12:57 +02:00
property_definitions.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
request_validations.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
revoke_role_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
revoke_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
revoke_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
role-management-statements.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
schema_altering_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
schema_altering_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
select_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
select_statement.hh
Merge 'prepared_statements: Invalidate batch statement too' from Eliran Sinvani
2022-03-07 14:00:05 +02:00
service_level_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
service_level_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
sl_prop_defs.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
sl_prop_defs.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
statement_type.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
truncate_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
truncate_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
update_statement.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
update_statement.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
use_statement.cc
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00
use_statement.hh
cql3 statements: Change dependency test API to express better it's
2022-02-27 11:48:03 +02:00