Files
scylladb/utils/logalloc.cc
Avi Kivity 99d5355007 Merge "Cache sstable indexes in memory" from Tomasz
"
The main goal of this series is to improve efficiency of reads from large partitions by
reducing amount of I/O needed to read the sstable index. This is achieved by caching
index file pages and partition index entries in memory.

Currently, the pages are cached by individual reads only for the duration of the read.
This was done to facilitate binary search in the promoted index (intra-partition index).
After this series, all reads share the index file page cache, which stays around even after reads stop.

The page cache is subject to eviction. It uses the same region as the current row cache and shares
the LRU with row cache entries. This means that LRU objects need to be virtualized. This series takes
an easy approach and does this by introducing a virtual base class. This adds an overhead to row cache
entry to store the vtable pointer.

SStable indexes have a hierarchy. There is a summary, which is a sparse partition key index into the
full partition index. This one is already kept in memory. The partition index is divided by the summary
into pages. Each entry in the partition index contains promoted index, which is a sparse index into atoms
identified by the clustering key (rows, tombstones).

In order to read the promoted index, the reader needs to read the partition index entry first.
To speed this up, this series also adds caching of partition index entries. This cache survives
reads and is subject to eviction, just like the index file page cache. The unit of caching is
the partition index page. Without this cache, each access to promoted index would have to be
preceded with the parsing of the partition index page containing the partition key.

Performance testing results follow.

1) scylla-bench large partition reads

  Populated with:

        perf_fast_forward --run-tests=large-partition-skips --datasets=sb-large-part-ds1 \
            -c1 -m1G --populate --value-size=1024 --rows=10000000

  Single partition, 9G data file, 4MB index file

  Test execution:

    build/release/scylla -c1 -m4G
    scylla-bench -workload uniform -mode read -limit 1 -concurrency 100 -partition-count 1 \
       -clustering-row-count 10000000 -duration 60m

  TL;DR: after: 2x throughput, 0.5 median latency

    Before (c1daf2bb24):

    Results
    Time (avg):	 5m21.033180213s
    Total ops:	 966951
    Total rows:	 966951
    Operations/s:	 3011.997048812112
    Rows/s:		 3011.997048812112
    Latency:
      max:		 74.055679ms
      99.9th:	 63.569919ms
      99th:		 41.320447ms
      95th:		 38.076415ms
      90th:		 37.158911ms
      median:	 34.537471ms
      mean:		 33.195994ms

    After:

    Results
    Time (avg):	 5m14.706669345s
    Total ops:	 2042831
    Total rows:	 2042831
    Operations/s:	 6491.22243800942
    Rows/s:		 6491.22243800942
    Latency:
      max:		 60.096511ms
      99.9th:	 35.520511ms
      99th:		 27.000831ms
      95th:		 23.986175ms
      90th:		 21.659647ms
      median:	 15.040511ms
      mean:		 15.402076ms

2) scylla-bench small partitions

  I tested several scenarios with a varying data set size, e.g. data fully fitting in memory,
  half fitting, and being much larger. The improvement varied a bit but in all cases the "after"
  code performed slightly better.

  Below is a representative run over data set which does not fit in memory.

  scylla -c1 -m4G
  scylla-bench -workload uniform -mode read  -concurrency 400 -partition-count 10000000 \
      -clustering-row-count 1 -duration 60m -no-lower-bound

  Before:

    Time (avg):	 51.072411913s
    Total ops:	 3165885
    Total rows:	 3165885
    Operations/s:	 61988.164024260645
    Rows/s:		 61988.164024260645
    Latency:
      max:		 34.045951ms
      99.9th:	 25.985023ms
      99th:		 23.298047ms
      95th:		 19.070975ms
      90th:		 17.530879ms
      median:	 3.899391ms
      mean:		 6.450616ms

  After:

    Time (avg):	 50.232410679s
    Total ops:	 3778863
    Total rows:	 3778863
    Operations/s:	 75227.58014424688
    Rows/s:		 75227.58014424688
    Latency:
      max:		 37.027839ms
      99.9th:	 24.805375ms
      99th:		 18.219007ms
      95th:		 14.090239ms
      90th:		 12.124159ms
      median:	 4.030463ms
      mean:		 5.315111ms

  The results include the warmup phase which populates the partition index cache, so the hot-cache effect
  is dampened in the statistics. See the 99th percentile. Latency gets better after the cache warms up which
  moves it lower.

3) perf_fast_forward --run-tests=large-partition-skips

    Caching is not used here, included to show there are no regressions for the cold cache case.

    TL;DR: No significant change

    perf_fast_forward --run-tests=large-partition-skips --datasets=large-part-ds1 -c1 -m1G

    Config: rows: 10000000, value size: 2000

    Before:

    read    skip      time (s)   iterations     frags     frag/s    mad f/s    max f/s    min f/s    avg aio    aio      (KiB) blocked dropped  idx hit idx miss  idx blk    c hit   c miss    c blk    cpu
    1       0        36.429822            4  10000000     274500         62     274521     274429   153889.2 153883   19696986  153853       0        0        0        0        0        0        0  22.5%
    1       1        36.856236            4   5000000     135662          7     135670     135650   155652.0 155652   19704117  139326       1        0        1        1        0        0        0  38.1%
    1       8        36.347667            4   1111112      30569          0      30570      30569   155652.0 155652   19704117  139071       1        0        1        1        0        0        0  19.5%
    1       16       36.278866            4    588236      16214          1      16215      16213   155652.0 155652   19704117  139073       1        0        1        1        0        0        0  16.6%
    1       32       36.174784            4    303031       8377          0       8377       8376   155652.0 155652   19704117  139056       1        0        1        1        0        0        0  12.3%
    1       64       36.147104            4    153847       4256          0       4256       4256   155652.0 155652   19704117  139109       1        0        1        1        0        0        0  11.1%
    1       256       9.895288            4     38911       3932          1       3933       3930   100869.2 100868    3178298   59944   38912        0        1        1        0        0        0  14.3%
    1       1024      2.599921            4      9757       3753          0       3753       3753    26604.0  26604     801850   15071    9758        0        1        1        0        0        0  14.6%
    1       4096      0.784568            4      2441       3111          1       3111       3109     7982.0   7982     205946    3772    2442        0        1        1        0        0        0  13.8%

    64      1        36.553975            4   9846154     269359         10     269369     269337   155663.8 155652   19704117  139230       1        0        1        1        0        0        0  28.2%
    64      8        36.509694            4   8888896     243467          8     243475     243449   155652.0 155652   19704117  139120       1        0        1        1        0        0        0  26.5%
    64      16       36.466282            4   8000000     219381          4     219385     219374   155652.0 155652   19704117  139232       1        0        1        1        0        0        0  24.8%
    64      32       36.395926            4   6666688     183171          6     183180     183165   155652.0 155652   19704117  139158       1        0        1        1        0        0        0  21.8%
    64      64       36.296856            4   5000000     137753          4     137757     137737   155652.0 155652   19704117  139105       1        0        1        1        0        0        0  17.7%
    64      256      20.590392            4   2000000      97133         18      97151      94996   135248.8 131395    7877402   98335   31282        0        1        1        0        0        0  15.7%
    64      1024      6.225773            4    588288      94492       1436      95434      88748    46066.5  41321    2324378   30360    9193        0        1        1        0        0        0  15.8%
    64      4096      1.856069            4    153856      82893         54      82948      82721    16115.0  16043     583674   11574    2675        0        1        1        0        0        0  16.3%

    After:

    read    skip      time (s)   iterations     frags     frag/s    mad f/s    max f/s    min f/s    avg aio    aio      (KiB) blocked dropped  idx hit idx miss  idx blk    c hit   c miss    c blk    cpu
    1       0        36.429240            4  10000000     274505         38     274515     274417   153887.8 153883   19696986  153849       0        0        0        0        0        0        0  22.4%
    1       1        36.933806            4   5000000     135377         15     135385     135354   155658.0 155658   19704085  139398       1        0        1        1        0        0        0  40.0%
    1       8        36.419187            4   1111112      30509          2      30510      30507   155658.0 155658   19704085  139233       1        0        1        1        0        0        0  22.0%
    1       16       36.353475            4    588236      16181          0      16182      16181   155658.0 155658   19704085  139183       1        0        1        1        0        0        0  19.2%
    1       32       36.251356            4    303031       8359          0       8359       8359   155658.0 155658   19704085  139120       1        0        1        1        0        0        0  14.8%
    1       64       36.203692            4    153847       4249          0       4250       4249   155658.0 155658   19704085  139071       1        0        1        1        0        0        0  13.0%
    1       256       9.965876            4     38911       3904          0       3906       3904   100875.2 100874    3178266   60108   38912        0        1        1        0        0        0  17.9%
    1       1024      2.637501            4      9757       3699          1       3700       3697    26610.0  26610     801818   15071    9758        0        1        1        0        0        0  19.5%
    1       4096      0.806745            4      2441       3026          1       3027       3024     7988.0   7988     205914    3773    2442        0        1        1        0        0        0  18.3%

    64      1        36.611243            4   9846154     268938          5     268942     268921   155669.8 155705   19704085  139330       2        0        1        1        0        0        0  29.9%
    64      8        36.559471            4   8888896     243135         11     243156     243124   155658.0 155658   19704085  139261       1        0        1        1        0        0        0  28.1%
    64      16       36.510319            4   8000000     219116         15     219126     219101   155658.0 155658   19704085  139173       1        0        1        1        0        0        0  26.3%
    64      32       36.439069            4   6666688     182954          9     182964     182943   155658.0 155658   19704085  139274       1        0        1        1        0        0        0  23.2%
    64      64       36.334808            4   5000000     137609         11     137612     137596   155658.0 155658   19704085  139258       2        0        1        1        0        0        0  19.1%
    64      256      20.624759            4   2000000      96971         88      97059      92717   138296.0 131401    7877370   98332   31282        0        1        1        0        0        0  17.2%
    64      1024      6.260598            4    588288      93967       1429      94905      88051    45939.5  41327    2324346   30361    9193        0        1        1        0        0        0  17.8%
    64      4096      1.881338            4    153856      81780        140      81920      81520    16109.8  16092     582714   11617    2678        0        1        1        0        0        0  18.2%

4) perf_fast_forward --run-tests=large-partition-slicing

    Caching enabled, each line shows the median run from many iterations

    TL;DR: We can observe reduction in IO which translates to reduction in execution time,
           especially for slicing in the middle of partition.

    perf_fast_forward --run-tests=large-partition-slicing --datasets=large-part-ds1 -c1 -m1G --keep-cache-across-test-cases

    Config: rows: 10000000, value size: 2000

    Before:

    offset  read      time (s)   iterations     frags     frag/s    mad f/s    max f/s    min f/s    avg aio    aio      (KiB) blocked dropped  idx hit idx miss  idx blk    c hit   c miss    c blk    allocs   tasks insns/f    cpu
    0       1         0.000491          127         1       2037         24       2109        127        4.0      4        128       2       2        0        1        1        0        0        0       157      80 3058208  15.0%
    0       32        0.000561         1740        32      56995        410      60031      47208        5.0      5        160       3       2        0        1        1        0        0        0       386     111  113353  17.5%
    0       256       0.002052          488       256     124736       7111     144762      89053       16.6     17        672      14       2        0        1        1        0        0        0      2113     446   52669  18.6%
    0       4096      0.016437           61      4096     249199        692     252389     244995       69.4     69       8640      57       5        0        1        1        0        0        0     26638    1717   23321  22.4%
    5000000 1         0.002171          221         1        461          2        466        221       25.0     25        268       3       3        0        1        1        0        0        0       638     376 14311524  10.2%
    5000000 32        0.002392          404        32      13376         48      13528      13015       27.0     27        332       5       3        0        1        1        0        0        0       931     432  489691  11.9%
    5000000 256       0.003659          279       256      69967        764      73130      52563       39.5     41        780      19       3        0        1        1        0        0        0      2689     825   93756  15.8%
    5000000 4096      0.018592           55      4096     220313        433     234214     218803       94.2     94       9484      62       9        0        1        1        0        0        0     27349    2213   26562  21.0%

    After:

    offset  read      time (s)   iterations     frags     frag/s    mad f/s    max f/s    min f/s    avg aio    aio      (KiB) blocked dropped  idx hit idx miss  idx blk    c hit   c miss    c blk    allocs   tasks insns/f    cpu
    0       1         0.000229          115         1       4371         85       4585        115        2.1      2         64       1       1        1        0        0        0        0        0        90      31 1314749  22.2%
    0       32        0.000277         2174        32     115674       1015     128109      14144        3.0      3         96       2       1        1        0        0        0        0        0       319      62   52508  26.1%
    0       256       0.001786          576       256     143298       5534     179142     113715       14.7     17        544      15       1        1        0        0        0        0        0      2110     453   45419  21.4%
    0       4096      0.015498           61      4096     264289       2006     268850     259342       67.4     67       8576      59       4        1        0        0        0        0        0     26657    1738   22897  23.7%
    5000000 1         0.000415          233         1       2411         15       2456        234        4.1      4        128       2       2        1        0        0        0        0        0       199      72 2644719  16.8%
    5000000 32        0.000635         1413        32      50398        349      51149      46439        6.0      6        192       4       2        1        0        0        0        0        0       458     128  125893  18.6%
    5000000 256       0.002028          486       256     126228       3024     146327      82559       17.8     18       1024      13       4        1        0        0        0        0        0      2123     385   51787  19.6%
    5000000 4096      0.016836           61      4096     243294        814     263434     241660       73.0     73       9344      62       8        1        0        0        0        0        0     26922    1920   24389  22.4%

Future work:

 - Check the impact on non-uniform workloads. Caching sstable indexes takes space away from the row cache
   which may reduce the hit ratio.

 - Reduce memory footprint of partition index cache. Currently, about 8x bloat over the on-disk size.

 - Disable cache population for "bypass cache" reads

 - Add a switch to disable sstable index caching, per-node, maybe per-table

 - Better sstable index format. Current format leads to inefficiency in caching since only some elements of the cached
   page can be hot. A B-tree index would be more efficient. Same applies to the partition index. Only some elements in
   the partition index page can be hot.

 - Add heuristic for reducing index file IO size when large partitions are anticipated. If we're bound by disk's
   bandwidth it's wasteful to read the front of promoted index using 32K IO, better use 4K which should cover the
   partition entry and then let binary search read the rest.

In V2:

 - Fixed perf_fast_forward regression in the number of IOs used to read partition index page
   The reader uses 32K reads, which were split by page cache into 4K reads
   Fix by propagating IO size hints to page cache and using single IO to populate it.
   New patch: "cached_file: Issue single I/O for the whole read range on miss"

 - Avoid large allocations to store partition index page entries (due to managed_vector storage).
   There is a unit test which detects this and fails.
   Fixed by implementing chunked_managed_vector, based on chunked_vector.

 - fixed bug in cached_file::evict_gently() where the wrong allocation strategy was used to free btree chunks

 - Simplify region_impl::free_buf() according to Avi's suggestions

 - Fit segment_kind in segment_descriptor::_free_space and lift requirement that _buf_pointers emptiness determines the kind

 - Workaround sigsegv which was most likely due to coroutine miscompilation. Worked around by manipulating local object scope.

 - Wire up system/drop_sstable_caches RESTful API

 - Fix use-after-move on permit for the old scanning ka/la index reader

 - Fixed more cases of double open_data() in tests leading to assert failure

 - Adjusted cached_file class doc to account for changes in behavior.

 - Rebased

Fixes #7079.
Refs #363.
"

* tag 'sstable-index-caching-v2' of github.com:tgrabiec/scylla: (39 commits)
  api: Drop sstable index caches on system/drop_sstable_caches
  cached_file: Issue single I/O for the whole read range on miss
  row_cache: cache_tracker: Do not register metrics when constructed for tests
  sstables, cached_file: Evict cache gently when sstable is destroyed
  sstables: Hide partition_index_cache implementation away from sstables.hh
  sstables: Drop shared_index_lists alias
  sstables: Destroy partition index cache gently
  sstables: Cache partition index pages in LSA and link to LRU
  utils: Introduce lsa::weak_ptr<>
  sstables: Rename index_list to partition_index_page and shared_index_lists to partition_index_cache
  sstables, cached_file: Avoid copying buffers from cache when parsing promoted index
  cached_file: Introduce get_page_units()
  sstables: read: Document that primitive_consumer::read_32() is alloc-free
  sstables: read: Count partition index page evictions
  sstables: Drop the _use_binary_search flag from index entries
  sstables: index_reader: Keep index objects under LSA
  lsa: chunked_managed_vector: Adapt more to managed_vector
  utils: lsa: chunked_managed_vector: Make LSA-aware
  test: chunked_managed_vector_test: Make exception_safe_class standard layout
  lsa: Copy chunked_vector to chunked_managed_vector
  ...
2021-07-07 18:17:10 +03:00

2629 lines
91 KiB
C++

/*
* Copyright (C) 2015-present ScyllaDB
*/
/*
* This file is part of Scylla.
*
* Scylla is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Scylla is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Scylla. If not, see <http://www.gnu.org/licenses/>.
*/
#include <boost/range/algorithm/heap_algorithm.hpp>
#include <boost/range/algorithm/remove.hpp>
#include <boost/range/algorithm.hpp>
#include <boost/heap/binomial_heap.hpp>
#include <boost/intrusive/list.hpp>
#include <boost/intrusive/set.hpp>
#include <boost/intrusive/slist.hpp>
#include <boost/range/adaptors.hpp>
#include <stack>
#include <seastar/core/memory.hh>
#include <seastar/core/align.hh>
#include <seastar/core/print.hh>
#include <seastar/core/metrics.hh>
#include <seastar/core/reactor.hh>
#include <seastar/core/coroutine.hh>
#include <seastar/core/with_scheduling_group.hh>
#include <seastar/util/alloc_failure_injector.hh>
#include <seastar/util/backtrace.hh>
#include <seastar/util/later.hh>
#include "utils/logalloc.hh"
#include "log.hh"
#include "utils/dynamic_bitset.hh"
#include "utils/log_heap.hh"
#include "utils/preempt.hh"
#include "utils/vle.hh"
#include <random>
#include <chrono>
using namespace std::chrono_literals;
#ifdef SEASTAR_ASAN_ENABLED
#include "sanitizer/asan_interface.h"
// For each aligned 8 byte segment, the algorithm used by address
// sanitizer can represent any addressable prefix followd by a
// poisoned suffix. The details are at:
// https://github.com/google/sanitizers/wiki/AddressSanitizerAlgorithm
// For us this means that:
// * The descriptor must be 8 byte aligned. If it was not, making the
// descriptor addressable would also make the end of the previous
// value addressable.
// * Each value must be at least 8 byte aligned. If it was not, making
// the value addressable would also make the end of the descriptor
// addressable.
namespace debug {
constexpr size_t logalloc_alignment = 8;
}
template<typename T>
[[nodiscard]] static T align_up_for_asan(T val) {
return align_up(val, size_t(8));
}
template<typename T>
void poison(const T* addr, size_t size) {
// Both values and descriptors must be aligned.
assert(uintptr_t(addr) % 8 == 0);
// This can be followed by
// * 8 byte aligned descriptor (this is a value)
// * 8 byte aligned value
// * dead value
// * end of segment
// In all cases, we can align up the size to guarantee that asan
// is able to poison this.
ASAN_POISON_MEMORY_REGION(addr, align_up_for_asan(size));
}
void unpoison(const char *addr, size_t size) {
ASAN_UNPOISON_MEMORY_REGION(addr, size);
}
#else
namespace debug {
constexpr size_t logalloc_alignment = 1;
}
template<typename T>
[[nodiscard]] static T align_up_for_asan(T val) { return val; }
template<typename T>
void poison(const T* addr, size_t size) { }
void unpoison(const char *addr, size_t size) { }
#endif
namespace bi = boost::intrusive;
standard_allocation_strategy standard_allocation_strategy_instance;
namespace {
class migrators_base {
protected:
std::vector<const migrate_fn_type*> _migrators;
};
#ifdef DEBUG_LSA_SANITIZER
class migrators : public migrators_base, public enable_lw_shared_from_this<migrators> {
private:
struct backtrace_entry {
saved_backtrace _registration;
saved_backtrace _deregistration;
};
std::vector<std::unique_ptr<backtrace_entry>> _backtraces;
static logging::logger _logger;
private:
void on_error() { abort(); }
public:
uint32_t add(const migrate_fn_type* m) {
_migrators.push_back(m);
_backtraces.push_back(std::make_unique<backtrace_entry>(backtrace_entry{current_backtrace(), {}}));
return _migrators.size() - 1;
}
void remove(uint32_t idx) {
if (idx >= _migrators.size()) {
_logger.error("Attempting to deregister migrator id {} which was never registered:\n{}",
idx, current_backtrace());
on_error();
}
if (!_migrators[idx]) {
_logger.error("Attempting to double deregister migrator id {}:\n{}\n"
"Previously deregistered at:\n{}\nRegistered at:\n{}",
idx, current_backtrace(), _backtraces[idx]->_deregistration,
_backtraces[idx]->_registration);
on_error();
}
_migrators[idx] = nullptr;
_backtraces[idx]->_deregistration = current_backtrace();
}
const migrate_fn_type*& operator[](uint32_t idx) {
if (idx >= _migrators.size()) {
_logger.error("Attempting to use migrator id {} that was never registered:\n{}",
idx, current_backtrace());
on_error();
}
if (!_migrators[idx]) {
_logger.error("Attempting to use deregistered migrator id {}:\n{}\n"
"Deregistered at:\n{}\nRegistered at:\n{}",
idx, current_backtrace(), _backtraces[idx]->_deregistration,
_backtraces[idx]->_registration);
on_error();
}
return _migrators[idx];
}
};
logging::logger migrators::_logger("lsa-migrator-sanitizer");
#else
class migrators : public migrators_base, public enable_lw_shared_from_this<migrators> {
std::vector<uint32_t> _unused_ids;
public:
uint32_t add(const migrate_fn_type* m) {
if (!_unused_ids.empty()) {
uint32_t idx = _unused_ids.back();
_unused_ids.pop_back();
_migrators[idx] = m;
return idx;
}
_migrators.push_back(m);
return _migrators.size() - 1;
}
void remove(uint32_t idx) {
_unused_ids.push_back(idx);
}
const migrate_fn_type*& operator[](uint32_t idx) {
return _migrators[idx];
}
};
#endif
static
migrators&
static_migrators() noexcept {
memory::scoped_critical_alloc_section dfg;
static thread_local lw_shared_ptr<migrators> obj = make_lw_shared<migrators>();
return *obj;
}
}
namespace debug {
thread_local migrators* static_migrators = &::static_migrators();
}
uint32_t
migrate_fn_type::register_migrator(migrate_fn_type* m) {
auto& migrators = *debug::static_migrators;
auto idx = migrators.add(m);
// object_descriptor encodes 2 * index() + 1
assert(idx * 2 + 1 < utils::uleb64_express_supreme);
m->_migrators = migrators.shared_from_this();
return idx;
}
void
migrate_fn_type::unregister_migrator(uint32_t index) {
static_migrators().remove(index);
}
namespace logalloc {
static thread_local bool s_sanitizer_report_backtrace = false;
#ifdef DEBUG_LSA_SANITIZER
class region_sanitizer {
struct allocation {
size_t size;
saved_backtrace backtrace;
};
private:
static logging::logger logger;
bool _broken = false;
std::unordered_map<const void*, allocation> _allocations;
private:
template<typename Function>
void run_and_handle_errors(Function&& fn) noexcept {
memory::scoped_critical_alloc_section dfg;
if (_broken) {
return;
}
try {
fn();
} catch (...) {
logger.error("Internal error, disabling the sanitizer: {}", std::current_exception());
_broken = true;
_allocations.clear();
}
}
private:
void on_error() { abort(); }
public:
void on_region_destruction() noexcept {
run_and_handle_errors([&] {
if (_allocations.empty()) {
return;
}
for (auto [ptr, alloc] : _allocations) {
logger.error("Leaked {} byte object at {} allocated from:\n{}",
alloc.size, ptr, alloc.backtrace);
}
on_error();
});
}
void on_allocation(const void* ptr, size_t size) noexcept {
run_and_handle_errors([&] {
auto backtrace = s_sanitizer_report_backtrace ? current_backtrace() : saved_backtrace();
auto [ it, success ] = _allocations.emplace(ptr, allocation { size, std::move(backtrace) });
if (!success) {
logger.error("Attempting to allocate an {} byte object at an already occupied address {}:\n{}\n"
"Previous allocation of {} bytes:\n{}",
ptr, size, current_backtrace(), it->second.size, it->second.backtrace);
on_error();
}
});
}
void on_free(const void* ptr, size_t size) noexcept {
run_and_handle_errors([&] {
auto it = _allocations.find(ptr);
if (it == _allocations.end()) {
logger.error("Attempting to free an object at {} (size: {}) that does not exist\n{}",
ptr, size, current_backtrace());
on_error();
}
if (it->second.size != size) {
logger.error("Mismatch between allocation and deallocation size of object at {}: {} vs. {}:\n{}\n"
"Allocated at:\n{}",
ptr, it->second.size, size, current_backtrace(), it->second.backtrace);
on_error();
}
_allocations.erase(it);
});
}
void on_migrate(const void* src, size_t size, const void* dst) noexcept {
run_and_handle_errors([&] {
auto it_src = _allocations.find(src);
if (it_src == _allocations.end()) {
logger.error("Attempting to migrate an object at {} (size: {}) that does not exist",
src, size);
on_error();
}
if (it_src->second.size != size) {
logger.error("Mismatch between allocation and migration size of object at {}: {} vs. {}\n"
"Allocated at:\n{}",
src, it_src->second.size, size, it_src->second.backtrace);
on_error();
}
auto [ it_dst, success ] = _allocations.emplace(dst, std::move(it_src->second));
if (!success) {
logger.error("Attempting to migrate an {} byte object to an already occupied address {}:\n"
"Migrated object allocated from:\n{}\n"
"Previous allocation of {} bytes at the destination:\n{}",
size, dst, it_src->second.backtrace, it_dst->second.size, it_dst->second.backtrace);
on_error();
}
_allocations.erase(it_src);
});
}
void merge(region_sanitizer& other) noexcept {
run_and_handle_errors([&] {
_broken = other._broken;
if (_broken) {
_allocations.clear();
} else {
_allocations.merge(other._allocations);
if (!other._allocations.empty()) {
for (auto [ptr, o_alloc] : other._allocations) {
auto& alloc = _allocations.at(ptr);
logger.error("Conflicting allocations at address {} in merged regions\n"
"{} bytes allocated from:\n{}\n"
"{} bytes allocated from:\n{}",
ptr, alloc.size, alloc.backtrace, o_alloc.size, o_alloc.backtrace);
}
on_error();
}
}
});
}
};
logging::logger region_sanitizer::logger("lsa-sanitizer");
#else
struct region_sanitizer {
void on_region_destruction() noexcept { }
void on_allocation(const void*, size_t) noexcept { }
void on_free(const void* ptr, size_t size) noexcept { }
void on_migrate(const void*, size_t, const void*) noexcept { }
void merge(region_sanitizer&) noexcept { }
};
#endif
struct segment;
static logging::logger llogger("lsa");
static logging::logger timing_logger("lsa-timing");
static tracker& get_tracker_instance() noexcept {
memory::scoped_critical_alloc_section dfg;
static thread_local tracker obj;
return obj;
}
static thread_local tracker& tracker_instance = get_tracker_instance();
using clock = std::chrono::steady_clock;
class background_reclaimer {
scheduling_group _sg;
noncopyable_function<void (size_t target)> _reclaim;
timer<lowres_clock> _adjust_shares_timer;
// If engaged, main loop is not running, set_value() to wake it.
promise<>* _main_loop_wait = nullptr;
future<> _done;
bool _stopping = false;
static constexpr size_t free_memory_threshold = 60'000'000;
private:
bool have_work() const {
#ifndef SEASTAR_DEFAULT_ALLOCATOR
return memory::stats().free_memory() < free_memory_threshold;
#else
return false;
#endif
}
void main_loop_wake() {
llogger.debug("background_reclaimer::main_loop_wake: waking {}", bool(_main_loop_wait));
if (_main_loop_wait) {
_main_loop_wait->set_value();
_main_loop_wait = nullptr;
}
}
future<> main_loop() {
llogger.debug("background_reclaimer::main_loop: entry");
while (true) {
while (!_stopping && !have_work()) {
promise<> wait;
_main_loop_wait = &wait;
llogger.trace("background_reclaimer::main_loop: sleep");
co_await wait.get_future();
llogger.trace("background_reclaimer::main_loop: awakened");
_main_loop_wait = nullptr;
}
if (_stopping) {
break;
}
_reclaim(free_memory_threshold - memory::stats().free_memory());
co_await make_ready_future<>();
}
llogger.debug("background_reclaimer::main_loop: exit");
}
void adjust_shares() {
if (have_work()) {
auto shares = 1 + (1000 * (free_memory_threshold - memory::stats().free_memory())) / free_memory_threshold;
_sg.set_shares(shares);
llogger.trace("background_reclaimer::adjust_shares: {}", shares);
if (_main_loop_wait) {
main_loop_wake();
}
}
}
public:
explicit background_reclaimer(scheduling_group sg, noncopyable_function<void (size_t target)> reclaim)
: _sg(sg)
, _reclaim(std::move(reclaim))
, _adjust_shares_timer(default_scheduling_group(), [this] { adjust_shares(); })
, _done(with_scheduling_group(_sg, [this] { return main_loop(); })) {
if (sg != default_scheduling_group()) {
_adjust_shares_timer.arm_periodic(50ms);
}
}
future<> stop() {
_stopping = true;
main_loop_wake();
return std::move(_done);
}
};
class tracker::impl {
std::optional<background_reclaimer> _background_reclaimer;
std::vector<region::impl*> _regions;
seastar::metrics::metric_groups _metrics;
bool _reclaiming_enabled = true;
size_t _reclamation_step = 1;
bool _abort_on_bad_alloc = false;
private:
// Prevents tracker's reclaimer from running while live. Reclaimer may be
// invoked synchronously with allocator. This guard ensures that this
// object is not re-entered while inside one of the tracker's methods.
struct reclaiming_lock {
impl& _ref;
bool _prev;
reclaiming_lock(impl& ref)
: _ref(ref)
, _prev(ref._reclaiming_enabled)
{
_ref._reclaiming_enabled = false;
}
~reclaiming_lock() {
_ref._reclaiming_enabled = _prev;
}
};
friend class tracker_reclaimer_lock;
public:
impl();
~impl();
future<> stop() {
if (_background_reclaimer) {
return _background_reclaimer->stop();
} else {
return make_ready_future<>();
}
}
void register_region(region::impl*);
void unregister_region(region::impl*) noexcept;
size_t reclaim(size_t bytes, is_preemptible p);
// Compacts one segment at a time from sparsest segment to least sparse until work_waiting_on_reactor returns true
// or there are no more segments to compact.
idle_cpu_handler_result compact_on_idle(work_waiting_on_reactor check_for_work);
// Releases whole segments back to the segment pool.
// After the call, if there is enough evictable memory, the amount of free segments in the pool
// will be at least reserve_segments + div_ceil(bytes, segment::size).
// Returns the amount by which segment_pool.total_memory_in_use() has decreased.
size_t compact_and_evict(size_t reserve_segments, size_t bytes, is_preemptible p);
void full_compaction();
void reclaim_all_free_segments();
occupancy_stats region_occupancy();
occupancy_stats occupancy();
size_t non_lsa_used_space();
// Set the minimum number of segments reclaimed during single reclamation cycle.
void set_reclamation_step(size_t step_in_segments) { _reclamation_step = step_in_segments; }
size_t reclamation_step() const { return _reclamation_step; }
// Abort on allocation failure from LSA
void enable_abort_on_bad_alloc() { _abort_on_bad_alloc = true; }
bool should_abort_on_bad_alloc() const { return _abort_on_bad_alloc; }
void setup_background_reclaim(scheduling_group sg) {
assert(!_background_reclaimer);
_background_reclaimer.emplace(sg, [this] (size_t target) {
reclaim(target, is_preemptible::yes);
});
}
private:
// Like compact_and_evict() but assumes that reclaim_lock is held around the operation.
size_t compact_and_evict_locked(size_t reserve_segments, size_t bytes, is_preemptible preempt);
};
class tracker_reclaimer_lock {
tracker::impl::reclaiming_lock _lock;
public:
tracker_reclaimer_lock() : _lock(shard_tracker().get_impl()) { }
};
tracker::tracker()
: _impl(std::make_unique<impl>())
, _reclaimer([this] (seastar::memory::reclaimer::request r) { return reclaim(r); }, memory::reclaimer_scope::sync)
{ }
tracker::~tracker() {
}
future<>
tracker::stop() {
return _impl->stop();
}
size_t tracker::reclaim(size_t bytes) {
return _impl->reclaim(bytes, is_preemptible::no);
}
occupancy_stats tracker::region_occupancy() {
return _impl->region_occupancy();
}
occupancy_stats tracker::occupancy() {
return _impl->occupancy();
}
size_t tracker::non_lsa_used_space() const {
return _impl->non_lsa_used_space();
}
void tracker::full_compaction() {
return _impl->full_compaction();
}
void tracker::reclaim_all_free_segments() {
return _impl->reclaim_all_free_segments();
}
tracker& shard_tracker() {
return tracker_instance;
}
struct alignas(segment_size) segment {
static constexpr int size_shift = segment_size_shift;
static constexpr int size_mask = segment_size | (segment_size - 1);
using size_type = std::conditional_t<(size_shift < 16), uint16_t, uint32_t>;
static constexpr size_t size = segment_size;
uint8_t data[size];
segment() noexcept { }
template<typename T = void>
const T* at(size_t offset) const {
return reinterpret_cast<const T*>(data + offset);
}
template<typename T = void>
T* at(size_t offset) {
return reinterpret_cast<T*>(data + offset);
}
bool is_empty();
void record_alloc(size_type size);
void record_free(size_type size);
occupancy_stats occupancy();
static void* operator new(size_t size) = delete;
static void* operator new(size_t, void* ptr) noexcept { return ptr; }
static void operator delete(void* ptr) = delete;
};
static constexpr size_t max_managed_object_size = segment_size * 0.1;
static constexpr auto max_used_space_ratio_for_compaction = 0.85;
static constexpr size_t max_used_space_for_compaction = segment_size * max_used_space_ratio_for_compaction;
static constexpr size_t min_free_space_for_compaction = segment_size - max_used_space_for_compaction;
static_assert(min_free_space_for_compaction >= max_managed_object_size,
"Segments which cannot fit max_managed_object_size must not be considered compactible for the sake of forward progress of compaction");
// Since we only compact if there's >= min_free_space_for_compaction of free space,
// we use min_free_space_for_compaction as the histogram's minimum size and put
// everything below that value in the same bucket.
extern constexpr log_heap_options segment_descriptor_hist_options(min_free_space_for_compaction, 3, segment_size);
enum segment_kind : int {
regular = 0, // Holds objects allocated with region_impl::alloc_small()
bufs = 1 // Holds objects allocated with region_impl::alloc_buf()
};
struct segment_descriptor : public log_heap_hook<segment_descriptor_hist_options> {
static constexpr segment::size_type free_space_mask = segment::size_mask;
static constexpr unsigned bits_for_free_space = segment::size_shift + 1;
static constexpr segment::size_type segment_kind_mask = 1 << bits_for_free_space;
static constexpr unsigned bits_for_segment_kind = 1;
static constexpr unsigned shift_for_segment_kind = bits_for_free_space;
static_assert(sizeof(segment::size_type) * 8 >= bits_for_free_space + bits_for_segment_kind);
segment::size_type _free_space;
region::impl* _region;
segment::size_type free_space() const {
return _free_space & free_space_mask;
}
void set_free_space(segment::size_type free_space) {
_free_space = (_free_space & ~free_space_mask) | free_space;
}
segment_kind kind() const {
return static_cast<segment_kind>(_free_space >> shift_for_segment_kind);
}
void set_kind(segment_kind kind) {
_free_space = (_free_space & ~segment_kind_mask)
| static_cast<segment::size_type>(kind) << shift_for_segment_kind;
}
// Valid if kind() == segment_kind::bufs.
//
// _buf_pointers holds links to lsa_buffer objects (paired with lsa_buffer::_link)
// of live objects in the segment. The purpose of this is so that segment compaction
// can update the pointers when it moves the objects.
// The order of entangled objects in the vector is irrelevant.
// Also, not all entangled objects may be engaged.
std::vector<entangled> _buf_pointers;
segment_descriptor()
: _region(nullptr)
{ }
bool is_empty() const {
return free_space() == segment::size;
}
occupancy_stats occupancy() const {
return { free_space(), segment::size };
}
void record_alloc(segment::size_type size) {
_free_space -= size;
}
void record_free(segment::size_type size) {
_free_space += size;
}
};
using segment_descriptor_hist = log_heap<segment_descriptor, segment_descriptor_hist_options>;
#ifndef SEASTAR_DEFAULT_ALLOCATOR
class segment_store {
memory::memory_layout _layout;
uintptr_t _segments_base; // The address of the first segment
public:
size_t non_lsa_reserve = 0;
segment_store()
: _layout(memory::get_memory_layout())
, _segments_base(align_down(_layout.start, (uintptr_t)segment::size)) {
}
segment* segment_from_idx(size_t idx) const {
return reinterpret_cast<segment*>(_segments_base) + idx;
}
size_t idx_from_segment(segment* seg) const {
return seg - reinterpret_cast<segment*>(_segments_base);
}
size_t new_idx_for_segment(segment* seg) {
return idx_from_segment(seg);
}
void free_segment(segment *seg) { }
size_t max_segments() const {
return (_layout.end - _segments_base) / segment::size;
}
bool can_allocate_more_segments() {
return memory::stats().free_memory() >= non_lsa_reserve + segment::size;
}
};
#else
class segment_store {
std::vector<segment*> _segments;
std::unordered_map<segment*, size_t> _segment_indexes;
static constexpr size_t _std_memory_available = size_t(1) << 30; // emulate 1GB per shard
std::vector<segment*>::iterator find_empty() {
// segment 0 is a marker for no segment
return std::find(_segments.begin() + 1, _segments.end(), nullptr);
}
public:
size_t non_lsa_reserve = 0;
segment_store() : _segments(max_segments()) {
_segment_indexes.reserve(max_segments());
}
segment* segment_from_idx(size_t idx) const {
assert(idx < _segments.size());
return _segments[idx];
}
size_t idx_from_segment(segment* seg) {
// segment 0 is a marker for no segment
auto i = _segment_indexes.find(seg);
if (i == _segment_indexes.end()) {
return 0;
}
return i->second;
}
size_t new_idx_for_segment(segment* seg) {
auto i = find_empty();
assert(i != _segments.end());
*i = seg;
size_t ret = i - _segments.begin();
_segment_indexes[seg] = ret;
return ret;
}
void free_segment(segment *seg) {
size_t i = idx_from_segment(seg);
assert(i != 0);
_segment_indexes.erase(seg);
_segments[i] = nullptr;
}
~segment_store() {
for (segment *seg : _segments) {
if (seg) {
seg->~segment();
free(seg);
}
}
}
size_t max_segments() const {
return _std_memory_available / segment::size;
}
bool can_allocate_more_segments() {
auto i = find_empty();
return i != _segments.end();
}
};
#endif
// Segment pool implementation for the seastar allocator.
// Stores segment descriptors in a vector which is indexed using most significant
// bits of segment address.
//
// We prefer using high-address segments, and returning low-address segments to the seastar
// allocator in order to segregate lsa and non-lsa memory, to reduce fragmentation.
class segment_pool {
segment_store _store;
std::vector<segment_descriptor> _segments;
size_t _segments_in_use{};
utils::dynamic_bitset _lsa_owned_segments_bitmap; // owned by this
utils::dynamic_bitset _lsa_free_segments_bitmap; // owned by this, but not in use
size_t _free_segments = 0;
size_t _current_emergency_reserve_goal = 1;
size_t _emergency_reserve_max = 30;
bool _allocation_failure_flag = false;
bool _allocation_enabled = true;
struct allocation_lock {
segment_pool& _pool;
bool _prev;
allocation_lock(segment_pool& p)
: _pool(p)
, _prev(p._allocation_enabled)
{
_pool._allocation_enabled = false;
}
~allocation_lock() {
_pool._allocation_enabled = _prev;
}
};
size_t _non_lsa_memory_in_use = 0;
// Invariants - a segment is in one of the following states:
// In use by some region
// - set in _lsa_owned_segments_bitmap
// - clear in _lsa_free_segments_bitmap
// - counted in _segments_in_use
// Free:
// - set in _lsa_owned_segments_bitmap
// - set in _lsa_free_segments_bitmap
// - counted in _unreserved_free_segments
// Non-lsa:
// - clear everywhere
private:
segment* allocate_segment(size_t reserve);
void deallocate_segment(segment* seg);
friend void* segment::operator new(size_t);
friend void segment::operator delete(void*);
segment* allocate_or_fallback_to_reserve();
void free_or_restore_to_reserve(segment* seg) noexcept;
segment* segment_from_idx(size_t idx) const {
return _store.segment_from_idx(idx);
}
size_t idx_from_segment(segment* seg) {
return _store.idx_from_segment(seg);
}
size_t max_segments() const {
return _store.max_segments();
}
bool can_allocate_more_segments() {
return _allocation_enabled && _store.can_allocate_more_segments();
}
bool compact_segment(segment* seg);
public:
segment_pool();
void prime(size_t available_memory, size_t min_free_memory);
segment* new_segment(region::impl* r);
segment_descriptor& descriptor(segment*);
// Returns segment containing given object or nullptr.
segment* containing_segment(const void* obj);
segment* segment_from(const segment_descriptor& desc);
void free_segment(segment*) noexcept;
void free_segment(segment*, segment_descriptor&) noexcept;
size_t segments_in_use() const;
size_t current_emergency_reserve_goal() const { return _current_emergency_reserve_goal; }
void set_emergency_reserve_max(size_t new_size) { _emergency_reserve_max = new_size; }
size_t emergency_reserve_max() { return _emergency_reserve_max; }
void set_current_emergency_reserve_goal(size_t goal) { _current_emergency_reserve_goal = goal; }
void clear_allocation_failure_flag() { _allocation_failure_flag = false; }
bool allocation_failure_flag() { return _allocation_failure_flag; }
void refill_emergency_reserve();
void update_non_lsa_memory_in_use(ssize_t n) {
_non_lsa_memory_in_use += n;
}
size_t non_lsa_memory_in_use() const {
return _non_lsa_memory_in_use;
}
size_t total_memory_in_use() const {
return _non_lsa_memory_in_use + _segments_in_use * segment::size;
}
size_t total_free_memory() const {
return _free_segments * segment::size;
}
struct reservation_goal;
void set_region(segment* seg, region::impl* r) {
set_region(descriptor(seg), r);
}
void set_region(segment_descriptor& desc, region::impl* r) {
desc._region = r;
}
size_t reclaim_segments(size_t target, is_preemptible preempt);
void reclaim_all_free_segments() {
reclaim_segments(std::numeric_limits<size_t>::max(), is_preemptible::no);
}
struct stats {
size_t segments_compacted;
size_t lsa_buffer_segments;
uint64_t memory_allocated;
uint64_t memory_compacted;
};
private:
stats _stats{};
public:
const stats& statistics() const { return _stats; }
void on_segment_compaction(size_t used_size);
void on_memory_allocation(size_t size);
size_t unreserved_free_segments() const { return _free_segments - std::min(_free_segments, _emergency_reserve_max); }
size_t free_segments() const { return _free_segments; }
};
size_t segment_pool::reclaim_segments(size_t target, is_preemptible preempt) {
// Reclaimer tries to release segments occupying lower parts of the address
// space.
llogger.debug("Trying to reclaim {} segments", target);
// Reclamation. Migrate segments to higher addresses and shrink segment pool.
size_t reclaimed_segments = 0;
// We may fail to reclaim because a region has reclaim disabled (usually because
// it is in an allocating_section. Failed reclaims can cause high CPU usage
// if all of the lower addresses happen to be in a reclaim-disabled region (this
// is somewhat mitigated by the fact that checking for reclaim disabled is very
// cheap), but worse, failing a segment reclaim can lead to reclaimed memory
// being fragmented. This results in the original allocation continuing to fail.
//
// To combat that, we limit the number of failed reclaims. If we reach the limit,
// we fail the reclaim. The surrounding allocating_section will release the
// reclaim_lock, and increase reserves, which will result in reclaim being
// retried with all regions being reclaimable, and succeed in allocating
// contiguous memory.
size_t failed_reclaims_allowance = 10;
for (size_t src_idx = _lsa_owned_segments_bitmap.find_first_set();
reclaimed_segments != target && src_idx != utils::dynamic_bitset::npos
&& _free_segments > _current_emergency_reserve_goal;
src_idx = _lsa_owned_segments_bitmap.find_next_set(src_idx)) {
auto src = segment_from_idx(src_idx);
if (!_lsa_free_segments_bitmap.test(src_idx)) {
if (!compact_segment(src)) {
if (--failed_reclaims_allowance == 0) {
break;
}
continue;
}
}
_lsa_free_segments_bitmap.clear(src_idx);
_lsa_owned_segments_bitmap.clear(src_idx);
_store.free_segment(src);
src->~segment();
::free(src);
++reclaimed_segments;
--_free_segments;
if (preempt && need_preempt()) {
break;
}
}
llogger.debug("Reclaimed {} segments (requested {})", reclaimed_segments, target);
return reclaimed_segments;
}
segment* segment_pool::allocate_segment(size_t reserve)
{
//
// When allocating a segment we want to avoid:
// - LSA and general-purpose allocator shouldn't constantly fight each
// other for every last bit of memory
//
// allocate_segment() always works with LSA reclaimer disabled.
// 1. Firstly, the algorithm tries to allocate an lsa-owned but free segment
// 2. If no free segmented is available, a new segment is allocated from the
// system allocator. However, if the free memory is below set threshold
// this step is skipped.
// 3. Finally, the algorithm ties to compact and evict data stored in LSA
// memory in order to reclaim enough segments.
//
do {
tracker_reclaimer_lock rl;
if (_free_segments > reserve) {
auto free_idx = _lsa_free_segments_bitmap.find_last_set();
_lsa_free_segments_bitmap.clear(free_idx);
auto seg = segment_from_idx(free_idx);
--_free_segments;
return seg;
}
if (can_allocate_more_segments()) {
memory::disable_abort_on_alloc_failure_temporarily dfg;
auto p = aligned_alloc(segment::size, segment::size);
if (!p) {
continue;
}
auto seg = new (p) segment;
poison(seg, sizeof(segment));
auto idx = _store.new_idx_for_segment(seg);
_lsa_owned_segments_bitmap.set(idx);
return seg;
}
} while (shard_tracker().get_impl().compact_and_evict(reserve, shard_tracker().reclamation_step() * segment::size, is_preemptible::no));
return nullptr;
}
void segment_pool::deallocate_segment(segment* seg)
{
assert(_lsa_owned_segments_bitmap.test(idx_from_segment(seg)));
_lsa_free_segments_bitmap.set(idx_from_segment(seg));
_free_segments++;
}
void segment_pool::refill_emergency_reserve() {
while (_free_segments < _emergency_reserve_max) {
auto seg = allocate_segment(_emergency_reserve_max);
if (!seg) {
throw std::bad_alloc();
}
++_segments_in_use;
free_segment(seg);
}
}
segment_descriptor&
segment_pool::descriptor(segment* seg) {
uintptr_t index = idx_from_segment(seg);
return _segments[index];
}
segment*
segment_pool::containing_segment(const void* obj) {
auto addr = reinterpret_cast<uintptr_t>(obj);
auto offset = addr & (segment::size - 1);
auto seg = reinterpret_cast<segment*>(addr - offset);
auto index = idx_from_segment(seg);
auto& desc = _segments[index];
if (desc._region) {
return seg;
} else {
return nullptr;
}
}
segment*
segment_pool::segment_from(const segment_descriptor& desc) {
assert(desc._region);
auto index = &desc - &_segments[0];
return segment_from_idx(index);
}
segment*
segment_pool::allocate_or_fallback_to_reserve() {
auto seg = allocate_segment(_current_emergency_reserve_goal);
if (!seg) {
_allocation_failure_flag = true;
throw std::bad_alloc();
}
return seg;
}
segment*
segment_pool::new_segment(region::impl* r) {
auto seg = allocate_or_fallback_to_reserve();
++_segments_in_use;
segment_descriptor& desc = descriptor(seg);
desc.set_free_space(segment::size);
desc.set_kind(segment_kind::regular);
desc._region = r;
return seg;
}
void segment_pool::free_segment(segment* seg) noexcept {
free_segment(seg, descriptor(seg));
}
void segment_pool::free_segment(segment* seg, segment_descriptor& desc) noexcept {
llogger.trace("Releasing segment {}", fmt::ptr(seg));
desc._region = nullptr;
deallocate_segment(seg);
--_segments_in_use;
}
segment_pool::segment_pool()
: _segments(max_segments())
, _lsa_owned_segments_bitmap(max_segments())
, _lsa_free_segments_bitmap(max_segments())
{
}
void segment_pool::prime(size_t available_memory, size_t min_free_memory) {
auto old_emergency_reserve = std::exchange(_emergency_reserve_max, std::numeric_limits<size_t>::max());
try {
// Allocate all of memory so that we occupy the top part. Afterwards, we'll start
// freeing from the bottom.
_store.non_lsa_reserve = 0;
refill_emergency_reserve();
} catch (std::bad_alloc&) {
_emergency_reserve_max = old_emergency_reserve;
}
// We want to leave more free memory than just min_free_memory() in order to reduce
// the frequency of expensive segment-migrating reclaim() called by the seastar allocator.
size_t min_gap = 1 * 1024 * 1024;
size_t max_gap = 32 * 1024 * 1024;
size_t gap = std::min(max_gap, std::max(available_memory / 16, min_gap));
_store.non_lsa_reserve = min_free_memory + gap;
// Since the reclaimer is not yet in place, free some low memory for general use
reclaim_segments(_store.non_lsa_reserve / segment::size, is_preemptible::no);
}
void segment_pool::on_segment_compaction(size_t used_size) {
_stats.segments_compacted++;
_stats.memory_compacted += used_size;
}
void segment_pool::on_memory_allocation(size_t size) {
_stats.memory_allocated += size;
}
// RAII wrapper to maintain segment_pool::current_emergency_reserve_goal()
class segment_pool::reservation_goal {
segment_pool& _sp;
size_t _old_goal;
public:
reservation_goal(segment_pool& sp, size_t goal)
: _sp(sp), _old_goal(_sp.current_emergency_reserve_goal()) {
_sp.set_current_emergency_reserve_goal(goal);
}
~reservation_goal() {
_sp.set_current_emergency_reserve_goal(_old_goal);
}
};
size_t segment_pool::segments_in_use() const {
return _segments_in_use;
}
static segment_pool& get_shard_segment_pool() noexcept {
memory::scoped_critical_alloc_section dfg;
static thread_local segment_pool obj;
return obj;
}
static thread_local segment_pool& shard_segment_pool = get_shard_segment_pool();
void segment::record_alloc(segment::size_type size) {
shard_segment_pool.descriptor(this).record_alloc(size);
}
void segment::record_free(segment::size_type size) {
shard_segment_pool.descriptor(this).record_free(size);
}
bool segment::is_empty() {
return shard_segment_pool.descriptor(this).is_empty();
}
occupancy_stats
segment::occupancy() {
return { shard_segment_pool.descriptor(this).free_space(), segment::size };
}
//
// For interface documentation see logalloc::region and allocation_strategy.
//
// Allocation dynamics.
//
// Objects are allocated inside fixed-size segments. Objects don't cross
// segment boundary. Active allocations are served from a single segment using
// bump-the-pointer method. That segment is called the active segment. When
// active segment fills up, it is closed. Closed segments are kept in a heap
// which orders them by occupancy. As objects are freed, the segment become
// sparser and are eventually released. Objects which are too large are
// allocated using standard allocator.
//
// Segment layout.
//
// Objects in a segment are laid out sequentially. Each object is preceded by
// a descriptor (see object_descriptor). Object alignment is respected, so if
// there is a gap between the end of current object and the next object's
// descriptor, a trunk of the object descriptor is left right after the
// current object with the flags byte indicating the amount of padding.
//
// Per-segment metadata is kept in a separate array, managed by segment_pool
// object.
//
class region_impl final : public basic_region_impl {
// Serialized object descriptor format:
// byte0 byte1 ... byte[n-1]
// bit0-bit5: ULEB64 significand
// bit6: 1 iff first byte
// bit7: 1 iff last byte
// This format allows decoding both forwards and backwards (by scanning for bit7/bit6 respectively);
// backward decoding is needed to recover the descriptor from the object pointer when freeing.
//
// Significand interpretation (value = n):
// even: dead object, size n/2 (including descriptor)
// odd: migrate_fn_type at index n/2, from static_migrators()
class object_descriptor {
private:
uint32_t _n;
private:
explicit object_descriptor(uint32_t n) : _n(n) {}
public:
object_descriptor(allocation_strategy::migrate_fn migrator)
: _n(migrator->index() * 2 + 1)
{ }
static object_descriptor make_dead(size_t size) {
return object_descriptor(size * 2);
}
allocation_strategy::migrate_fn migrator() const {
return static_migrators()[_n / 2];
}
uint8_t alignment() const {
return migrator()->align();
}
// excluding descriptor
segment::size_type live_size(const void* obj) const {
return migrator()->size(obj);
}
// including descriptor
segment::size_type dead_size() const {
return _n / 2;
}
bool is_live() const {
return (_n & 1) == 1;
}
segment::size_type encoded_size() const {
return utils::uleb64_encoded_size(_n); // 0 is illegal
}
void encode(char*& pos) const {
utils::uleb64_encode(pos, _n, poison<char>, unpoison);
}
// non-canonical encoding to allow padding (for alignment); encoded_size must be
// sufficient (greater than this->encoded_size()), _n must be the migrator's
// index() (i.e. -- suitable for express encoding)
void encode(char*& pos, size_t encoded_size, size_t size) const {
utils::uleb64_express_encode(pos, _n, encoded_size, size, poison<char>, unpoison);
}
static object_descriptor decode_forwards(const char*& pos) {
return object_descriptor(utils::uleb64_decode_forwards(pos, poison<char>, unpoison));
}
static object_descriptor decode_backwards(const char*& pos) {
return object_descriptor(utils::uleb64_decode_bacwards(pos, poison<char>, unpoison));
}
friend std::ostream& operator<<(std::ostream& out, const object_descriptor& desc) {
if (!desc.is_live()) {
return out << format("{{free {:d}}}", desc.dead_size());
} else {
auto m = desc.migrator();
auto x = reinterpret_cast<uintptr_t>(&desc) + sizeof(desc);
x = align_up(x, m->align());
auto obj = reinterpret_cast<const void*>(x);
return out << format("{{migrator={:p}, alignment={:d}, size={:d}}}",
(void*)m, m->align(), m->size(obj));
}
}
};
private: // lsa_buffer allocator
segment* _buf_active = nullptr;
size_t _buf_active_offset;
static constexpr size_t buf_align = 4096; // All lsa_buffer:s will have addresses aligned to this value.
// Emergency storage to ensure forward progress during segment compaction,
// by ensuring that _buf_pointers allocation inside new_buf_active() does not fail.
std::vector<entangled> _buf_ptrs_for_compact_segment;
private:
region* _region = nullptr;
region_group* _group = nullptr;
segment* _active = nullptr;
size_t _active_offset;
segment_descriptor_hist _segment_descs; // Contains only closed segments
occupancy_stats _closed_occupancy;
occupancy_stats _non_lsa_occupancy;
// This helps us keeping track of the region_group* heap. That's because we call update before
// we have a chance to update the occupancy stats - mainly because at this point we don't know
// what will we do with the new segment. Also, because we are not ever interested in the
// fraction used, we'll keep it as a scalar and convert when we need to present it as an
// occupancy. We could actually just present this as a scalar as well and never use occupancies,
// but consistency is good.
size_t _evictable_space = 0;
// This is a mask applied to _evictable_space with bitwise-and before it's returned from evictable_space().
// Used for forcing the result to zero without using conditionals.
size_t _evictable_space_mask = std::numeric_limits<size_t>::max();
bool _evictable = false;
region_sanitizer _sanitizer;
uint64_t _id;
eviction_fn _eviction_fn;
region_group::region_heap::handle_type _heap_handle;
private:
struct compaction_lock {
region_impl& _region;
bool _prev;
compaction_lock(region_impl& r)
: _region(r)
, _prev(r._reclaiming_enabled)
{
_region._reclaiming_enabled = false;
}
~compaction_lock() {
_region._reclaiming_enabled = _prev;
}
};
void* alloc_small(const object_descriptor& desc, segment::size_type size, size_t alignment) {
if (!_active) {
_active = new_segment();
_active_offset = 0;
}
auto desc_encoded_size = desc.encoded_size();
size_t obj_offset = align_up_for_asan(align_up(_active_offset + desc_encoded_size, alignment));
if (obj_offset + size > segment::size) {
close_and_open();
return alloc_small(desc, size, alignment);
}
auto old_active_offset = _active_offset;
auto pos = _active->at<char>(_active_offset);
// Use non-canonical encoding to allow for alignment pad
desc.encode(pos, obj_offset - _active_offset, size);
unpoison(pos, size);
_active_offset = obj_offset + size;
// Align the end of the value so that the next descriptor is aligned
_active_offset = align_up_for_asan(_active_offset);
_active->record_alloc(_active_offset - old_active_offset);
return pos;
}
template<typename Func>
void for_each_live(segment* seg, Func&& func) {
// scylla-gdb.py:scylla_lsa_segment is coupled with this implementation.
static_assert(std::is_same<void, std::result_of_t<Func(const object_descriptor*, void*, size_t)>>::value, "bad Func signature");
auto pos = align_up_for_asan(seg->at<const char>(0));
while (pos < seg->at<const char>(segment::size)) {
auto old_pos = pos;
const auto desc = object_descriptor::decode_forwards(pos);
if (desc.is_live()) {
auto size = desc.live_size(pos);
func(&desc, const_cast<char*>(pos), size);
pos += size;
} else {
pos = old_pos + desc.dead_size();
}
pos = align_up_for_asan(pos);
}
}
void close_active() {
if (!_active) {
return;
}
if (_active_offset < segment::size) {
auto desc = object_descriptor::make_dead(segment::size - _active_offset);
auto pos =_active->at<char>(_active_offset);
desc.encode(pos);
}
llogger.trace("Closing segment {}, used={}, waste={} [B]", fmt::ptr(_active), _active->occupancy(), segment::size - _active_offset);
_closed_occupancy += _active->occupancy();
_segment_descs.push(shard_segment_pool.descriptor(_active));
_active = nullptr;
}
void close_buf_active() {
if (!_buf_active) {
return;
}
llogger.trace("Closing buf segment {}, used={}, waste={} [B]", fmt::ptr(_buf_active), _buf_active->occupancy(), segment::size - _buf_active_offset);
_closed_occupancy += _buf_active->occupancy();
_segment_descs.push(shard_segment_pool.descriptor(_buf_active));
_buf_active = nullptr;
}
void free_segment(segment_descriptor& desc) noexcept {
free_segment(shard_segment_pool.segment_from(desc), desc);
}
void free_segment(segment* seg) noexcept {
free_segment(seg, shard_segment_pool.descriptor(seg));
}
void free_segment(segment* seg, segment_descriptor& desc) noexcept {
shard_segment_pool.free_segment(seg, desc);
if (_group) {
_evictable_space -= segment_size;
_group->decrease_usage(_heap_handle, -segment::size);
}
}
segment* new_segment() {
segment* seg = shard_segment_pool.new_segment(this);
if (_group) {
_evictable_space += segment_size;
_group->increase_usage(_heap_handle, segment::size);
}
return seg;
}
lsa_buffer alloc_buf(size_t buf_size) {
static_assert(segment::size % buf_align == 0);
if (buf_size > segment::size) {
throw_with_backtrace<std::runtime_error>(format("Buffer size {} too large", buf_size));
}
if (_buf_active_offset + buf_size > segment::size) {
close_buf_active();
}
if (!_buf_active) {
new_buf_active();
}
lsa_buffer ptr;
ptr._buf = _buf_active->at<char>(_buf_active_offset);
ptr._size = buf_size;
unpoison(ptr._buf, buf_size);
segment_descriptor& desc = shard_segment_pool.descriptor(_buf_active);
ptr._desc = &desc;
desc._buf_pointers.emplace_back(entangled::make_paired_with(ptr._link));
desc.record_alloc(buf_size);
_buf_active_offset += align_up(buf_size, buf_align);
return ptr;
}
void free_buf(lsa_buffer& buf) noexcept {
segment_descriptor &desc = *buf._desc;
segment *seg = shard_segment_pool.segment_from(desc);
if (seg != _buf_active) {
_closed_occupancy -= seg->occupancy();
}
desc.record_free(buf._size);
poison(buf._buf, buf._size);
// Pack links so that segment compaction only has to walk live objects.
// This procedure also ensures that the link for buf is destroyed, either
// by replacing it with the last entangled, or by popping it from the back
// if it is the last element.
// Moving entangled links around is fine so we can move last_link.
entangled& last_link = desc._buf_pointers.back();
entangled& buf_link = *buf._link.get();
std::swap(last_link, buf_link);
desc._buf_pointers.pop_back();
if (seg != _buf_active) {
if (desc.is_empty()) {
_segment_descs.erase(desc);
desc._buf_pointers = std::vector<entangled>();
free_segment(seg, desc);
} else {
_segment_descs.adjust_up(desc);
_closed_occupancy += desc.occupancy();
}
}
}
void compact_segment_locked(segment* seg, segment_descriptor& desc) {
auto seg_occupancy = desc.occupancy();
llogger.debug("Compacting segment {} from region {}, {}", fmt::ptr(seg), id(), seg_occupancy);
++_invalidate_counter;
if (desc.kind() == segment_kind::bufs) {
// This will free the storage of _buf_ptrs_for_compact_segment
// making sure that alloc_buf() makes progress.
// Also, empties desc._buf_pointers, making it back a generic segment, which
// we need to do before freeing it.
_buf_ptrs_for_compact_segment = std::move(desc._buf_pointers);
for (entangled& e : _buf_ptrs_for_compact_segment) {
if (e) {
lsa_buffer* old_ptr = e.get(&lsa_buffer::_link);
lsa_buffer dst = alloc_buf(old_ptr->_size);
memcpy(dst._buf, old_ptr->_buf, dst._size);
old_ptr->_link = std::move(dst._link);
old_ptr->_buf = dst._buf;
old_ptr->_desc = dst._desc;
}
}
} else {
for_each_live(seg, [this](const object_descriptor *desc, void *obj, size_t size) {
auto dst = alloc_small(*desc, size, desc->alignment());
_sanitizer.on_migrate(obj, size, dst);
desc->migrator()->migrate(obj, dst, size);
});
}
free_segment(seg, desc);
shard_segment_pool.on_segment_compaction(seg_occupancy.used_space());
}
void close_and_open() {
segment* new_active = new_segment();
close_active();
_active = new_active;
_active_offset = 0;
}
void new_buf_active() {
std::vector<entangled> ptrs;
ptrs.reserve(segment::size / buf_align);
segment* new_active = new_segment();
assert((uintptr_t)new_active->at(0) % buf_align == 0);
segment_descriptor& desc = shard_segment_pool.descriptor(new_active);
desc._buf_pointers = std::move(ptrs);
desc.set_kind(segment_kind::bufs);
_buf_active = new_active;
_buf_active_offset = 0;
}
static uint64_t next_id() {
static std::atomic<uint64_t> id{0};
return id.fetch_add(1);
}
struct degroup_temporarily {
region_impl* impl;
region_group* group;
explicit degroup_temporarily(region_impl* impl)
: impl(impl), group(impl->_group) {
if (group) {
group->del(impl);
}
}
~degroup_temporarily() {
if (group) {
group->add(impl);
}
}
};
public:
explicit region_impl(region* region, region_group* group = nullptr)
: _region(region), _group(group), _id(next_id())
{
_buf_ptrs_for_compact_segment.reserve(segment::size / buf_align);
_preferred_max_contiguous_allocation = max_managed_object_size;
tracker_instance._impl->register_region(this);
try {
if (group) {
group->add(this);
}
} catch (...) {
tracker_instance._impl->unregister_region(this);
throw;
}
}
virtual ~region_impl() {
_sanitizer.on_region_destruction();
tracker_instance._impl->unregister_region(this);
while (!_segment_descs.empty()) {
auto& desc = _segment_descs.one_of_largest();
_segment_descs.pop_one_of_largest();
assert(desc.is_empty());
free_segment(desc);
}
_closed_occupancy = {};
if (_active) {
assert(_active->is_empty());
free_segment(_active);
_active = nullptr;
}
if (_buf_active) {
assert(_buf_active->is_empty());
free_segment(_buf_active);
_buf_active = nullptr;
}
if (_group) {
_group->del(this);
}
}
region_impl(region_impl&&) = delete;
region_impl(const region_impl&) = delete;
bool empty() const {
return occupancy().used_space() == 0;
}
occupancy_stats occupancy() const {
occupancy_stats total = _non_lsa_occupancy;
total += _closed_occupancy;
if (_active) {
total += _active->occupancy();
}
if (_buf_active) {
total += _buf_active->occupancy();
}
return total;
}
region_group* group() {
return _group;
}
occupancy_stats compactible_occupancy() const {
return _closed_occupancy;
}
occupancy_stats evictable_occupancy() const {
return occupancy_stats(0, _evictable_space & _evictable_space_mask);
}
void ground_evictable_occupancy() {
_evictable_space_mask = 0;
if (_group) {
_group->decrease_evictable_usage(_heap_handle);
}
}
//
// Returns true if this region can be compacted and compact() will make forward progress,
// so that this will eventually stop:
//
// while (is_compactible()) { compact(); }
//
bool is_compactible() const {
return _reclaiming_enabled
// We require 2 segments per allocation segregation group to ensure forward progress during compaction.
// There are currently two fixed groups, one for the allocation_strategy implementation and one for lsa_buffer:s.
&& (_closed_occupancy.free_space() >= 4 * segment::size)
&& _segment_descs.contains_above_min();
}
bool is_idle_compactible() {
return is_compactible();
}
virtual void* alloc(allocation_strategy::migrate_fn migrator, size_t size, size_t alignment) override {
compaction_lock _(*this);
memory::on_alloc_point();
shard_segment_pool.on_memory_allocation(size);
if (size > max_managed_object_size) {
auto ptr = standard_allocator().alloc(migrator, size, alignment);
// This isn't very acurrate, the correct free_space value would be
// malloc_usable_size(ptr) - size, but there is no way to get
// the exact object size at free.
auto allocated_size = malloc_usable_size(ptr);
_non_lsa_occupancy += occupancy_stats(0, allocated_size);
if (_group) {
_evictable_space += allocated_size;
_group->increase_usage(_heap_handle, allocated_size);
}
shard_segment_pool.update_non_lsa_memory_in_use(allocated_size);
return ptr;
} else {
auto ptr = alloc_small(object_descriptor(migrator), (segment::size_type) size, alignment);
_sanitizer.on_allocation(ptr, size);
return ptr;
}
}
private:
void on_non_lsa_free(void* obj) noexcept {
auto allocated_size = malloc_usable_size(obj);
_non_lsa_occupancy -= occupancy_stats(0, allocated_size);
if (_group) {
_evictable_space -= allocated_size;
_group->decrease_usage(_heap_handle, allocated_size);
}
shard_segment_pool.update_non_lsa_memory_in_use(-allocated_size);
}
public:
virtual void free(void* obj) noexcept override {
compaction_lock _(*this);
segment* seg = shard_segment_pool.containing_segment(obj);
if (!seg) {
on_non_lsa_free(obj);
standard_allocator().free(obj);
return;
}
auto pos = reinterpret_cast<const char*>(obj);
auto desc = object_descriptor::decode_backwards(pos);
free(obj, desc.live_size(obj));
}
virtual void free(void* obj, size_t size) noexcept override {
compaction_lock _(*this);
segment* seg = shard_segment_pool.containing_segment(obj);
if (!seg) {
on_non_lsa_free(obj);
standard_allocator().free(obj, size);
return;
}
_sanitizer.on_free(obj, size);
segment_descriptor& seg_desc = shard_segment_pool.descriptor(seg);
auto pos = reinterpret_cast<const char*>(obj);
auto old_pos = pos;
auto desc = object_descriptor::decode_backwards(pos);
auto dead_size = align_up_for_asan(size + (old_pos - pos));
desc = object_descriptor::make_dead(dead_size);
auto npos = const_cast<char*>(pos);
desc.encode(npos);
poison(pos, dead_size);
if (seg != _active) {
_closed_occupancy -= seg->occupancy();
}
seg_desc.record_free(dead_size);
if (seg != _active) {
if (seg_desc.is_empty()) {
_segment_descs.erase(seg_desc);
free_segment(seg, seg_desc);
} else {
_segment_descs.adjust_up(seg_desc);
_closed_occupancy += seg_desc.occupancy();
}
}
}
virtual size_t object_memory_size_in_allocator(const void* obj) const noexcept override {
segment* seg = shard_segment_pool.containing_segment(obj);
if (!seg) {
return standard_allocator().object_memory_size_in_allocator(obj);
} else {
auto pos = reinterpret_cast<const char*>(obj);
auto desc = object_descriptor::decode_backwards(pos);
return desc.encoded_size() + desc.live_size(obj);
}
}
// Merges another region into this region. The other region is made
// to refer to this region.
// Doesn't invalidate references to allocated objects.
void merge(region_impl& other) noexcept {
// degroup_temporarily allocates via binomial_heap::push(), which should not
// fail, because we have a matching deallocation before that and we don't
// allocate between them.
memory::scoped_critical_alloc_section dfg;
compaction_lock dct1(*this);
compaction_lock dct2(other);
degroup_temporarily dgt1(this);
degroup_temporarily dgt2(&other);
if (_active && _active->is_empty()) {
shard_segment_pool.free_segment(_active);
_active = nullptr;
}
if (!_active) {
_active = other._active;
other._active = nullptr;
_active_offset = other._active_offset;
if (_active) {
shard_segment_pool.set_region(_active, this);
}
} else {
other.close_active();
}
other.close_buf_active();
for (auto& desc : other._segment_descs) {
shard_segment_pool.set_region(desc, this);
}
_segment_descs.merge(other._segment_descs);
_closed_occupancy += other._closed_occupancy;
_non_lsa_occupancy += other._non_lsa_occupancy;
other._closed_occupancy = {};
other._non_lsa_occupancy = {};
// Make sure both regions will notice a future increment
// to the reclaim counter
_invalidate_counter = std::max(_invalidate_counter, other._invalidate_counter);
_sanitizer.merge(other._sanitizer);
other._sanitizer = { };
}
// Returns occupancy of the sparsest compactible segment.
occupancy_stats min_occupancy() const {
if (_segment_descs.empty()) {
return {};
}
return _segment_descs.one_of_largest().occupancy();
}
// Compacts a single segment, most appropriate for it
void compact() {
compaction_lock _(*this);
auto& desc = _segment_descs.one_of_largest();
_segment_descs.pop_one_of_largest();
_closed_occupancy -= desc.occupancy();
segment* seg = shard_segment_pool.segment_from(desc);
compact_segment_locked(seg, desc);
}
// Compacts everything. Mainly for testing.
// Invalidates references to allocated objects.
void full_compaction() {
compaction_lock _(*this);
llogger.debug("Full compaction, {}", occupancy());
close_and_open();
close_buf_active();
segment_descriptor_hist all;
std::swap(all, _segment_descs);
_closed_occupancy = {};
while (!all.empty()) {
auto& desc = all.one_of_largest();
all.pop_one_of_largest();
compact_segment_locked(shard_segment_pool.segment_from(desc), desc);
}
llogger.debug("Done, {}", occupancy());
}
void compact_segment(segment* seg, segment_descriptor& desc) {
compaction_lock _(*this);
if (_active == seg) {
close_active();
} else if (_buf_active == seg) {
close_buf_active();
}
_segment_descs.erase(desc);
_closed_occupancy -= desc.occupancy();
compact_segment_locked(seg, desc);
}
allocation_strategy& allocator() {
return *this;
}
uint64_t id() const {
return _id;
}
// Returns true if this pool is evictable, so that evict_some() can be called.
bool is_evictable() const {
return _evictable && _reclaiming_enabled;
}
memory::reclaiming_result evict_some() {
++_invalidate_counter;
return _eviction_fn();
}
void make_not_evictable() {
_evictable = false;
_eviction_fn = {};
}
void make_evictable(eviction_fn fn) {
_evictable = true;
_eviction_fn = std::move(fn);
}
const eviction_fn& evictor() const {
return _eviction_fn;
}
friend class region;
friend class lsa_buffer;
friend class region_group;
friend class region_group::region_evictable_occupancy_ascending_less_comparator;
};
lsa_buffer::~lsa_buffer() {
if (_link) {
_desc->_region->free_buf(*this);
}
}
inline void
region_group_binomial_group_sanity_check(const region_group::region_heap& bh) {
#ifdef SEASTAR_DEBUG
bool failed = false;
size_t last = std::numeric_limits<size_t>::max();
for (auto b = bh.ordered_begin(); b != bh.ordered_end(); b++) {
auto t = (*b)->evictable_occupancy().total_space();
if (!(t <= last)) {
failed = true;
break;
}
last = t;
}
if (!failed) {
return;
}
printf("Sanity checking FAILED, size %ld\n", bh.size());
for (auto b = bh.ordered_begin(); b != bh.ordered_end(); b++) {
auto r = (*b);
auto t = r->evictable_occupancy().total_space();
printf(" r = %p (id=%ld), occupancy = %ld\n",r, r->id(), t);
}
assert(0);
#endif
}
size_t tracker::reclamation_step() const {
return _impl->reclamation_step();
}
bool tracker::should_abort_on_bad_alloc() {
return _impl->should_abort_on_bad_alloc();
}
void tracker::configure(const config& cfg) {
if (cfg.defragment_on_idle) {
engine().set_idle_cpu_handler([this] (reactor::work_waiting_on_reactor check_for_work) {
return _impl->compact_on_idle(check_for_work);
});
}
_impl->set_reclamation_step(cfg.lsa_reclamation_step);
if (cfg.abort_on_lsa_bad_alloc) {
_impl->enable_abort_on_bad_alloc();
}
_impl->setup_background_reclaim(cfg.background_reclaim_sched_group);
s_sanitizer_report_backtrace = cfg.sanitizer_report_backtrace;
}
memory::reclaiming_result tracker::reclaim(seastar::memory::reclaimer::request r) {
return reclaim(std::max(r.bytes_to_reclaim, _impl->reclamation_step() * segment::size))
? memory::reclaiming_result::reclaimed_something
: memory::reclaiming_result::reclaimed_nothing;
}
bool
region_group::region_evictable_occupancy_ascending_less_comparator::operator()(region_impl* r1, region_impl* r2) const {
return r1->evictable_occupancy().total_space() < r2->evictable_occupancy().total_space();
}
region::region()
: _impl(make_shared<impl>(this))
{ }
region::region(region_group& group)
: _impl(make_shared<impl>(this, &group)) {
}
region_impl& region::get_impl() {
return *static_cast<region_impl*>(_impl.get());
}
const region_impl& region::get_impl() const {
return *static_cast<const region_impl*>(_impl.get());
}
region::region(region&& other) {
this->_impl = std::move(other._impl);
get_impl()._region = this;
}
region& region::operator=(region&& other) {
this->_impl = std::move(other._impl);
get_impl()._region = this;
return *this;
}
region::~region() {
}
occupancy_stats region::occupancy() const {
return get_impl().occupancy();
}
region_group* region::group() {
return get_impl().group();
}
lsa_buffer region::alloc_buf(size_t buffer_size) {
return get_impl().alloc_buf(buffer_size);
}
void region::merge(region& other) noexcept {
if (_impl != other._impl) {
get_impl().merge(other.get_impl());
other._impl = _impl;
}
}
void region::full_compaction() {
get_impl().full_compaction();
}
memory::reclaiming_result region::evict_some() {
if (get_impl().is_evictable()) {
return get_impl().evict_some();
}
return memory::reclaiming_result::reclaimed_nothing;
}
void region::make_evictable(eviction_fn fn) {
get_impl().make_evictable(std::move(fn));
}
void region::ground_evictable_occupancy() {
get_impl().ground_evictable_occupancy();
}
occupancy_stats region::evictable_occupancy() {
return get_impl().evictable_occupancy();
}
const eviction_fn& region::evictor() const {
return get_impl().evictor();
}
std::ostream& operator<<(std::ostream& out, const occupancy_stats& stats) {
return out << format("{:.2f}%, {:d} / {:d} [B]",
stats.used_fraction() * 100, stats.used_space(), stats.total_space());
}
occupancy_stats tracker::impl::region_occupancy() {
reclaiming_lock _(*this);
occupancy_stats total{};
for (auto&& r: _regions) {
total += r->occupancy();
}
return total;
}
occupancy_stats tracker::impl::occupancy() {
reclaiming_lock _(*this);
auto occ = region_occupancy();
{
auto s = shard_segment_pool.free_segments() * segment::size;
occ += occupancy_stats(s, s);
}
return occ;
}
size_t tracker::impl::non_lsa_used_space() {
#ifdef SEASTAR_DEFAULT_ALLOCATOR
return 0;
#else
auto free_space_in_lsa = shard_segment_pool.free_segments() * segment_size;
return memory::stats().allocated_memory() - region_occupancy().total_space() - free_space_in_lsa;
#endif
}
void tracker::impl::reclaim_all_free_segments()
{
llogger.debug("Reclaiming all free segments");
shard_segment_pool.reclaim_all_free_segments();
llogger.debug("Reclamation done");
}
void tracker::impl::full_compaction() {
reclaiming_lock _(*this);
llogger.debug("Full compaction on all regions, {}", region_occupancy());
for (region_impl* r : _regions) {
if (r->reclaiming_enabled()) {
r->full_compaction();
}
}
llogger.debug("Compaction done, {}", region_occupancy());
}
static void reclaim_from_evictable(region::impl& r, size_t target_mem_in_use, is_preemptible preempt) {
llogger.debug("reclaim_from_evictable: total_memory_in_use={} target={}", shard_segment_pool.total_memory_in_use(), target_mem_in_use);
// Before attempting segment compaction, try to evict at least deficit and one segment more so that
// for workloads in which eviction order matches allocation order we will reclaim full segments
// without needing to perform expensive compaction.
auto deficit = shard_segment_pool.total_memory_in_use() - target_mem_in_use;
auto used = r.occupancy().used_space();
auto used_target = used - std::min(used, deficit + segment::size);
while (shard_segment_pool.total_memory_in_use() > target_mem_in_use) {
used = r.occupancy().used_space();
if (used > used_target) {
llogger.debug("Evicting {} bytes from region {}, occupancy={} in advance",
used - used_target, r.id(), r.occupancy());
} else {
llogger.debug("Evicting from region {}, occupancy={} until it's compactible", r.id(), r.occupancy());
}
while (r.occupancy().used_space() > used_target || !r.is_compactible()) {
if (r.evict_some() == memory::reclaiming_result::reclaimed_nothing) {
if (r.is_compactible()) { // Need to make forward progress in case there is nothing to evict.
break;
}
llogger.debug("Unable to evict more, evicted {} bytes", used - r.occupancy().used_space());
return;
}
if (preempt && need_preempt()) {
llogger.debug("reclaim_from_evictable preempted");
return;
}
}
// If there are many compactible segments, we will keep compacting without
// entering the eviction loop above. So the preemption check there is not
// sufficient and we also need to check here.
//
// Note that a preemptible reclaim_from_evictable may not do any real progress,
// but it doesn't need to. Preemptible (background) reclaim is an optimization.
// If the system is overwhelmed, and reclaim_from_evictable keeps getting
// preempted without doing any useful work, then eventually memory will be
// exhausted and reclaim will be called synchronously, without preemption.
if (preempt && need_preempt()) {
llogger.debug("reclaim_from_evictable preempted");
return;
}
llogger.debug("Compacting after evicting {} bytes", used - r.occupancy().used_space());
r.compact();
}
}
struct reclaim_timer {
clock::time_point start;
bool enabled;
reclaim_timer() {
if (timing_logger.is_enabled(logging::log_level::debug)) {
start = clock::now();
enabled = true;
} else {
enabled = false;
}
}
~reclaim_timer() {
if (enabled) {
auto duration = clock::now() - start;
timing_logger.debug("Reclamation cycle took {} us.",
std::chrono::duration_cast<std::chrono::duration<double, std::micro>>(duration).count());
}
}
void stop(size_t released) {
if (enabled) {
enabled = false;
auto duration = clock::now() - start;
auto bytes_per_second = static_cast<float>(released) / std::chrono::duration_cast<std::chrono::duration<float>>(duration).count();
timing_logger.debug("Reclamation cycle took {} us. Reclamation rate = {} MiB/s",
std::chrono::duration_cast<std::chrono::duration<double, std::micro>>(duration).count(),
format("{:.3f}", bytes_per_second / (1024*1024)));
}
}
};
idle_cpu_handler_result tracker::impl::compact_on_idle(work_waiting_on_reactor check_for_work) {
if (!_reclaiming_enabled) {
return idle_cpu_handler_result::no_more_work;
}
reclaiming_lock rl(*this);
if (_regions.empty()) {
return idle_cpu_handler_result::no_more_work;
}
segment_pool::reservation_goal open_emergency_pool(shard_segment_pool, 0);
auto cmp = [] (region::impl* c1, region::impl* c2) {
if (c1->is_idle_compactible() != c2->is_idle_compactible()) {
return !c1->is_idle_compactible();
}
return c2->min_occupancy() < c1->min_occupancy();
};
boost::range::make_heap(_regions, cmp);
while (!check_for_work()) {
boost::range::pop_heap(_regions, cmp);
region::impl* r = _regions.back();
if (!r->is_idle_compactible()) {
return idle_cpu_handler_result::no_more_work;
}
r->compact();
boost::range::push_heap(_regions, cmp);
}
return idle_cpu_handler_result::interrupted_by_higher_priority_task;
}
size_t tracker::impl::reclaim(size_t memory_to_release, is_preemptible preempt) {
// Reclamation steps:
// 1. Try to release free segments from segment pool and emergency reserve.
// 2. Compact used segments and/or evict data.
if (!_reclaiming_enabled) {
return 0;
}
reclaiming_lock rl(*this);
reclaim_timer timing_guard;
constexpr auto max_bytes = std::numeric_limits<size_t>::max() - segment::size;
auto segments_to_release = align_up(std::min(max_bytes, memory_to_release), segment::size) >> segment::size_shift;
auto nr_released = shard_segment_pool.reclaim_segments(segments_to_release, preempt);
size_t mem_released = nr_released * segment::size;
if (mem_released >= memory_to_release) {
return memory_to_release;
}
if (preempt && need_preempt()) {
return mem_released;
}
auto compacted = compact_and_evict_locked(shard_segment_pool.current_emergency_reserve_goal(), memory_to_release - mem_released, preempt);
if (compacted == 0) {
return mem_released;
}
// compact_and_evict_locked() will not return segments to the standard allocator,
// so do it here:
nr_released = shard_segment_pool.reclaim_segments(compacted / segment::size, preempt);
return mem_released + nr_released * segment::size;
}
size_t tracker::impl::compact_and_evict(size_t reserve_segments, size_t memory_to_release, is_preemptible preempt) {
if (!_reclaiming_enabled) {
return 0;
}
reclaiming_lock rl(*this);
reclaim_timer timing_guard;
size_t released = compact_and_evict_locked(reserve_segments, memory_to_release, preempt);
timing_guard.stop(released);
return released;
}
size_t tracker::impl::compact_and_evict_locked(size_t reserve_segments, size_t memory_to_release, is_preemptible preempt) {
//
// Algorithm outline.
//
// Regions are kept in a max-heap ordered so that regions with
// sparser segments are picked first. Non-compactible regions will be
// picked last. In each iteration we try to release one whole segment from
// the region which has the sparsest segment. We do it until we released
// enough segments or there are no more regions we can compact.
//
// When compaction is not sufficient to reclaim space, we evict data from
// evictable regions.
//
// This may run synchronously with allocation, so we should not allocate
// memory, otherwise we may get std::bad_alloc. Currently we only allocate
// in the logger when debug level is enabled. It's disabled during normal
// operation. Having it is still valuable during testing and in most cases
// should work just fine even if allocates.
size_t mem_released = 0;
size_t mem_in_use = shard_segment_pool.total_memory_in_use();
memory_to_release += (reserve_segments - std::min(reserve_segments, shard_segment_pool.free_segments())) * segment::size;
auto target_mem = mem_in_use - std::min(mem_in_use, memory_to_release - mem_released);
llogger.debug("Compacting, requested {} bytes, {} bytes in use, target is {}",
memory_to_release, mem_in_use, target_mem);
// Allow dipping into reserves while compacting
segment_pool::reservation_goal open_emergency_pool(shard_segment_pool, 0);
auto cmp = [] (region::impl* c1, region::impl* c2) {
if (c1->is_compactible() != c2->is_compactible()) {
return !c1->is_compactible();
}
return c2->min_occupancy() < c1->min_occupancy();
};
boost::range::make_heap(_regions, cmp);
if (llogger.is_enabled(logging::log_level::debug)) {
llogger.debug("Occupancy of regions:");
for (region::impl* r : _regions) {
llogger.debug(" - {}: min={}, avg={}", r->id(), r->min_occupancy(), r->compactible_occupancy());
}
}
while (shard_segment_pool.total_memory_in_use() > target_mem) {
boost::range::pop_heap(_regions, cmp);
region::impl* r = _regions.back();
if (!r->is_compactible()) {
llogger.trace("Unable to release segments, no compactible pools.");
break;
}
// Prefer evicting if average occupancy ratio is above the compaction threshold to avoid
// overhead of compaction in workloads where allocation order matches eviction order, where
// we can reclaim memory by eviction only. In some cases the cost of compaction on allocation
// would be higher than the cost of repopulating the region with evicted items.
if (r->is_evictable() && r->occupancy().used_space() >= max_used_space_ratio_for_compaction * r->occupancy().total_space()) {
reclaim_from_evictable(*r, target_mem, preempt);
} else {
r->compact();
}
boost::range::push_heap(_regions, cmp);
if (preempt && need_preempt()) {
break;
}
}
auto released_during_compaction = mem_in_use - shard_segment_pool.total_memory_in_use();
if (shard_segment_pool.total_memory_in_use() > target_mem) {
llogger.debug("Considering evictable regions.");
// FIXME: Fair eviction
for (region::impl* r : _regions) {
if (preempt && need_preempt()) {
break;
}
if (r->is_evictable()) {
reclaim_from_evictable(*r, target_mem, preempt);
if (shard_segment_pool.total_memory_in_use() <= target_mem) {
break;
}
}
}
}
mem_released += mem_in_use - shard_segment_pool.total_memory_in_use();
llogger.debug("Released {} bytes (wanted {}), {} during compaction",
mem_released, memory_to_release, released_during_compaction);
return mem_released;
}
void tracker::impl::register_region(region::impl* r) {
// If needed, increase capacity of regions before taking the reclaim lock,
// to avoid failing an allocation when push_back() tries to increase
// capacity.
//
// The capacity increase is atomic (wrt _regions) so it cannot be
// observed
if (_regions.size() == _regions.capacity()) {
auto copy = _regions;
copy.reserve(copy.capacity() * 2);
_regions = std::move(copy);
}
reclaiming_lock _(*this);
_regions.push_back(r);
llogger.debug("Registered region @{} with id={}", fmt::ptr(r), r->id());
}
void tracker::impl::unregister_region(region::impl* r) noexcept {
reclaiming_lock _(*this);
llogger.debug("Unregistering region, id={}", r->id());
_regions.erase(std::remove(_regions.begin(), _regions.end(), r), _regions.end());
}
tracker::impl::impl() {
namespace sm = seastar::metrics;
_metrics.add_group("lsa", {
sm::make_gauge("total_space_bytes", [this] { return region_occupancy().total_space(); },
sm::description("Holds a current size of allocated memory in bytes.")),
sm::make_gauge("used_space_bytes", [this] { return region_occupancy().used_space(); },
sm::description("Holds a current amount of used memory in bytes.")),
sm::make_gauge("small_objects_total_space_bytes", [this] { return region_occupancy().total_space() - shard_segment_pool.non_lsa_memory_in_use(); },
sm::description("Holds a current size of \"small objects\" memory region in bytes.")),
sm::make_gauge("small_objects_used_space_bytes", [this] { return region_occupancy().used_space() - shard_segment_pool.non_lsa_memory_in_use(); },
sm::description("Holds a current amount of used \"small objects\" memory in bytes.")),
sm::make_gauge("large_objects_total_space_bytes", [this] { return shard_segment_pool.non_lsa_memory_in_use(); },
sm::description("Holds a current size of allocated non-LSA memory.")),
sm::make_gauge("non_lsa_used_space_bytes", [this] { return non_lsa_used_space(); },
sm::description("Holds a current amount of used non-LSA memory.")),
sm::make_gauge("free_space", [this] { return shard_segment_pool.unreserved_free_segments() * segment_size; },
sm::description("Holds a current amount of free memory that is under lsa control.")),
sm::make_gauge("occupancy", [this] { return region_occupancy().used_fraction() * 100; },
sm::description("Holds a current portion (in percents) of the used memory.")),
sm::make_derive("segments_compacted", [this] { return shard_segment_pool.statistics().segments_compacted; },
sm::description("Counts a number of compacted segments.")),
sm::make_derive("memory_compacted", [this] { return shard_segment_pool.statistics().memory_compacted; },
sm::description("Counts number of bytes which were copied as part of segment compaction.")),
sm::make_derive("memory_allocated", [this] { return shard_segment_pool.statistics().memory_allocated; },
sm::description("Counts number of bytes which were requested from LSA allocator.")),
});
}
tracker::impl::~impl() {
if (!_regions.empty()) {
for (auto&& r : _regions) {
llogger.error("Region with id={} not unregistered!", r->id());
}
abort();
}
}
bool segment_pool::compact_segment(segment* seg) {
auto& desc = descriptor(seg);
if (!desc._region->reclaiming_enabled()) {
return false;
}
// Called with emergency reserve, open one for
// region::alloc_small not to throw if it needs
// one more segment
reservation_goal open_emergency_pool(*this, 0);
allocation_lock no_alloc(*this);
tracker_reclaimer_lock no_reclaim;
desc._region->compact_segment(seg, desc);
return true;
}
region_group_reclaimer region_group::no_reclaimer;
uint64_t region_group::top_region_evictable_space() const {
return _regions.empty() ? 0 : _regions.top()->evictable_occupancy().total_space();
}
region* region_group::get_largest_region() {
if (!_maximal_rg || _maximal_rg->_regions.empty()) {
return nullptr;
}
return _maximal_rg->_regions.top()->_region;
}
void
region_group::add(region_group* child) {
child->_subgroup_heap_handle = _subgroups.push(child);
update(child->_total_memory);
}
void
region_group::del(region_group* child) {
_subgroups.erase(child->_subgroup_heap_handle);
update(-child->_total_memory);
}
void
region_group::add(region_impl* child) {
child->_heap_handle = _regions.push(child);
region_group_binomial_group_sanity_check(_regions);
update(child->occupancy().total_space());
}
void
region_group::del(region_impl* child) {
_regions.erase(child->_heap_handle);
region_group_binomial_group_sanity_check(_regions);
update(-child->occupancy().total_space());
}
bool
region_group::execution_permitted() noexcept {
return do_for_each_parent(this, [] (auto rg) {
return rg->under_pressure() ? stop_iteration::yes : stop_iteration::no;
}) == nullptr;
}
future<>
region_group::start_releaser(scheduling_group deferred_work_sg) {
return with_scheduling_group(deferred_work_sg, [this] {
return later().then([this] {
return repeat([this] () noexcept {
if (_shutdown_requested) {
return make_ready_future<stop_iteration>(stop_iteration::yes);
}
if (!_blocked_requests.empty() && execution_permitted()) {
auto req = std::move(_blocked_requests.front());
_blocked_requests.pop_front();
req->allocate();
return make_ready_future<stop_iteration>(stop_iteration::no);
} else {
// Block reclaiming to prevent signal() from being called by reclaimer inside wait()
// FIXME: handle allocation failures (not very likely) like allocating_section does
tracker_reclaimer_lock rl;
return _relief.wait().then([] {
return stop_iteration::no;
});
}
});
});
});
}
region_group::region_group(sstring name, region_group *parent,
region_group_reclaimer& reclaimer, scheduling_group deferred_work_sg)
: _parent(parent)
, _reclaimer(reclaimer)
, _blocked_requests(on_request_expiry{std::move(name)})
, _releaser(reclaimer_can_block() ? start_releaser(deferred_work_sg) : make_ready_future<>())
{
if (_parent) {
_parent->add(this);
}
}
bool region_group::reclaimer_can_block() const {
return _reclaimer.throttle_threshold() != std::numeric_limits<size_t>::max();
}
void region_group::notify_relief() {
_relief.signal();
for (region_group* child : _subgroups) {
child->notify_relief();
}
}
void region_group::update(ssize_t delta) {
// Most-enclosing group which was relieved.
region_group* top_relief = nullptr;
do_for_each_parent(this, [&top_relief, delta] (region_group* rg) mutable {
rg->update_maximal_rg();
rg->_total_memory += delta;
if (rg->_total_memory >= rg->_reclaimer.soft_limit_threshold()) {
rg->_reclaimer.notify_soft_pressure();
} else {
rg->_reclaimer.notify_soft_relief();
}
if (rg->_total_memory > rg->_reclaimer.throttle_threshold()) {
rg->_reclaimer.notify_pressure();
} else if (rg->_reclaimer.under_pressure()) {
rg->_reclaimer.notify_relief();
top_relief = rg;
}
return stop_iteration::no;
});
if (top_relief) {
top_relief->notify_relief();
}
}
allocating_section::guard::guard()
: _prev(shard_segment_pool.emergency_reserve_max())
{ }
allocating_section::guard::~guard() {
shard_segment_pool.set_emergency_reserve_max(_prev);
}
void allocating_section::maybe_decay_reserve() {
// The decay rate is inversely proportional to the reserve
// (every (s_segments_per_decay/_lsa_reserve) allocations).
//
// If the reserve is high, it is expensive since we may need to
// evict a lot of memory to satisfy the reserve. Hence, we are
// willing to risk a more frequent bad_alloc in order to decay it.
// The cost of a bad_alloc is also lower compared to maintaining
// the reserve.
//
// If the reserve is low, it is not expensive to maintain, so we
// decay it at a lower rate.
_remaining_lsa_segments_until_decay -= _lsa_reserve;
if (_remaining_lsa_segments_until_decay < 0) {
_remaining_lsa_segments_until_decay = s_segments_per_decay;
_lsa_reserve = std::max(s_min_lsa_reserve, _lsa_reserve / 2);
llogger.debug("Decaying LSA reserve in section {} to {} segments", static_cast<void*>(this), _lsa_reserve);
}
_remaining_std_bytes_until_decay -= _std_reserve;
if (_remaining_std_bytes_until_decay < 0) {
_remaining_std_bytes_until_decay = s_bytes_per_decay;
_std_reserve = std::max(s_min_std_reserve, _std_reserve / 2);
llogger.debug("Decaying standard allocator head-room in section {} to {} [B]", static_cast<void*>(this), _std_reserve);
}
}
void allocating_section::reserve() {
try {
shard_segment_pool.set_emergency_reserve_max(std::max(_lsa_reserve, _minimum_lsa_emergency_reserve));
shard_segment_pool.refill_emergency_reserve();
while (true) {
size_t free = memory::stats().free_memory();
if (free >= _std_reserve) {
break;
}
if (!tracker_instance.reclaim(_std_reserve - free)) {
throw std::bad_alloc();
}
}
shard_segment_pool.clear_allocation_failure_flag();
} catch (const std::bad_alloc&) {
if (shard_tracker().should_abort_on_bad_alloc()) {
llogger.error("Aborting due to allocation failure");
abort();
}
throw;
}
}
void allocating_section::on_alloc_failure(logalloc::region& r) {
r.allocator().invalidate_references();
if (shard_segment_pool.allocation_failure_flag()) {
_lsa_reserve *= 2;
llogger.debug("LSA allocation failure, increasing reserve in section {} to {} segments", fmt::ptr(this), _lsa_reserve);
} else {
_std_reserve *= 2;
llogger.debug("Standard allocator failure, increasing head-room in section {} to {} [B]", fmt::ptr(this), _std_reserve);
}
reserve();
}
void allocating_section::set_lsa_reserve(size_t reserve) {
_lsa_reserve = reserve;
}
void allocating_section::set_std_reserve(size_t reserve) {
_std_reserve = reserve;
}
void region_group::on_request_expiry::operator()(std::unique_ptr<allocating_function>& func) noexcept {
func->fail(std::make_exception_ptr(blocked_requests_timed_out_error{_name}));
}
future<> prime_segment_pool(size_t available_memory, size_t min_free_memory) {
return smp::invoke_on_all([=] {
shard_segment_pool.prime(available_memory, min_free_memory);
});
}
uint64_t memory_allocated() {
return shard_segment_pool.statistics().memory_allocated;
}
uint64_t memory_compacted() {
return shard_segment_pool.statistics().memory_compacted;
}
occupancy_stats lsa_global_occupancy_stats() {
return occupancy_stats(shard_segment_pool.total_free_memory(), shard_segment_pool.total_memory_in_use());
}
}
// Orders segments by free space, assuming all segments have the same size.
// This avoids using the occupancy, which entails extra division operations.
template<>
size_t hist_key<logalloc::segment_descriptor>(const logalloc::segment_descriptor& desc) {
return desc.free_space();
}