mirrors/scylladb
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
0eefbfa3ccec3faada8a2fc2f0a82c8fb16ec633
scylladb/test/boost
History
Avi Kivity 53e0dc7530 bytes_ostream: base on managed_bytes 
bytes_ostream is an incremental builder for a discontiguous byte container.
managed_bytes is a non-incremental (size must be known up front) byte
container, that is also compatible with LSA. So far, conversion between
them involves copying. This is unfortunate, since query_result is generated
as a bytes_ostream, but is later converted to managed_bytes (today, this
is done in cql3::expr::get_non_pk_values() and
compound_view_wrapper::explode(). If the two types could be made compatible,
we could use managed_bytes_view instead of creating new objects and avoid
a copy. It's also nicer to have one less vocabulary type.

This patch makes bytes_ostream use managed_bytes' internal representation
(blob_storage instead of bytes_ostream::chunk) and provides a conversion
to managed_bytes. All bytes_ostream users are left in place, but the goal
is to make bytes_ostream a write-only type with the only observer a conversion
to managed_bytes.

It turns out to be relatively simple. The internal representations were
already similar. I made blob_storage::ref_type self-initializing to
reduce churn (good practice anyway) and added a private constructor
to managed_bytes for the conversion.

Note that bytes_ostream can only be used to construct a non-LSA managed_bytes,
but LSA uses of managed_bytes are very strictly controlled (the entry
points to memtable and cache) so that's not a problem.

A unit test is added.

Closes #10986
2022-07-12 00:23:29 +03:00
..
aggregate_fcts_test.cc
treewide: clean up stray license blurbs
2022-02-13 14:16:16 +02:00
allocation_strategy_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
alternator_unit_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
anchorless_list_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_passwords_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_resource_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
auth_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
batchlog_manager_test.cc
query_processor: remove default internal query caching behavior
2022-05-01 08:33:55 +03:00
big_decimal_test.cc
treewide: clean up stray license blurbs
2022-02-13 14:16:16 +02:00
bptree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
broken_sstable_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
btree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
bytes_ostream_test.cc
bytes_ostream: base on managed_bytes
2022-07-12 00:23:29 +03:00
cache_flat_mutation_reader_test.cc
row_cache: return v2 readers from make_reader*()
2022-04-20 10:59:09 +03:00
cached_file_test.cc
tests: utils: cached_file: Validate occupancy after eviction
2022-02-25 01:42:15 +01:00
caching_options_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
canonical_mutation_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cartesian_product_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
castas_fcts_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cdc_generation_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cdc_test.cc
test/boost: cdc_test: remove test_cdc_across_shards
2022-06-23 16:14:41 +02:00
cell_locker_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
checksum_utils_test.cc
checksum_utils_test: supply valid input to crc32_combine()
2022-06-21 11:58:13 +03:00
chunked_managed_vector_test.cc
utils/chunked_managed_vector: Fix sigsegv during reserve()
2022-04-12 16:37:11 +03:00
chunked_vector_test.cc
utils/chunked_vector: Fix sigsegv during reserve()
2022-04-12 16:35:17 +03:00
clustering_ranges_walker_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
column_mapping_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
commitlog_test.cc
commitlog_test: Change timeout handling to do abort()
2022-06-29 13:26:51 +03:00
compound_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
compress_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
config_test.cc
config: fix printing of experimental feature list
2022-07-11 09:17:30 +02:00
continuous_data_consumer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
counter_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_auth_query_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_auth_syntax_test.cc
cql3: add a cql3::util::quote() function
2022-02-07 11:33:57 +02:00
cql_functions_test.cc
result_message: add result_message::exception
2022-02-08 11:08:42 +01:00
cql_query_group_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_query_large_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_query_like_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
cql_query_test.cc
cql3: raw_value: deduplicate view() and to_view()
2022-06-17 09:32:58 +02:00
crc_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
data_listeners_test.cc
mutation_reader: move filtering reader into readers/
2022-03-30 15:42:51 +03:00
database_test.cc
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
double_decker_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
duration_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
dynamic_bitset_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
enum_option_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
enum_set_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
error_injection_test.cc
test: error_injection: test_inject_noop: do no rely on wall clock timing
2022-06-21 11:58:13 +03:00
estimated_histogram_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
exception_container_test.cc
exception_container: do not throw in accept
2022-02-16 10:06:10 +02:00
exceptions_fallback_test.cc
utils/exceptions: add try_catch
2022-07-05 16:41:09 +02:00
exceptions_optimized_test.cc
utils/exceptions: add try_catch
2022-07-05 16:41:09 +02:00
exceptions_test.inc.cc
utils: add make_nested_exception_ptr
2022-07-05 16:41:09 +02:00
expr_test.cc
cql3: expr: make evaluate() return a cql3::raw_value rather than an expr::constant
2022-06-15 08:47:24 +02:00
extensions_test.cc
database: add flush_on_all variants
2022-05-10 09:56:44 +03:00
filtering_test.cc
treewide: use system-#include (angle brackets) for seastar
2022-04-26 14:46:42 +03:00
flat_mutation_reader_test.cc
test: mutation: Compare against compacted mutations
2022-06-15 11:30:01 +02:00
flush_queue_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
fragmented_temporary_buffer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
frozen_mutation_test.cc
tests: downgrade_to_v1() -> mutation_fragment_v1_stream()
2022-05-31 23:42:34 +03:00
gossiping_property_file_snitch_test.cc
snitch: Keep gossiper reference
2022-05-03 10:57:40 +03:00
group0_test.cc
service: raft: move group0 write path into a separate file
2022-05-19 17:21:35 +03:00
hash_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
hashers_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
hint_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
idl_test.cc
ser: use vector_deserializer by default for all idl vectors
2022-05-18 19:24:18 +03:00
index_with_paging_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
input_stream_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
intrusive_array_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
json_cql_query_test.cc
type_json: support integers in scientific format
2022-02-22 12:55:38 +01:00
json_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
keys_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
large_paging_state_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
like_matcher_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
limiting_data_source_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
linearizing_input_stream_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
lister_test.cc
treewide: fix compilation issues with fmtlib 8.1.0+
2022-03-16 12:31:50 +03:00
loading_cache_test.cc
loading_cache_test: Test loading_cache::reset and loading_cache::update_config
2022-06-28 19:58:06 -03:00
log_heap_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
logalloc_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
managed_bytes_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
managed_vector_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
map_difference_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
memtable_test.cc
Revert "Merge 'Block flush until compaction finishes if sstables accumulate' from Mikołaj Sielużycki"
2022-07-06 12:19:02 +03:00
multishard_combining_reader_as_mutation_source_test.cc
tests: remove some to-become-pointless reader downgrade tests
2022-05-31 23:42:34 +03:00
multishard_mutation_query_test.cc
test/lib/test_utils: return OK from check() variants
2022-02-21 12:29:25 +02:00
murmur_hash_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
mutation_fragment_test.cc
Merge "Remove reader from mutations v1" from Botond
2022-03-31 13:29:11 +03:00
mutation_query_test.cc
query: coroutinize to_data_query_result
2022-05-05 13:32:25 +03:00
mutation_reader_test.cc
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
mutation_test.cc
tests: Remove sstables_manager& from column_family_test_config()
2022-05-27 16:37:21 +03:00
mutation_writer_test.cc
flat_mutation_reader ist tot
2022-05-31 23:42:34 +03:00
mvcc_test.cc
test: mutation: Compare against compacted mutations
2022-06-15 11:30:01 +02:00
network_topology_strategy_test.cc
snitch: Keep gossiper reference
2022-05-03 10:57:40 +03:00
nonwrapping_range_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
observable_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
partitioner_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
per_partition_rate_limit_test.cc
tests: add per_partition_rate_limit_test
2022-06-22 20:16:49 +02:00
querier_cache_test.cc
test: move away from v1 reader from mutations
2022-03-31 10:36:23 +03:00
query_processor_test.cc
query_processor: remove default internal query caching behavior
2022-05-01 08:33:55 +03:00
radix_tree_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_assert.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_tombstone_list_assertions.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
range_tombstone_list_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
rate_limiter_test.cc
db: add rate_limiter
2022-06-22 20:16:48 +02:00
reader_concurrency_semaphore_test.cc
skeleton_reader: inherit from flat_mutation_reader_v2::impl
2022-04-06 16:55:54 +03:00
repair_test.cc
tests: downgrade_to_v1() -> mutation_fragment_v1_stream()
2022-05-31 23:42:34 +03:00
restrictions_test.cc
cql: Forbid null in lists of IN values
2022-05-24 00:17:41 +02:00
result_utils_test.cc
utils/result_try: prevent exceptions from being caught multiple times
2022-03-15 11:42:42 +02:00
reusable_buffer_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
role_manager_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
row_cache_test.cc
test: mutation: Compare against compacted mutations
2022-06-15 11:30:01 +02:00
rust_test.cc
tests: add rust example
2022-05-11 16:49:31 +02:00
schema_change_test.cc
config: fix printing of experimental feature list
2022-07-11 09:17:30 +02:00
schema_changes_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
schema_loader_test.cc
tools/schema_loader: auto-create the keyspace for all statements
2022-02-17 15:24:24 +02:00
schema_registry_test.cc
user_types: Carry storage on database and schema_ctxt
2022-05-05 13:06:04 +03:00
secondary_index_test.cc
service/paging: use position_in_partition instead of clustering_key for last row
2022-06-23 13:36:20 +03:00
serialization_test.cc
serializer_impl: add vector_deserializer
2022-05-18 19:10:13 +03:00
serialized_action_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
service_level_controller_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
small_vector_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
snitch_reset_test.cc
snitch: Keep gossiper reference
2022-05-03 10:57:40 +03:00
sstable_3_x_test.cc
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
sstable_compaction_test.cc
compaction_manager: major_compaction_task: run in maintenance scheduling groupt
2022-07-06 18:18:45 +03:00
sstable_conforms_to_mutation_source_test.cc
tests: trivial flat_reader_assertions{,_v2} conversions
2022-05-10 22:10:40 +03:00
sstable_datafile_test.cc
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
sstable_directory_test.cc
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
sstable_move_test.cc
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
sstable_mutation_test.cc
Merge 'Remove flat_mutation_reader (v1)' from Michael Livshin
2022-06-03 07:26:29 +03:00
sstable_partition_index_cache_test.cc
sstable: partition_index_cache: Fix abort on bad_alloc during page loading
2022-05-25 09:27:04 +03:00
sstable_resharding_test.cc
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
sstable_set_test.cc
sstable_set: Fix partitioned_sstable_set constructor
2022-06-21 11:58:13 +03:00
sstable_test.cc
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
sstable_test.hh
sstables: use generation_type more soundly
2022-06-20 19:37:31 +03:00
stall_free_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
statement_restrictions_test.cc
treewide: remove unqualified calls to std::move
2022-05-27 16:36:49 +02:00
storage_proxy_test.cc
storage_proxy: extract query_ranges_to_vnodes_generator to a separate file
2022-02-01 21:14:41 +01:00
suite.yaml
tests: Move compaction-related tests into its own unit
2021-08-02 22:26:26 +03:00
test_table.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
top_k_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
total_order_check.hh
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
tracing.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
transport_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
types_test.cc
types: time_point_to_string: use numeric formatting rather than chrono-format specifiers
2022-06-27 08:28:56 +03:00
user_function_test.cc
config: fix printing of experimental feature list
2022-07-11 09:17:30 +02:00
user_types_test.cc
cql3_type::raw_collection: handle unknown types first
2022-06-07 11:16:12 +02:00
utf8_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
UUID_test.cc
test: uuid: cement the assumption that default and null uuid are equal
2022-02-16 10:19:47 +02:00
view_build_test.cc
readers: move multishard reader & friends to reader/multishard.cc
2022-03-30 15:42:51 +03:00
view_complex_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
view_schema_ckey_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
view_schema_pkey_test.cc
materialized views: allow empty strings in views and indexes
2022-03-08 15:34:26 +02:00
view_schema_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
vint_serialization_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
virtual_reader_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00
virtual_table_mutation_source_test.cc
tests: ms.make_reader() -> ms.make_reader_v2()
2022-05-31 23:42:34 +03:00
virtual_table_test.cc
treewide: use Software Package Data Exchange (SPDX) license identifiers
2022-01-18 12:15:18 +01:00