mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-22 17:40:34 +00:00
176aa91be5
This reverts commite77dad3adfbecause its incorrect. Amos explains: "Quote from https://www.freedesktop.org/software/systemd/man/systemd.mount.html What= Takes an absolute path of a device node, file or other resource to mount. See mount(8) for details. If this refers to a device node, a dependency on the respective device unit is automatically created. Where= Takes an absolute path of a file or directory for the mount point; in particular, the destination cannot be a symbolic link. If the mount point does not exist at the time of mounting, it is created as directory. So the mount point is '/var/lib/systemd/coredump' and '/var/lib/scylla/coredump' is the file to mount, because /var/lib/scylla had mounted a second big storage, which has enough space for Huge coredumps. Bentsi or other touched problem with old scylla-master AMI, a coredump occurred but not successfully saved to disk for enospc. The directory /var/lib/systemd/coredump wasn't mounted to /var/lib/scylla/coredump. They WRONGLY thought the wrong mount was caused by the config problem, so he posted a fix. Actually scylla-ami-setup / coredump wasn't executed on that AMI, err: unit scylla-ami-setup.service not found Because 'scylla-ami-setup.service' config file doesn't exist or is invalid. Details of my testing: https://github.com/scylladb/scylla/issues/6300#issuecomment-637324507 So we need to revert Bentsi's patch, it changed the right config to wrong." (cherry picked from commit9d9d54c804)