Michał Chojnowski 93ea3d41d8 position_in_partition: make operator= exception-safe ...

The copy assignment operator of _ck can throw
after _type and _bound_weight have already been changed.
This leaves position_in_partition in an inconsistent state,
potentially leading to various weird symptoms.

The problem was witnessed by test_exception_safety_of_reads.
Specifically: in cache_flat_mutation_reader::add_to_buffer,
which requires the assignment to _lower_bound to be exception-safe.

The easy fix is to perform the only potentially-throwing step first.

Fixes #15822

Closes scylladb/scylladb#15864

2023-10-29 18:30:32 +02:00

..

atomic_cell_hash.hh

types: move types.{cc,hh} into types

2023-02-19 21:05:45 +02:00

atomic_cell_or_collection.hh

Introduce schema/ module

2023-02-15 11:01:50 +02:00

atomic_cell.cc

mutation_partition: compare_row_marker_for_merge: consider ttl in case expiry is the same

2023-06-20 10:10:39 +03:00

atomic_cell.hh

…

canonical_mutation.cc

mutation: do not include unused header

2023-10-17 20:38:07 +03:00

canonical_mutation.hh

Introduce schema/ module

2023-02-15 11:01:50 +02:00

CMakeLists.txt

readers,mutation: move mutation_fragment_stream_validator to mutation/

2023-05-09 07:55:13 -04:00

frozen_mutation.cc

Introduce schema/ module

2023-02-15 11:01:50 +02:00

frozen_mutation.hh

db, storage_proxy: Drop mutation/frozen_mutation ::shard_of()

2023-06-21 00:58:24 +02:00

json.hh

mutation/json: extract generic streaming writer into utils/rjson.hh

2023-10-20 10:04:56 -04:00

mutation_cleaner.hh

mutation: mutation_cleaner: add pause()

2023-06-19 22:50:43 +02:00

mutation_compactor.hh

mutation/mutation_compactor: allow user to abandon current partition

2023-07-27 02:50:44 -04:00

mutation_consumer_concepts.hh

…

mutation_consumer.hh

…

mutation_fragment_fwd.hh

…

mutation_fragment_stream_validator.cc

mutation/mutation_fragment_stream_validator.cc: rename logger

2023-05-09 07:55:13 -04:00

mutation_fragment_stream_validator.hh

mutation: mutation_fragment_stream_validating_filter: add accessor to underlying validator

2023-07-20 08:48:50 -04:00

mutation_fragment_v2.hh

reader_permit: split resource_units::reset()

2023-04-26 07:41:57 -04:00

mutation_fragment.cc

Merge 'reader_permit: minor improvements to resource consume/release safety' from Botond Dénes

2023-05-14 14:14:23 +03:00

mutation_fragment.hh

Merge ' mvcc: make schema upgrades gentle' from Michał Chojnowski

2023-05-24 22:58:43 +02:00

mutation_partition_serializer.cc

…

mutation_partition_serializer.hh

…

mutation_partition_v2.cc

code: Switch to seastar API level 7

2023-06-06 13:29:16 +03:00

mutation_partition_v2.hh

mutation_partition_v2: change schema_ptr to schema& in mutation_partition_v2 constructor

2023-05-04 02:37:29 +02:00

mutation_partition_view.cc

Introduce schema/ module

2023-02-15 11:01:50 +02:00

mutation_partition_view.hh

…

mutation_partition_visitor.hh

Introduce schema/ module

2023-02-15 11:01:50 +02:00

mutation_partition.cc

database: Fix accounting of small partitions in mutation query

2023-09-22 02:53:14 -04:00

mutation_partition.hh

treewide: remove #includes not use directly

2023-07-18 17:36:31 +08:00

mutation_rebuilder.hh

mutation/mutation_rebuilder: add comment about validity of returned mutation reference

2023-07-27 12:13:46 +03:00

mutation_source_metadata.hh

…

mutation.cc

mutation/mutation: add memory_usage()

2023-07-25 10:34:30 -04:00

mutation.hh

mutation/mutation: add memory_usage()

2023-07-25 10:34:30 -04:00

partition_version_list.hh

…

partition_version.cc

partition_version: make partition_entry::upgrade() gentle

2023-05-04 03:35:15 +02:00

partition_version.hh

partition_version: handle multi-schema snapshots in merge_partition_versions

2023-05-04 03:35:15 +02:00

position_in_partition.hh

position_in_partition: make operator= exception-safe

2023-10-29 18:30:32 +02:00

range_tombstone_assembler.hh

…

range_tombstone_change_generator.hh

range_tombstone_change_generator: fix an edge case in flush()

2023-05-16 17:54:08 +02:00

range_tombstone_list.cc

mutation: specialize fmt::formatter<range_tombstone_{entry,list}>

2023-04-26 09:00:25 +03:00

range_tombstone_list.hh

mutation: specialize fmt::formatter<range_tombstone_{entry,list}>

2023-04-26 09:00:25 +03:00

range_tombstone_splitter.hh

…

range_tombstone.cc

mutation: drop operator<<(ostream, const range_tombstone{_change,} &)

2023-03-21 11:37:07 +08:00

range_tombstone.hh

mutation: drop operator<<(ostream, const range_tombstone{_change,} &)

2023-03-21 11:37:07 +08:00

tombstone.hh

treewide: use defaulted operator!=() and operator==()

2023-04-27 10:24:46 +03:00