This PR addresses multiple issues with alternator batch metrics: 1. Rename the metrics to scylla_alternator_batch_item_count with op=BatchGetItem/BatchWriteItem 2. The batch size calculation was wrong and didn't count all items in the batch. 3. Add a test to validate that the metrics values increase by the correct value (not just increase). This also requires an addition to the testing to validate ops of different metrics and an exact value change. Needs backporting to allow the monitoring to use the correct metrics names. Fixes #20571 Closes scylladb/scylladb#20646 * github.com:scylladb/scylladb: alternator:test_metrics test metrics for batch item count alternator:test_metrics Add validating the increased value alternator: Fix item counting in batch operations Alterntor rename batch item count metrics
Scylla in-source tests.
For details on how to run the tests, see docs/dev/testing.md
Shared C++ utils, libraries are in lib/, for Python - pylib/
alternator - Python tests which connect to a single server and use the DynamoDB API unit, boost, raft - unit tests in C++ cql-pytest - Python tests which connect to a single server and use CQL topology* - tests that set up clusters and add/remove nodes cql - approval tests that use CQL and pre-recorded output rest_api - tests for Scylla REST API Port 9000 scylla-gdb - tests for scylla-gdb.py helper script nodetool - tests for C++ implementation of nodetool
If you can use an existing folder, consider adding your test to it. New folders should be used for new large categories/subsystems, or when the test environment is significantly different from some existing suite, e.g. you plan to start scylladb with different configuration, and you intend to add many tests and would like them to reuse an existing Scylla cluster (clusters can be reused for tests within the same folder).
To add a new folder, create a new directory, and then
copy & edit its suite.ini.