mirror of
https://github.com/scylladb/scylladb.git
synced 2026-05-30 03:30:49 +00:00
85d9326d70
The main goal of this patch is to stop using get_config() glbal when creating the sstable_writer_config instance. Other than being global the existing get_config() is also confusing as it effectively generates 3 (three) sorts of configs -- one for scylla, when db config and features are ready, the other one for tests, when no storage service is at hands, and the third one for tests as well, when the storage service is created by test env (likely intentionally, but maybe by coincidence the resulting config is the same as for no-storage-service case). With this patch it's now 100% clear which one is used when. Also this makes half the work of removing get_config() helper. The db::config and feature_service used to initialize the managers are referenced by database that creates and keeps managers on, so the references are safe. Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>