mirror of
https://github.com/scylladb/scylladb.git
synced 2026-04-25 11:00:35 +00:00
3d58e8e424
This reverts commit c42a91ec72.
A significant performance regression was observed due to this change.
From Avi:
> perf-simple-query --smp 1
>
> before:
>
> 216489.88 tps ( 61.1 allocs/op, 13.1 tasks/op, 43558 insns/op, 0 errors)
> 217708.69 tps ( 61.1 allocs/op, 13.1 tasks/op, 43542 insns/op, 0 errors)
> 219495.02 tps ( 61.1 allocs/op, 13.1 tasks/op, 43538 insns/op, 0 errors)
> 216863.84 tps ( 61.1 allocs/op, 13.1 tasks/op, 43567 insns/op, 0 errors)
> 218936.48 tps ( 61.1 allocs/op, 13.1 tasks/op, 43546 insns/op, 0 errors)
>
> after:
>
> 201773.52 tps ( 63.1 allocs/op, 15.1 tasks/op, 44600 insns/op, 0 errors)
> 210875.48 tps ( 63.1 allocs/op, 15.1 tasks/op, 44558 insns/op, 0 errors)
> 210186.55 tps ( 63.1 allocs/op, 15.1 tasks/op, 44588 insns/op, 0 errors)
> 211021.76 tps ( 63.1 allocs/op, 15.1 tasks/op, 44569 insns/op, 0 errors)
> 208597.52 tps ( 63.1 allocs/op, 15.1 tasks/op, 44587 insns/op, 0 errors)
>
> Two extra allocations, two extra tasks, 1k extra instructions, for
> something that is DDL only.
Fixes #14590
77 lines
1.7 KiB
C++
77 lines
1.7 KiB
C++
|
|
/*
|
|
* Copyright (C) 2015-present ScyllaDB
|
|
*/
|
|
|
|
/*
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
#ifndef SERVICE_QUERY_STATE_HH
|
|
#define SERVICE_QUERY_STATE_HH
|
|
|
|
#include "service/client_state.hh"
|
|
#include "tracing/tracing.hh"
|
|
#include "service_permit.hh"
|
|
|
|
namespace qos {
|
|
class service_level_controller;
|
|
}
|
|
namespace service {
|
|
|
|
class query_state final {
|
|
private:
|
|
client_state& _client_state;
|
|
tracing::trace_state_ptr _trace_state_ptr;
|
|
service_permit _permit;
|
|
|
|
public:
|
|
query_state(client_state& client_state, service_permit permit)
|
|
: _client_state(client_state)
|
|
, _trace_state_ptr(tracing::trace_state_ptr())
|
|
, _permit(std::move(permit))
|
|
{}
|
|
|
|
query_state(client_state& client_state, tracing::trace_state_ptr trace_state_ptr, service_permit permit)
|
|
: _client_state(client_state)
|
|
, _trace_state_ptr(std::move(trace_state_ptr))
|
|
, _permit(std::move(permit))
|
|
{ }
|
|
|
|
const tracing::trace_state_ptr& get_trace_state() const {
|
|
return _trace_state_ptr;
|
|
}
|
|
|
|
tracing::trace_state_ptr& get_trace_state() {
|
|
return _trace_state_ptr;
|
|
}
|
|
|
|
client_state& get_client_state() {
|
|
return _client_state;
|
|
}
|
|
|
|
const client_state& get_client_state() const {
|
|
return _client_state;
|
|
}
|
|
api::timestamp_type get_timestamp() {
|
|
return _client_state.get_timestamp();
|
|
}
|
|
|
|
service_permit get_permit() const& {
|
|
return _permit;
|
|
}
|
|
|
|
service_permit&& get_permit() && {
|
|
return std::move(_permit);
|
|
}
|
|
|
|
qos::service_level_controller& get_service_level_controller() const {
|
|
return _client_state.get_service_level_controller();
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
|
|
#endif
|