mirrors/scylladb
1
0
Fork 0
mirror of https://github.com/scylladb/scylladb.git synced 2026-05-29 19:21:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
22fe38732dc3dee2f17a2753be67eaa6d5ea93c8
scylladb/cql3
History
Piotr Sarna 43a3719fe4 cql3: fix potential segfault on disengaged optional 
In untyped_result_set::get_view, there exists a silent assumption
that the underlying data, which is an optional, to always be engaged.
In case the value happens to be disengaged it may lead to creating
an incorrect bytes view from a disengaged optional.
In order to make the code safer (since values parsed by this code
often come from the network and can contain virtually anything)
a segfault is replaced with an exception, by calling optional's
value() function, which throws when called on disengaged optionals.

Fixes #6915
Tests: unit(dev)
Message-Id: <6e9e4ca67e0e17c17b718ab454c3130c867684e2.1595834092.git.sarna@scylladb.com>
2020-07-28 10:06:00 +03:00
..
functions
cql3/functions: protect against uninitialized value
2020-07-15 12:38:39 +03:00
restrictions
cql3: Fix tombstone-range check for TRUE
2020-07-27 09:19:37 +02:00
selection
cql3/restrictions: Use free functions instead of methods
2020-07-07 23:08:09 +02:00
statements
cql3: Fix tombstone-range check for TRUE
2020-07-27 09:19:37 +02:00
abstract_marker.cc
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
abstract_marker.hh
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
assignment_testable.hh
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
attributes.cc
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
attributes.hh
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
authorized_prepared_statements_cache.hh
Configure authorized_prepared_statment_cache memory limit during object creation
2018-06-11 15:34:14 +03:00
cf_name.cc
…
cf_name.hh
…
column_condition.cc
cql3: use lw_shared_ptr instead of shared_ptr for column_condition
2020-05-06 13:11:07 +03:00
column_condition.hh
cql3: use lw_shared_ptr instead of shared_ptr for column_condition
2020-05-06 13:11:07 +03:00
column_identifier.cc
cql3: const cleanups and API de-pointerization
2020-02-20 18:14:49 +02:00
column_identifier.hh
cql: remove unused functions
2020-06-08 11:28:57 +03:00
column_specification.cc
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
column_specification.hh
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
constants.cc
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
constants.hh
headers: Remove mutation.hh from trace_state.hh
2020-07-17 17:40:23 +03:00
cql3_type.cc
cql3: Simplify maybe_quote
2020-02-04 10:52:04 +02:00
cql3_type.hh
cql3: pass a const user_types_metadata& to prepare_internal
2019-12-11 10:44:40 -08:00
cql_config.hh
cql: single_column_clustering_key_restrictions: limit cartesian products
2019-08-21 19:35:59 +02:00
cql_statement.hh
lwt: introduce "LWT" flag in prepared statement metadata
2020-06-29 12:30:37 +03:00
Cql.g
cql: pass cql3::operation::raw_deletion by unique_ptr
2020-06-06 21:04:06 +03:00
error_collector.hh
treewide: add const qualifiers throughout the code base
2019-11-26 02:24:49 +03:00
error_listener.hh
…
index_name.cc
…
index_name.hh
Update seastar submodule
2018-11-21 00:01:44 +02:00
keyspace_element_name.cc
cql3: Pass a string_view to keyspace_element_name::set_keyspace
2020-02-28 08:36:27 -08:00
keyspace_element_name.hh
cql3: Pass a string_view to keyspace_element_name::set_keyspace
2020-02-28 08:36:27 -08:00
lists.cc
cql3::lists: Fix setter_by_uuid not handing null value
2020-07-15 13:52:09 +02:00
lists.hh
cql3/restrictions: Add free functions over new classes
2020-06-26 09:19:36 -04:00
maps.cc
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
maps.hh
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
multi_column_relation.hh
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
operation_impl.hh
cql3: use unique_ptr's for cql3::operation::raw_update
2020-05-31 23:45:19 +03:00
operation.cc
cql3: use unique_ptr's for cql3::operation::raw_update
2020-05-31 23:45:19 +03:00
operation.hh
cql: pass cql3::operation::raw_deletion by unique_ptr
2020-06-06 21:04:06 +03:00
operator.cc
cql3: Add LIKE relation
2019-07-04 10:54:30 +02:00
operator.hh
cql3/restrictions: Add free functions over new classes
2020-06-26 09:19:36 -04:00
prepared_statements_cache.hh
Configure prepared_statements_cache memory limit from outside
2018-06-11 15:34:13 +03:00
query_options_fwd.hh
…
query_options.cc
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
query_options.hh
treewide: update concepts language from the Concepts TS to C++20
2020-06-02 09:12:21 +03:00
query_processor.cc
cql3: remove unused functions get_stored_prepared_statement*
2020-05-28 09:09:48 +02:00
query_processor.hh
cql3: add explanatory comments to execute_internal
2020-07-07 11:54:36 +02:00
relation.cc
cql3: avoid using shared_ptr's in unrecognized_entity_exception
2020-05-06 19:02:36 +03:00
relation.hh
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
result_generator.hh
cql3: add lazy result_generator
2018-06-25 09:21:47 +01:00
result_set.cc
lwt: introduce "LWT" flag in prepared statement metadata
2020-06-29 12:30:37 +03:00
result_set.hh
lwt: introduce "LWT" flag in prepared statement metadata
2020-06-29 12:30:37 +03:00
role_name.cc
…
role_name.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
role_options.hh
…
sets.cc
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
sets.hh
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
single_column_relation.cc
cql3/restrictions: Separate AST for single column
2020-07-16 12:27:25 +02:00
single_column_relation.hh
headers: Remove mutation.hh from trace_state.hh
2020-07-17 17:40:23 +03:00
stats.hh
cql3: single metric for range scan and full scan
2020-02-18 16:16:20 +02:00
term.hh
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
token_relation.cc
cql3/restrictions: Drop dead code
2020-07-07 23:08:09 +02:00
token_relation.hh
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
tuples.cc
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
tuples.hh
headers: Remove mutation.hh from trace_state.hh
2020-07-17 17:40:23 +03:00
type_cast.hh
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
type_json.cc
treewide: replace libjsoncpp usage with rjson
2020-07-03 10:27:23 +02:00
type_json.hh
treewide: replace libjsoncpp usage with rjson
2020-07-03 10:27:23 +02:00
untyped_result_set.cc
cql3: Pass std::string_view to various untyped_result_set member functions
2020-06-15 15:47:15 -07:00
untyped_result_set.hh
cql3: fix potential segfault on disengaged optional
2020-07-28 10:06:00 +03:00
update_parameters.cc
cql: turn prefetch_data::row into struct
2019-10-28 21:12:52 +03:00
update_parameters.hh
headers: Remove mutation.hh from trace_state.hh
2020-07-17 17:40:23 +03:00
user_types.cc
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
user_types.hh
cql3: pass column_specification by ref to cql3::assignment_testable functions
2020-05-30 09:49:29 +03:00
ut_name.cc
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
ut_name.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
util.hh
cql3: return raw::parsed_statement as unique_ptr
2020-03-23 23:19:21 +03:00
values.hh
Replace std::experimental types with C++17 std version.
2019-01-08 13:16:36 +02:00
variable_specifications.cc
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00
variable_specifications.hh
cql3: pass column_specification via lw_shared_ptr
2020-04-27 12:47:42 +03:00